Commit Graph

16280 Commits

Author SHA1 Message Date
Vince Grassia 64844600dc
Fix alert message for Desktop builds (#11139) 2024-09-19 10:40:55 +02:00
renovate[bot] a96e3cb647
[deps] Tools: Update electron to v32.1.1 (#11067)
* [deps] Tools: Update electron to v32.1.1

* Bump version in electron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 23:41:07 +02:00
Jordan Aasen 00f2317a82
[PM-11903] - add file send component (#11132)
* wip - send file details

* wip - file send

* send file details

* fix click on send list container

* remove popup code

* remove popup code

* finalize send file details

* address PR feedback. add base form to send form

* revert changes to send list items container

* revert changes to send list items container

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-09-18 14:36:53 -07:00
Cesar Gonzalez e3cd8482a2
Merge branch 'main' into autofill/pm-12316-implement-inline-menu-passkeys-loading-state 2024-09-18 16:23:51 -05:00
Alec Rippberger 2b6184f1f0
PM-11338: [Defect] Clicking outside of View {Item} dialog should close the dialog properly (#11035)
* Handle undefined result.

* Updated enum values for consistency.
2024-09-18 16:23:38 -05:00
Alec Rippberger b2966d71d9
[PM-11395] [Defect] View Login - TOTP premium badge does nothing when clicked (#10857)
* Add MessagingService to LoginCredentialView component.

* Add comments.

* Add WIP PremiumUpgradeService

* Simplify web PremiumUpgradeServices into one service.

* Relocate service files.

* Add browser version of PremiumUpgradePromptService.

* Cleanup debug comments.

* Run prettier.

* rework promptForPremium to take organization id and add test.

* Add test for browser

* Rework imports to fix linter errors.

* Add Shane's reworked WebVaultPremiumUpgradePromptService.
2024-09-18 16:23:38 -05:00
cyprain-okeke 30d02903d6
Resolve the discount issue (#11128) 2024-09-18 16:23:37 -05:00
Alec Rippberger 5445823fbc
[PM- 9666] Implement edit item view individual vault (#10553)
* Add initial vault cipher form for cipher edit.

* Add ability to add new cipher by type

* Add ability to save and clone cipher,

* Update canEditAllCiphers to take 1 argument.

* Add attachments button to add/edit dialog.

* Add semi-working attachment dialog.

* Add working attachment functionality.

* Remove debugging code.

* Add tests for new attachments dialog component.

* Add AddEditComponentV2 tests.

* Remove AddEditComponentV2 delete functionality.

* Remove unnecessary else statement.

* Launch password generation in new dialog when extension refresh enabled.

* Add tests for PasswordGeneratorComponent.

* Adjust password and attachments dialog sizes.

* run lint:fix

* Remove unnecessary form from button.

* Add missing provider in test.

* Remove password generation events.

* Add WebVaultGeneratorDialogComponent and WebCipherFormGenerationService

* Move and rename CipherFormQueryParams

* Use WebCipherFormGenerationService to launch password / user generation modals.

* Add WebVaultGeneratorDialogComponent tests.

* Remove unnecessary functionality and corresponding tests.

* Fix failing tests.

* Remove unused properties from AddEditComponentV2

* Pass CipherFormConfig to dialog.

* Clean up unused attachment dialog functionality.

* Update AddEdit cancel functionality to prevent navigating user.

* Make attachment dialog open a static method.

* Add addCipherV2 method and clean up tests.

* Remove changes to QueryParams.

* Add tests for WebCipherFormGenerationService

* Remove unused onCipherSaved method.

* Remove cipherSaved event.

* Remove unused password generator component

* Refactor to simplify editCipherId for extensionRefresh flag.

* Add additional comments to AddEditComponentV2.

* Simplify open vault generator dialog comment.

* Remove unused organizationService

* Remove unnecessary typecasting.

* Remove extensionRefreshEnabled and related.

* Remove slideIn animation

* Remove unused AddEditComponentV2 properties.

* Add back generic typing.

* Condesnse properties into single form config.

* Remove onDestroy and related code.

* Run prettier

* fix injection warning

* Handle cipher save.

* Redirect to vault on delete and make actions consistent.

* Update comment.
2024-09-18 16:23:37 -05:00
Daniel James Smith 075619daa7
[PM-12067] Add sorting to exposed passwords report (#11029)
* Add sorting to exposed passwords report

- Create new type to represent a row within the report
- Add types and remove usage of any
- Include the exposed number of times within the data passed to the datasource/table instead of looking it up via the `exposedPasswordMap`
- Enable sorting via bitSortable
- Set default sort to order by exposed number of times in descending order

* Show headers and sort also within AC version of exposed-passwords report but hide the Owner column

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 16:23:37 -05:00
Jordan Aasen 04972d5018
use tw classes for svg colors in no-credentials.svg (#11129) 2024-09-18 16:23:37 -05:00
Aftab Ali 1b2cc7abc5
[PM-11882] Handled identity item and unsupported items during ProtonPass import. (#10967) 2024-09-18 16:23:36 -05:00
David Torosyan 3b638549a2
[desktop] Allow manual sync while locked (#6126)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 16:23:36 -05:00
Alec Rippberger 2b85392b0f
PM-11338: [Defect] Clicking outside of View {Item} dialog should close the dialog properly (#11035)
* Handle undefined result.

* Updated enum values for consistency.
2024-09-18 16:02:47 -05:00
Alec Rippberger 6c1d74a4ce
[PM-11395] [Defect] View Login - TOTP premium badge does nothing when clicked (#10857)
* Add MessagingService to LoginCredentialView component.

* Add comments.

* Add WIP PremiumUpgradeService

* Simplify web PremiumUpgradeServices into one service.

* Relocate service files.

* Add browser version of PremiumUpgradePromptService.

* Cleanup debug comments.

* Run prettier.

* rework promptForPremium to take organization id and add test.

* Add test for browser

* Rework imports to fix linter errors.

* Add Shane's reworked WebVaultPremiumUpgradePromptService.
2024-09-18 16:00:54 -05:00
cyprain-okeke 1940256fe2
Resolve the discount issue (#11128) 2024-09-18 18:55:31 +01:00
Alec Rippberger 931f86c948
[PM- 9666] Implement edit item view individual vault (#10553)
* Add initial vault cipher form for cipher edit.

* Add ability to add new cipher by type

* Add ability to save and clone cipher,

* Update canEditAllCiphers to take 1 argument.

* Add attachments button to add/edit dialog.

* Add semi-working attachment dialog.

* Add working attachment functionality.

* Remove debugging code.

* Add tests for new attachments dialog component.

* Add AddEditComponentV2 tests.

* Remove AddEditComponentV2 delete functionality.

* Remove unnecessary else statement.

* Launch password generation in new dialog when extension refresh enabled.

* Add tests for PasswordGeneratorComponent.

* Adjust password and attachments dialog sizes.

* run lint:fix

* Remove unnecessary form from button.

* Add missing provider in test.

* Remove password generation events.

* Add WebVaultGeneratorDialogComponent and WebCipherFormGenerationService

* Move and rename CipherFormQueryParams

* Use WebCipherFormGenerationService to launch password / user generation modals.

* Add WebVaultGeneratorDialogComponent tests.

* Remove unnecessary functionality and corresponding tests.

* Fix failing tests.

* Remove unused properties from AddEditComponentV2

* Pass CipherFormConfig to dialog.

* Clean up unused attachment dialog functionality.

* Update AddEdit cancel functionality to prevent navigating user.

* Make attachment dialog open a static method.

* Add addCipherV2 method and clean up tests.

* Remove changes to QueryParams.

* Add tests for WebCipherFormGenerationService

* Remove unused onCipherSaved method.

* Remove cipherSaved event.

* Remove unused password generator component

* Refactor to simplify editCipherId for extensionRefresh flag.

* Add additional comments to AddEditComponentV2.

* Simplify open vault generator dialog comment.

* Remove unused organizationService

* Remove unnecessary typecasting.

* Remove extensionRefreshEnabled and related.

* Remove slideIn animation

* Remove unused AddEditComponentV2 properties.

* Add back generic typing.

* Condesnse properties into single form config.

* Remove onDestroy and related code.

* Run prettier

* fix injection warning

* Handle cipher save.

* Redirect to vault on delete and make actions consistent.

* Update comment.
2024-09-18 12:48:47 -05:00
Daniel James Smith a674f698a2
[PM-12067] Add sorting to exposed passwords report (#11029)
* Add sorting to exposed passwords report

- Create new type to represent a row within the report
- Add types and remove usage of any
- Include the exposed number of times within the data passed to the datasource/table instead of looking it up via the `exposedPasswordMap`
- Enable sorting via bitSortable
- Set default sort to order by exposed number of times in descending order

* Show headers and sort also within AC version of exposed-passwords report but hide the Owner column

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 18:53:04 +02:00
Jordan Aasen c9bcdd60ac
use tw classes for svg colors in no-credentials.svg (#11129) 2024-09-18 18:50:49 +02:00
Cesar Gonzalez d7224b2ea6
[PM-12316] Incorporating jest tests to validate logic additions to the InlineMenuList 2024-09-18 11:35:58 -05:00
Aftab Ali 0f3d8a6f89
[PM-11882] Handled identity item and unsupported items during ProtonPass import. (#10967) 2024-09-18 19:28:47 +03:00
David Torosyan 2d7fb035d4
[desktop] Allow manual sync while locked (#6126)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 17:57:32 +02:00
Cesar Gonzalez 2b901f99d4
Merge branch 'main' into autofill/pm-12316-implement-inline-menu-passkeys-loading-state 2024-09-18 10:54:30 -05:00
Cesar Gonzalez 54f23516e1
[PM-12316] Incorporating jest tests to validate logic additions to the InlineMenuList 2024-09-18 10:52:16 -05:00
Cesar Gonzalez 3849ab74e4
[PM-12316] Incorporating jest tests to validate logic additions to the overlay background 2024-09-18 10:44:43 -05:00
cyprain-okeke 727fbb6731
Ac 3030 discount is not included in the pricing breakdown when annual plan (#11126)
* Resolve the discount issues

* Resolve the payment cvv alignment

* Resolve the wrong message for secrets manager

* Remove unused commented code

* resolve the display message bug on sm flow
2024-09-18 16:22:04 +01:00
Cesar Gonzalez aab44fe740
[PM-12316] Refactoring name of utils method 2024-09-18 10:16:27 -05:00
Cesar Gonzalez 418cf18e09
[PM-12316] Adding documentation to the implementation and fixing small visual issues 2024-09-18 10:02:40 -05:00
Bernd Schoolmann f6e51ef024
Don't process reload when cancelling biometrics (#11081) 2024-09-18 10:41:23 -04:00
Cesar Gonzalez 79b20a2c98
Merge branch 'main' into autofill/pm-8833-implement-on-page-autofill-menu-for-password-generation 2024-09-18 09:15:04 -05:00
Cesar Gonzalez ce62ffc66e
Merge branch 'main' into autofill/pm-12316-implement-inline-menu-passkeys-loading-state 2024-09-18 09:15:01 -05:00
Daniel James Smith be6f257398
Fix click on copy send link and delete send buttons (#11120)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 09:17:07 -04:00
Victoria League bd4b3933a4
[PM-8582] Improve search performance in Safari (#11088) 2024-09-18 09:13:58 -04:00
Marc Bärtschi 502d8ed729
fix wrong buffer conversion for Uint8Array (#8787)
If the BufferSource is already an Uint8Array which is a view of a subset of the underlying ArrayBuffer then accessing .buffer caused the whole backing buffer to be returned. Fix this by just returning the original Uint8Array as-is.

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2024-09-18 08:11:22 -04:00
Jordan Aasen f8fc6269f2
[PM-11899] - send text details component (#11002)
* Temporary local changes not meant to be merged

* WIP - send text details

* send text details

* remove extraneous code

* create base send details component

* remove file components

* fix send text details form

* remove comments

* fix send text details component

* revert type changes

* send created redirect

* Revert "send created redirect"

This reverts commit 36711d54a3.

* Removed hint under textArea, as per design

* Removed unused message keys

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 14:04:51 +02:00
Bernd Schoolmann 1b7bb014d2
[PM-11312] Add "prevent screenshot" setting to windows and mac (#10707)
* Add screenshot protection to windows and mac

* Update messaging of screencapture prevention feature

* Set default state to false
2024-09-18 12:38:35 +02:00
bw-ghapp[bot] 18ef74930c
Bumped client version(s) (#11118)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-18 00:39:01 +00:00
Cesar Gonzalez 56d7f8a0e9
[PM-12316] Implement inline menu passkeys authenticating state 2024-09-17 16:44:59 -05:00
Justin Baur e8979decae
Add Back Safari Only Handling of Process Reload (#11115) 2024-09-17 16:58:23 -04:00
Cesar Gonzalez e51fa35a2b
Merge branch 'main' into autofill/pm-12316-implement-inline-menu-passkeys-loading-state 2024-09-17 15:35:28 -05:00
Cesar Gonzalez 74354cced9
Merge branch 'main' into autofill/pm-8833-implement-on-page-autofill-menu-for-password-generation 2024-09-17 15:34:46 -05:00
Cesar Gonzalez 2779e02e6e
[PM-12316] Implement inline menu passkeys authenticating state 2024-09-17 15:33:50 -05:00
Shane Melton 99ba56785d
[PM-11393] Remove the need for TotpCaptureService in Autofill Options View component (#11093) 2024-09-17 13:15:11 -07:00
Jordan Aasen 1a961ee294
fix send list item button hover (#11109) 2024-09-17 21:05:19 +02:00
Alec Rippberger 80a9836cb2
Navigate to fault after cipher deleted. (#11042) 2024-09-17 14:00:21 -05:00
Jason Ng d0516f24e8
[AC-2627] Empty Collection New Item Btn Permissions (#11089)
* only show new item btn in empty collection for can edit perm
2024-09-17 14:28:39 -04:00
Nick Krantz d68853a4a2
[PM-11131] Screen Reader Announcements for Copy (#11091)
* add copy specific aria-labels for login ciphers

* add copy specific aria-labels for card ciphers

* add copy translations for identity to web translations
2024-09-17 13:23:15 -05:00
Cesar Gonzalez 01a9999c9b
[PM-8833] Implementing fill behvaior for the new password elements 2024-09-17 13:17:51 -05:00
Cesar Gonzalez e02880162e
[PM-8833] Working through placement of the password generator 2024-09-17 12:05:38 -05:00
Cesar Gonzalez 552b6f8076
[PM-8833] Working through placement of the password generator 2024-09-17 12:01:07 -05:00
Cesar Gonzalez f9eb56dff5
[PM-8833] Working through placement of the password generator 2024-09-17 11:45:11 -05:00