From fbba9b673d1c99e54d2839a0ed68e0ca90f0fe04 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Thu, 2 Nov 2017 09:17:53 -0400
Subject: [PATCH] fixes during crypto service testing

---
 src/background.html                          | 1 -
 src/popup/app/config.js                      | 2 +-
 src/popup/app/lock/lockController.js         | 4 +++-
 src/popup/app/services/authService.js        | 6 ++++--
 src/popup/app/tools/toolsExportController.js | 4 +++-
 src/services/crypto.service.ts               | 4 ++--
 6 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/background.html b/src/background.html
index 118292fa31..1c618fa8f2 100644
--- a/src/background.html
+++ b/src/background.html
@@ -6,7 +6,6 @@
     <script type="text/javascript" src="lib/forge/forge.js"></script>
     <script type="text/javascript" src="models/api/requestModels.js"></script>
     <script type="text/javascript" src="models/domainModels.js"></script>
-    <script type="text/javascript" src="services/cryptoService.js"></script>
     <script type="text/javascript" src="services/tokenService.js"></script>
     <script type="text/javascript" src="services/apiService.js"></script>
     <script type="text/javascript" src="services/userService.js"></script>
diff --git a/src/popup/app/config.js b/src/popup/app/config.js
index 06a54a0fe9..b5b29d9c92 100644
--- a/src/popup/app/config.js
+++ b/src/popup/app/config.js
@@ -265,7 +265,7 @@ angular
             });
     })
     .run(function ($trace, $transitions, userService, $state, constantsService, stateService) {
-        $trace.enable('TRANSITION');
+        //$trace.enable('TRANSITION');
 
         stateService.init();
 
diff --git a/src/popup/app/lock/lockController.js b/src/popup/app/lock/lockController.js
index fa9eae492c..d185f68cff 100644
--- a/src/popup/app/lock/lockController.js
+++ b/src/popup/app/lock/lockController.js
@@ -26,7 +26,9 @@ angular
         $scope.submit = function () {
             userService.getEmail(function (email) {
                 var key = cryptoService.makeKey($scope.masterPassword, email);
-                cryptoService.hashPassword($scope.masterPassword, key).then(function (keyHash) {
+                var keyHash;
+                cryptoService.hashPassword($scope.masterPassword, key).then(function (theKeyHash) {
+                    keyHash = theKeyHash;
                     return cryptoService.getKeyHash();
                 }).then(function (storedKeyHash) {
                     if (storedKeyHash && keyHash && storedKeyHash === keyHash) {
diff --git a/src/popup/app/services/authService.js b/src/popup/app/services/authService.js
index 6bd72be89f..52b9ba5053 100644
--- a/src/popup/app/services/authService.js
+++ b/src/popup/app/services/authService.js
@@ -9,12 +9,14 @@ angular
             email = email.toLowerCase();
             var key = cryptoService.makeKey(masterPassword, email),
                 deferred = $q.defer(),
-                deviceRequest = null;
+                deviceRequest = null,
+                twoFactorRememberedToken;
 
             appIdService.getAppId().then(function (appId) {
                 deviceRequest = new DeviceRequest(appId, utilsService);
                 return tokenService.getTwoFactorToken(email);
-            }).then(function (twoFactorRememberedToken) {
+            }).then(function (theTwoFactorRememberedToken) {
+                twoFactorRememberedToken = theTwoFactorRememberedToken;
                 return cryptoService.hashPassword(masterPassword, key);
             }).then(function (hashedPassword) {
                 var request;
diff --git a/src/popup/app/tools/toolsExportController.js b/src/popup/app/tools/toolsExportController.js
index 2962166457..d03bb2e6c6 100644
--- a/src/popup/app/tools/toolsExportController.js
+++ b/src/popup/app/tools/toolsExportController.js
@@ -24,7 +24,9 @@ angular
 
             userService.getEmail(function (email) {
                 var key = cryptoService.makeKey($scope.masterPassword, email);
-                cryptoService.hashPassword($scope.masterPassword, key).then(function (keyHash) {
+                var keyHash;
+                cryptoService.hashPassword($scope.masterPassword, key).then(function (theKeyHash) {
+                    keyHash = theKeyHash;
                     return cryptoService.getKeyHash();
                 }).then(function (storedKeyHash) {
                     if (storedKeyHash && keyHash && storedKeyHash === keyHash) {
diff --git a/src/services/crypto.service.ts b/src/services/crypto.service.ts
index 3b955e2cdc..29014f6502 100644
--- a/src/services/crypto.service.ts
+++ b/src/services/crypto.service.ts
@@ -76,7 +76,7 @@ export default class CryptoService {
 
     async getKey(): Promise<SymmetricCryptoKey> {
         if (this.key != null) {
-            return;
+            return this.key;
         }
 
         const option = await this.utilsService.getObjFromStorage<number>(ConstantsService.lockOptionKey);
@@ -126,7 +126,7 @@ export default class CryptoService {
 
     async getPrivateKey(): Promise<ArrayBuffer> {
         if (this.privateKey != null) {
-            return Promise.resolve(this.privateKey);
+            return this.privateKey;
         }
 
         const encPrivateKey = await this.utilsService.getObjFromStorage<string>(Keys.encPrivateKey);