devol
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

[AC-2614] Member access test fix (#10969) 

* Initial setup and modifications for member access report api implementation

* Adding the permissions logic for getting the permissions text

* fixing the test cases

* Some refactoring on async calls

* Comments on the model

* Resolving the mock issue

* messages

* Localization of text

* One more file to fix merge

* Fixing test case localization lookup

* Fixed permissions lookup
This commit is contained in:
Tom 2024-09-09 16:58:56 -04:00 committed by GitHub
parent 124b4ce822
commit cdb40818a8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bitwarden_license/bit-web/src/app/tools/reports/member-access-report/services/member-access-report.service.spec.ts
View File

@ -10,13 +10,17 @@ describe("ImportService", () => {
const mockOrganizationId = "mockOrgId" as OrganizationId;
const reportApiService = mock<MemberAccessReportApiService>();
let memberAccessReportService: MemberAccessReportService;
const i18nService = mock<I18nService>();
const i18nMock = mock<I18nService>({
t(key) {
return key;
},
});
beforeEach(() => {
reportApiService.getMemberAccessData.mockImplementation(() =>
Promise.resolve(memberAccessReportsMock),
);
memberAccessReportService = new MemberAccessReportService(reportApiService, i18nService);
memberAccessReportService = new MemberAccessReportService(reportApiService, i18nMock);
});
describe("generateMemberAccessReportView", () => {
@ -92,16 +96,16 @@ describe("ImportService", () => {
expect.objectContaining({
email: "sjohnson@email.com",
name: "Sarah Johnson",
twoStepLogin: "On",
accountRecovery: "On",
twoStepLogin: "memberAccessReportTwoFactorEnabledTrue",
accountRecovery: "memberAccessReportAuthenticationEnabledTrue",
group: "Group 1",
totalItems: "20",
}),
expect.objectContaining({
email: "jlull@email.com",
name: "James Lull",
twoStepLogin: "Off",
accountRecovery: "Off",
twoStepLogin: "memberAccessReportTwoFactorEnabledFalse",
accountRecovery: "memberAccessReportAuthenticationEnabledFalse",
group: "Group 4",
totalItems: "5",
}),

2
bitwarden_license/bit-web/src/app/tools/reports/member-access-report/services/member-access-report.service.ts
View File

@ -82,7 +82,7 @@ export class MemberAccessReportService {
: this.i18nService.t("memberAccessReportNoCollection"),
collectionPermission: detail.collectionId
? this.getPermissionText(detail)
: this.i18nService.t("memberAccessReportNoCollection"),
: this.i18nService.t("memberAccessReportNoCollectionPermission"),
totalItems: detail.itemCount.toString(),
};
});