devol
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

[CL-192][CL-193] fix virtual scroll (#7986) 

* [CL-192] use sticky sidebar instead of static; remove main screen height

* [CL-193] patch cdk dialog scroll block
This commit is contained in:
Will Martin 2024-02-19 08:52:42 -05:00 committed by GitHub
parent 1f8e6ea6f8
commit cbcd5d9747
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/popup/scss/base.scss
View File

@ -6,12 +6,6 @@
margin: 0;
}
html {
&.cdk-global-scrollblock {
position: unset;
}
}
html,
body {
font-family: $font-family-sans-serif;

4
libs/components/src/layout/layout.component.html
View File

@ -22,14 +22,14 @@
'--color-background-alt4': 'var(--color-secondary-300)'
}
"
class="tw-inset-y-0 tw-left-0 tw-h-screen tw-w-60 tw-overflow-auto tw-bg-background-alt3"
class="tw-sticky tw-inset-y-0 tw-h-screen tw-w-60 tw-overflow-auto tw-bg-background-alt3"
>
<ng-content select="[slot=sidebar]"></ng-content>
</aside>
<main
[id]="mainContentId"
tabindex="-1"
class="tw-overflow-auto tw-h-screen tw-min-w-0 tw-flex-1 tw-bg-background tw-p-6"
class="tw-overflow-auto tw-min-w-0 tw-flex-1 tw-bg-background tw-p-6"
>
<ng-content></ng-content>
</main>

6
libs/components/src/tw-theme.css
View File

@ -200,3 +200,9 @@ summary.tw-list-none::-webkit-details-marker {
.cdk-overlay-pane {
z-index: 2000 !important;
}
.cdk-global-scrollblock {
position: unset;
height: 100%;
overflow: hidden;
}