Merge 1c0e949838
into c21a58f2fb
This commit is contained in:
commit
c6492cb024
|
@ -110,7 +110,7 @@ export class AccountSwitcherService {
|
|||
}),
|
||||
);
|
||||
|
||||
// Create a reusable observable that listens to the the switchAccountFinish message and returns the userId from the message
|
||||
// Create a reusable observable that listens to the switchAccountFinish message and returns the userId from the message
|
||||
this.switchAccountFinished$ = fromChromeEvent<[message: { command: string; userId: string }]>(
|
||||
chrome.runtime.onMessage,
|
||||
).pipe(
|
||||
|
|
|
@ -203,7 +203,7 @@ describe("BrowserPopupUtils", () => {
|
|||
expect(BrowserPopupUtils["buildPopoutUrl"]).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("replaces any existing `uilocation=` query params within the passed extension url path to state the the uilocaiton is a popup", async () => {
|
||||
it("replaces any existing `uilocation=` query params within the passed extension url path to state the uilocation is a popup", async () => {
|
||||
const url = "popup/index.html?uilocation=sidebar#/tabs/vault";
|
||||
jest.spyOn(BrowserPopupUtils as any, "isSingleActionPopoutOpen").mockResolvedValueOnce(false);
|
||||
|
||||
|
|
|
@ -164,7 +164,7 @@ export class DesktopSettingsService {
|
|||
|
||||
/**
|
||||
* Sets the setting for whether or not the application should be shown in the dock.
|
||||
* @param value `true` if the application should should in the dock, `false` if it should not.
|
||||
* @param value `true` if the application should show in the dock, `false` if it should not.
|
||||
*/
|
||||
async setAlwaysShowDock(value: boolean) {
|
||||
await this.alwaysShowDockState.update(() => value);
|
||||
|
|
|
@ -28,7 +28,7 @@ export class ObservableTracker<T> {
|
|||
);
|
||||
}
|
||||
|
||||
/** Awaits until the the total number of emissions observed by this tracker equals or exceeds {@link count}
|
||||
/** Awaits until the total number of emissions observed by this tracker equals or exceeds {@link count}
|
||||
* @param count The number of emissions to wait for
|
||||
*/
|
||||
async pauseUntilReceived(count: number, msTimeout = 50): Promise<T[]> {
|
||||
|
|
|
@ -252,7 +252,7 @@ export class TokenService implements TokenServiceAbstraction {
|
|||
|
||||
if (!accessTokenKey) {
|
||||
// If we don't have an accessTokenKey, then that means we don't have an access token as it hasn't been set yet
|
||||
// and we have to return null here to properly indicate the the user isn't logged in.
|
||||
// and we have to return null here to properly indicate the user isn't logged in.
|
||||
return null;
|
||||
}
|
||||
|
||||
|
|
|
@ -223,7 +223,7 @@ export abstract class CryptoService {
|
|||
*/
|
||||
abstract makeOrgKey<T extends OrgKey | ProviderKey>(): Promise<[EncString, T]>;
|
||||
/**
|
||||
* Sets the the user's encrypted private key in storage and
|
||||
* Sets the user's encrypted private key in storage and
|
||||
* clears the decrypted private key from memory
|
||||
* Note: does not clear the private key if null is provided
|
||||
* @param encPrivateKey An encrypted private key
|
||||
|
|
|
@ -154,7 +154,7 @@ export class MigrationHelper {
|
|||
*
|
||||
* This is useful from creating migrations off of this paradigm, but should not be used once a value is migrated to a state provider.
|
||||
*
|
||||
* @returns a list of all accounts that have been authenticated with state service, cast the the expected type.
|
||||
* @returns a list of all accounts that have been authenticated with state service, cast the expected type.
|
||||
*/
|
||||
async getAccounts<ExpectedAccountType>(): Promise<
|
||||
{ userId: string; account: ExpectedAccountType }[]
|
||||
|
|
|
@ -50,7 +50,7 @@ element after close since a user may not want to close the dialog immediately if
|
|||
additional interactive elements. See
|
||||
[WCAG Focus Order success criteria](https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html)
|
||||
|
||||
Once closed, focus should remain on the the element which triggered the Dialog.
|
||||
Once closed, focus should remain on the element which triggered the Dialog.
|
||||
|
||||
**Note:** If a Simple Dialog is triggered from a main Dialog, be sure to make sure focus is moved to
|
||||
the Simple Dialog.
|
||||
|
|
|
@ -16,7 +16,7 @@ always use the native `form` element and bind a `formGroup`.
|
|||
|
||||
Forms consists of 1 or more inputs, and ends with 1 or 2 buttons.
|
||||
|
||||
If there are many inputs in a form, they should should be organized into sections as content
|
||||
If there are many inputs in a form, they should be organized into sections as content
|
||||
relates. **Example:** Item type form
|
||||
|
||||
Each input within a section should follow the following spacing guidelines (see
|
||||
|
|
Loading…
Reference in New Issue