From 7c0423a1c0ab63b53dea0b7ae1db0ec388a76cf2 Mon Sep 17 00:00:00 2001 From: Thomas Rittson Date: Fri, 2 Apr 2021 14:55:23 +1000 Subject: [PATCH 1/3] Fix bgcolor of option els when in FF sidebar --- src/popup/scss/misc.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/popup/scss/misc.scss b/src/popup/scss/misc.scss index 49fc31ab73..261f174eba 100644 --- a/src/popup/scss/misc.scss +++ b/src/popup/scss/misc.scss @@ -338,3 +338,9 @@ input[type="password"]::-ms-reveal { } } } + +// Workaround for rendering error in Firefox sidebar when in dark mode +// option elements will not render background-color correctly if identical to parent background-color +html.theme_dark select option { + background-color: adjust-color(map-get(map-get($themes, dark), inputBackgroundColor), +1); +} From 809e2b68d139b40bc0533d317977ad08706f92e1 Mon Sep 17 00:00:00 2001 From: Thomas Rittson Date: Fri, 2 Apr 2021 15:00:49 +1000 Subject: [PATCH 2/3] apply fix to nord theme also --- src/popup/scss/misc.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/popup/scss/misc.scss b/src/popup/scss/misc.scss index 261f174eba..54582b3aa4 100644 --- a/src/popup/scss/misc.scss +++ b/src/popup/scss/misc.scss @@ -339,8 +339,8 @@ input[type="password"]::-ms-reveal { } } -// Workaround for rendering error in Firefox sidebar when in dark mode +// Workaround for rendering error in Firefox sidebar // option elements will not render background-color correctly if identical to parent background-color -html.theme_dark select option { +html.theme_dark select option, html.theme_nord select option { background-color: adjust-color(map-get(map-get($themes, dark), inputBackgroundColor), +1); } From b63074f00daaa4984afd4f71e1ffc9fe3d678e1f Mon Sep 17 00:00:00 2001 From: Thomas Rittson Date: Fri, 2 Apr 2021 15:05:57 +1000 Subject: [PATCH 3/3] Apply fix to all themes --- src/popup/scss/misc.scss | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/popup/scss/misc.scss b/src/popup/scss/misc.scss index 54582b3aa4..59613dcbcd 100644 --- a/src/popup/scss/misc.scss +++ b/src/popup/scss/misc.scss @@ -341,6 +341,8 @@ input[type="password"]::-ms-reveal { // Workaround for rendering error in Firefox sidebar // option elements will not render background-color correctly if identical to parent background-color -html.theme_dark select option, html.theme_nord select option { - background-color: adjust-color(map-get(map-get($themes, dark), inputBackgroundColor), +1); +select option { + @include themify($themes) { + background-color: adjust-color(themed('inputBackgroundColor'), +1); + } }