From 902d72457cbeb99ef5d9eb69945ad43658f69277 Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Mon, 26 Feb 2018 23:34:02 -0500 Subject: [PATCH] analytics disabled by default on mas --- src/misc/analytics.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/misc/analytics.ts b/src/misc/analytics.ts index 98cfdebc5b..e78635815c 100644 --- a/src/misc/analytics.ts +++ b/src/misc/analytics.ts @@ -8,7 +8,7 @@ const GaObj = 'ga'; export class Analytics { private gaTrackingId: string = null; - private isFirefox = false; + private defaultDisabled = false; private appVersion: string; constructor(win: Window, private gaFilter?: () => boolean, @@ -28,7 +28,7 @@ export class Analytics { } this.appVersion = this.platformUtilsService.getApplicationVersion(); - this.isFirefox = this.platformUtilsService.isFirefox(); + this.defaultDisabled = this.platformUtilsService.isFirefox() || this.platformUtilsService.isMacAppStore(); this.gaTrackingId = this.platformUtilsService.analyticsId(); (win as any).GoogleAnalyticsObject = GaObj; @@ -43,8 +43,7 @@ export class Analytics { } const disabled = await this.storageService.get(ConstantsService.disableGaKey); - // Default for Firefox is disabled. - if ((this.isFirefox && disabled == null) || disabled != null && disabled) { + if ((this.defaultDisabled && disabled == null) || disabled != null && disabled) { return; }