[PM-8833] Working through fixing field qualification issues
This commit is contained in:
parent
a2f2e6b9fd
commit
7efae38745
|
@ -3286,10 +3286,6 @@ describe("AutofillService", () => {
|
|||
);
|
||||
|
||||
expect(AutofillService.forCustomFieldsOnly).toHaveBeenCalledWith(excludedField);
|
||||
expect(AutofillService["isExcludedFieldType"]).toHaveBeenCalledWith(
|
||||
excludedField,
|
||||
AutoFillConstants.ExcludedAutofillTypes,
|
||||
);
|
||||
expect(AutofillService["isFieldMatch"]).not.toHaveBeenCalled();
|
||||
expect(value.script).toStrictEqual([]);
|
||||
});
|
||||
|
|
|
@ -1866,7 +1866,10 @@ export default class AutofillService implements AutofillServiceInterface {
|
|||
*/
|
||||
private excludeFieldFromIdentityFill(field: AutofillField): boolean {
|
||||
return (
|
||||
AutofillService.isExcludedFieldType(field, AutoFillConstants.ExcludedAutofillTypes) ||
|
||||
AutofillService.isExcludedFieldType(field, [
|
||||
"password",
|
||||
...AutoFillConstants.ExcludedAutofillTypes,
|
||||
]) ||
|
||||
AutoFillConstants.ExcludedIdentityAutocompleteTypes.has(field.autoCompleteType) ||
|
||||
!field.viewable
|
||||
);
|
||||
|
|
|
@ -35,7 +35,7 @@ export class InlineMenuFieldQualificationService
|
|||
private autofillFieldKeywordsMap: AutofillKeywordsMap = new WeakMap();
|
||||
private submitButtonKeywordsMap: SubmitButtonKeywordsMap = new WeakMap();
|
||||
private autocompleteDisabledValues = new Set(["off", "false"]);
|
||||
private newFieldKeywords = new Set(["new", "change", "neue", "ändern"]);
|
||||
private newFieldKeywords = new Set(["new", "neue", "ändern"]);
|
||||
private accountCreationFieldKeywords = [
|
||||
...new Set(["register", "registration", "create", "confirm", ...this.newFieldKeywords]),
|
||||
];
|
||||
|
|
Loading…
Reference in New Issue