Hide email address in Sends (#895)

* Let organizations disable anonymous sends only * Add hide email option to send * Display warning for anonymous Sends * Enforce new Send policy, fix naming conventions * Minor UI improvements * Fix linting * Fully disable editing anonymous Sends per policy * Revert "Let organizations disable anonymous sends only" This reverts commit 7877cb7751e6e765d45cf6ffbe5a684e60923b56. * Revert disableSendPolicy, add sendOptionsPolicy * Rework UI for enforcing DisableHideEmail * Fix typo * Minor UI tweaks * Minor UI tweaks * Tweaks to UI copy * Apply suggestions from code review Minor changes to UI text Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com> * style fixes * update jslib * Move SendOptionsExemptions warning banner * updated service params * Remove whitespace * updated jslib * Revert "updated jslib" This reverts commit 8fd141c5b77acabac81ee2995dd09870eb98593a. * updated jslib * Attachment azure upload blobs (#898) * Upload and download attachments using direct urls * Include FileUploadService dependency * Update max file size message to current max * Update jslib * Update jslib * updated service params Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com> Co-authored-by: addison <addisonbeck1@gmail.com> Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2021-03-30 07:47:45 +10:00 · 2021-03-30 07:47:45 +10:00 · 6bb6a674ec
parent 29d7a5e37e
commit 6bb6a674ec
7 changed files with 81 additions and 3 deletions
--- a/src/app/organizations/manage/policies.component.ts
+++ b/src/app/organizations/manage/policies.component.ts
@ -109,6 +109,13 @@ export class PoliciesComponent implements OnInit {
                    enabled: false,
                    display: true,
                },
+                {
+                    name: this.i18nService.t('sendOptions'),
+                    description: this.i18nService.t('sendOptionsPolicyDesc'),
+                    type: PolicyType.SendOptions,
+                    enabled: false,
+                    display: true,
+                },
            ];
            await this.load();

--- a/src/app/organizations/manage/policy-edit.component.html
+++ b/src/app/organizations/manage/policy-edit.component.html
@ -35,6 +35,9 @@
                <app-callout type="warning" *ngIf="type === policyType.DisableSend">
                    {{'disableSendExemption' | i18n}}
                </app-callout>
+                <app-callout type="warning" *ngIf="type === policyType.SendOptions">
+                    {{'sendOptionsExemption' | i18n}}
+                </app-callout>
                <div class="form-group">
                    <div class="form-check">
                        <input class="form-check-input" type="checkbox" id="enabled" [(ngModel)]="enabled"
@ -147,6 +150,14 @@
                        <label class="form-check-label" for="passGenIncludeNumber">{{'includeNumber' | i18n}}</label>
                    </div>
                </ng-container>
+                <ng-container *ngIf="type === policyType.SendOptions">
+                    <h3 class="mt-4">{{'options' | i18n}}</h3>
+                    <div class="form-check">
+                        <input class="form-check-input" type="checkbox" id="sendDisableHideEmail" [(ngModel)]="sendDisableHideEmail"
+                            name="SendDisableHideEmail">
+                        <label class="form-check-label" for="sendDisableHideEmail">{{'disableHideEmail' | i18n}}</label>
+                    </div>
+                </ng-container>
            </div>
            <div class="modal-footer">
                <button type="submit" class="btn btn-primary btn-submit" [disabled]="form.loading">
--- a/src/app/organizations/manage/policy-edit.component.ts
+++ b/src/app/organizations/manage/policy-edit.component.ts
@ -38,7 +38,6 @@ export class PolicyEditComponent implements OnInit {
    defaultTypes: any[];

    // Master password
-
    masterPassMinComplexity?: number = null;
    masterPassMinLength?: number;
    masterPassRequireUpper?: number;
@ -47,7 +46,6 @@ export class PolicyEditComponent implements OnInit {
    masterPassRequireSpecial?: number;

    // Password generator
-
    passGenDefaultType?: string;
    passGenMinLength?: number;
    passGenUseUpper?: boolean;
@ -60,6 +58,9 @@ export class PolicyEditComponent implements OnInit {
    passGenCapitalize?: boolean;
    passGenIncludeNumber?: boolean;

+    // Send options
+    sendDisableHideEmail?: boolean;
+
    private policy: PolicyResponse;

    constructor(private apiService: ApiService, private i18nService: I18nService,
@ -113,6 +114,9 @@ export class PolicyEditComponent implements OnInit {
                            this.masterPassRequireNumbers = this.policy.data.requireNumbers;
                            this.masterPassRequireSpecial = this.policy.data.requireSpecial;
                            break;
+                        case PolicyType.SendOptions:
+                            this.sendDisableHideEmail = this.policy.data.disableHideEmail;
+                            break;
                        default:
                            break;
                    }
@ -159,6 +163,11 @@ export class PolicyEditComponent implements OnInit {
                        requireSpecial: this.masterPassRequireSpecial,
                    };
                    break;
+                case PolicyType.SendOptions:
+                    request.data = {
+                        disableHideEmail: this.sendDisableHideEmail,
+                    };
+                    break;
                default:
                    break;
            }
--- a/src/app/send/access.component.html
+++ b/src/app/send/access.component.html
@ -6,6 +6,13 @@
        <div class="col-12 text-center" *ngIf="creatorIdentifier != null">
            <p>{{'sendCreatorIdentifier' | i18n: creatorIdentifier }}</p>
        </div>
+        <div class="col-8" *ngIf="creatorIdentifier == null && !loading && !unavailable">
+            <app-callout type="warning" title="{{'warning' | i18n}}">
+                {{'viewSendHiddenEmailWarning' | i18n }} <a href="https://bitwarden.com/help/article/receive-send/">{{'learnMore' | i18n}}</a>.
+            </app-callout>
+        </div>
+    </div>
+    <div class="row justify-content-center">
        <div class="col-5">
            <div class="card d-block">
                <div class="card-body" *ngIf="loading" class="text-center">
--- a/src/app/send/add-edit.component.html
+++ b/src/app/send/add-edit.component.html
@ -12,6 +12,12 @@
                <app-callout *ngIf="disableSend">
                    <span>{{'sendDisabledWarning' | i18n}}</span>
                </app-callout>
+                <app-callout *ngIf="!disableSend && disableHideEmail">
+                    <span>{{'sendOptionsPolicyInEffect' | i18n}}</span>
+                    <ul class="mb-0">
+                        <li>{{'sendDisableHideEmailInEffect' | i18n}}</li>
+                    </ul>
+                </app-callout>
                <div class="row">
                    <div class="col-6 form-group">
                        <label for="name">{{'name' | i18n}}</label>
@ -207,6 +213,15 @@
                            [readOnly]="disableSend"></textarea>
                        <div class="form-text text-muted small">{{'sendNotesDesc' | i18n}}</div>
                    </div>
+                    <div class="form-group">
+                        <div class="form-check">
+                            <input class="form-check-input" type="checkbox" [(ngModel)]="send.hideEmail" id="hideEmail" 
+                            name="HideEmail" [disabled]="(disableHideEmail && !send.hideEmail) || disableSend">
+                            <label class="form-check-label" for="hideEmail">
+                                {{'hideEmail' | i18n}}
+                            </label>
+                        </div>
+                    </div>
                    <div class="form-group">
                        <div class="form-check">
                            <input class="form-check-input" type="checkbox" [(ngModel)]="send.disabled" id="disabled"
--- a/src/app/services/services.module.ts
+++ b/src/app/services/services.module.ts
@ -65,7 +65,7 @@ import { CryptoFunctionService as CryptoFunctionServiceAbstraction } from 'jslib
 import { EnvironmentService as EnvironmentServiceAbstraction } from 'jslib/abstractions/environment.service';
 import { EventService as EventLoggingServiceAbstraction } from 'jslib/abstractions/event.service';
 import { ExportService as ExportServiceAbstraction } from 'jslib/abstractions/export.service';
-import { FileUploadService as FileUploadServiceAbstraction } from 'jslib/abstractions/fileUpload.service';
+import { FileUploadService as FileUploadServiceAbstraction }  from 'jslib/abstractions/fileUpload.service';
 import { FolderService as FolderServiceAbstraction } from 'jslib/abstractions/folder.service';
 import { I18nService as I18nServiceAbstraction } from 'jslib/abstractions/i18n.service';
 import { ImportService as ImportServiceAbstraction } from 'jslib/abstractions/import.service';
--- a/src/locales/en/messages.json
+++ b/src/locales/en/messages.json
@ -3416,6 +3416,9 @@
  "removePasswordConfirmation": {
    "message": "Are you sure you want to remove the password?"
  },
+  "hideEmail": {
+    "message": "Hide my email address from recipients."
+  },
  "disableThisSend": {
    "message": "Disable this Send so that no one can access it.",
    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
@ -3635,6 +3638,28 @@
    "message": "Due to an enterprise policy, you are only able to delete an existing Send.",
    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
  },
+  "sendOptions": {
+    "message": "Send Options",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
+  },
+  "sendOptionsPolicyDesc": {
+    "message": "Set options for creating and editing Sends.",
+    "description": "'Sends' is a plural noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
+  },
+  "sendOptionsExemption": {
+    "message": "Organization users that can manage the organization's policies are exempt from this policy's enforcement."
+  },
+  "disableHideEmail": {
+    "message": "Do not allow users to hide their email address from recipients when creating or editing a Send.",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
+  },
+  "sendOptionsPolicyInEffect": {
+    "message": "The following organization policies are currently in effect:"
+  },
+  "sendDisableHideEmailInEffect": {
+    "message": "Users are not allowed to hide their email address from recipients when creating or editing a Send.",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
+  },
  "modifiedPolicyId": {
    "message": "Modified policy $ID$.",
    "placeholders": {
@ -3775,6 +3800,10 @@
      }
    }
  },
+  "viewSendHiddenEmailWarning": {
+    "message": "The Bitwarden user who created this Send has chosen to hide their email address. You should ensure you trust the source of this link before using or downloading its content.",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
+  },
  "expirationDateIsInvalid": {
    "message": "The expiration date provided is not valid."
  },