devol
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

use devFlags.skipWelcomeOnInstall instead of platformUtilsService.isDev

This commit is contained in:
Jonathan Prusik 2024-05-01 11:19:45 -04:00
parent d5b262db17
commit 622d8b25d4
No known key found for this signature in database
GPG Key ID: 83CF2DF735A5EC35
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/browser/config/development.json
View File

@ -2,7 +2,8 @@
"devFlags": { "devFlags": {
"managedEnvironment": { "managedEnvironment": {
"base": "https://localhost:8080" "base": "https://localhost:8080"
} },
"skipWelcomeOnInstall": true
}, },
"flags": { "flags": {
"showPasswordless": true, "showPasswordless": true,

3
apps/browser/src/background/runtime.background.ts
View File

@ -8,6 +8,7 @@ import { ConfigService } from "@bitwarden/common/platform/abstractions/config/co
import { LogService } from "@bitwarden/common/platform/abstractions/log.service"; import { LogService } from "@bitwarden/common/platform/abstractions/log.service";
import { MessagingService } from "@bitwarden/common/platform/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/platform/abstractions/messaging.service";
import { SystemService } from "@bitwarden/common/platform/abstractions/system.service"; import { SystemService } from "@bitwarden/common/platform/abstractions/system.service";
import { devFlagEnabled } from "@bitwarden/common/platform/misc/flags";
import { Utils } from "@bitwarden/common/platform/misc/utils"; import { Utils } from "@bitwarden/common/platform/misc/utils";
import { CipherType } from "@bitwarden/common/vault/enums"; import { CipherType } from "@bitwarden/common/vault/enums";
@ -324,7 +325,7 @@ export default class RuntimeBackground {
if (this.onInstalledReason != null) { if (this.onInstalledReason != null) {
if (this.onInstalledReason === "install") { if (this.onInstalledReason === "install") {
if (!this.platformUtilsService.isDev()) { if (!devFlagEnabled("skipWelcomeOnInstall")) {
void BrowserApi.createNewTab("https://bitwarden.com/browser-start/"); void BrowserApi.createNewTab("https://bitwarden.com/browser-start/");
} }

1
libs/common/src/platform/misc/flags.ts
View File

@ -10,6 +10,7 @@ export type SharedFlags = {
// eslint-disable-next-line @typescript-eslint/ban-types // eslint-disable-next-line @typescript-eslint/ban-types
export type SharedDevFlags = { export type SharedDevFlags = {
noopNotifications: boolean; noopNotifications: boolean;
skipWelcomeOnInstall: boolean;
}; };
function getFlags<T>(envFlags: string | T): T { function getFlags<T>(envFlags: string | T): T {