devol
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

[PM-730] Corrected EventType when copying password (#5229) 

* [PM-730] Corrected EventType when copying password

* [PM-730] Corrected copy password and totp events
This commit is contained in:
aj-rosado 2023-04-27 16:46:48 +01:00 committed by GitHub
parent def3b1436d
commit 525de3bfd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 14 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/browser/src/vault/popup/components/action-buttons.component.ts
View File

@ -67,11 +67,10 @@ export class ActionButtonsComponent {
this.i18nService.t("valueCopied", this.i18nService.t(typeI18nKey))
);
if (typeI18nKey === "password" || typeI18nKey === "verificationCodeTotp") {
this.eventCollectionService.collect(
EventType.Cipher_ClientToggledHiddenFieldVisible,
cipher.id
);
if (typeI18nKey === "password") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedPassword, cipher.id);
} else if (typeI18nKey === "verificationCodeTotp") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedHiddenField, cipher.id);
} else if (typeI18nKey === "securityCode") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedCardCode, cipher.id);
}

5
apps/web/src/app/vault/individual-vault/add-edit.component.ts
View File

@ -150,10 +150,7 @@ export class AddEditComponent extends BaseAddEditComponent implements OnInit, On
if (this.editMode) {
if (typeI18nKey === "password") {
this.eventCollectionService.collect(
EventType.Cipher_ClientToggledHiddenFieldVisible,
this.cipherId
);
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedPassword, this.cipherId);
} else if (typeI18nKey === "securityCode") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedCardCode, this.cipherId);
} else if (aType === "H_Field") {

9
apps/web/src/app/vault/individual-vault/vault.component.ts
View File

@ -813,11 +813,10 @@ export class VaultComponent implements OnInit, OnDestroy {
this.i18nService.t("valueCopied", this.i18nService.t(typeI18nKey))
);
if (field === "password" || field === "totp") {
this.eventCollectionService.collect(
EventType.Cipher_ClientToggledHiddenFieldVisible,
cipher.id
);
if (field === "password") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedPassword, cipher.id);
} else if (field === "totp") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedHiddenField, cipher.id);
}
}

9
apps/web/src/app/vault/org-vault/vault.component.ts
View File

@ -857,11 +857,10 @@ export class VaultComponent implements OnInit, OnDestroy {
this.i18nService.t("valueCopied", this.i18nService.t(typeI18nKey))
);
if (field === "password" || field === "totp") {
this.eventCollectionService.collect(
EventType.Cipher_ClientToggledHiddenFieldVisible,
cipher.id
);
if (field === "password") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedPassword, cipher.id);
} else if (field === "totp") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedHiddenField, cipher.id);
}
}

5
libs/angular/src/vault/components/view.component.ts
View File

@ -336,10 +336,7 @@ export class ViewComponent implements OnDestroy, OnInit {
);
if (typeI18nKey === "password") {
this.eventCollectionService.collect(
EventType.Cipher_ClientToggledHiddenFieldVisible,
this.cipherId
);
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedPassword, this.cipherId);
} else if (typeI18nKey === "securityCode") {
this.eventCollectionService.collect(EventType.Cipher_ClientCopiedCardCode, this.cipherId);
} else if (aType === "H_Field") {