From 3e9f904e844e2cc6e3feae88cf7d5dee4ef3552d Mon Sep 17 00:00:00 2001 From: Jared Snider Date: Thu, 2 May 2024 18:26:24 -0400 Subject: [PATCH] PM-7392 - TokenSvc - getRefreshToken should return null or a value - not undefined. --- libs/common/src/auth/services/token.service.spec.ts | 2 +- libs/common/src/auth/services/token.service.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/common/src/auth/services/token.service.spec.ts b/libs/common/src/auth/services/token.service.spec.ts index f24e137045..1bbd49ea7c 100644 --- a/libs/common/src/auth/services/token.service.spec.ts +++ b/libs/common/src/auth/services/token.service.spec.ts @@ -1214,7 +1214,7 @@ describe("TokenService", () => { // Act const result = await (tokenService as any).getRefreshToken(); // Assert - expect(result).toBeUndefined(); + expect(result).toBeNull(); }); it("should return null if no refresh token is found in memory, disk, or secure storage", async () => { diff --git a/libs/common/src/auth/services/token.service.ts b/libs/common/src/auth/services/token.service.ts index f6d05a4c0f..0ea8fd6bb3 100644 --- a/libs/common/src/auth/services/token.service.ts +++ b/libs/common/src/auth/services/token.service.ts @@ -550,11 +550,11 @@ export class TokenService implements TokenServiceAbstraction { } } - async getRefreshToken(userId?: UserId): Promise { + async getRefreshToken(userId?: UserId): Promise { userId ??= await firstValueFrom(this.activeUserIdGlobalState.state$); if (!userId) { - return undefined; + return null; } // pre-secure storage migration: