From 3bfddd004345b28eea74298cb1d562c0d87367a0 Mon Sep 17 00:00:00 2001 From: Daniel James Smith Date: Sun, 2 Jan 2022 16:09:28 +0100 Subject: [PATCH] Move cardholder containsOptions to CC constants --- src/services/autofill.service.ts | 2 +- src/services/autofillConstants.ts | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/services/autofill.service.ts b/src/services/autofill.service.ts index 8e897403df..65fbf217a9 100644 --- a/src/services/autofill.service.ts +++ b/src/services/autofill.service.ts @@ -383,7 +383,7 @@ export default class AutofillService implements AutofillServiceInterface { // ref https://developers.google.com/web/fundamentals/design-and-ux/input/forms/ if (!fillFields.cardholderName && this.isFieldMatch(f[attr], CreditCardAutoFillConstants.CardHolderFieldNames, - ['cc-name', 'card-name', 'cardholder-name', 'cardholder', 'tbName'])) { + CreditCardAutoFillConstants.CardHolderFieldNameValues)) { fillFields.cardholderName = f; break; } else if (!fillFields.number && this.isFieldMatch(f[attr], diff --git a/src/services/autofillConstants.ts b/src/services/autofillConstants.ts index f474f4e71d..1fdbf69807 100644 --- a/src/services/autofillConstants.ts +++ b/src/services/autofillConstants.ts @@ -66,6 +66,14 @@ export class CreditCardAutoFillConstants { "nom", ]; + static readonly CardHolderFieldNameValues: string[] = [ + "cc-name", + "card-name", + "cardholder-name", + "cardholder", + "tbName", + ]; + static readonly CardNumberFieldNames: string[] = [ "cc-number", "cc-num",