From 2841cff90a8ff8136b5d580443725be792521bea Mon Sep 17 00:00:00 2001 From: Tomer Shvueli Date: Tue, 4 May 2021 22:25:58 -0400 Subject: [PATCH] feat: enable copying of TOTP code when auto filling credentials (#278) * feat: Help enable copying of TOTP code when auto filling credentials * fix: Update constant to stay consistent --- src/abstractions/totp.service.ts | 1 + src/services/constants.service.ts | 2 ++ src/services/totp.service.ts | 4 ++++ 3 files changed, 7 insertions(+) diff --git a/src/abstractions/totp.service.ts b/src/abstractions/totp.service.ts index 608c7d1b3d..2dc7971456 100644 --- a/src/abstractions/totp.service.ts +++ b/src/abstractions/totp.service.ts @@ -2,4 +2,5 @@ export abstract class TotpService { getCode: (key: string) => Promise; getTimeInterval: (key: string) => number; isAutoCopyEnabled: () => Promise; + isAutoCopyOnAutoFillEnabled: () => Promise; } diff --git a/src/services/constants.service.ts b/src/services/constants.service.ts index 23a24d134e..a140994451 100644 --- a/src/services/constants.service.ts +++ b/src/services/constants.service.ts @@ -8,6 +8,7 @@ export class ConstantsService { static readonly disableBadgeCounterKey: string = 'disableBadgeCounter'; static readonly disableAutoTotpCopyKey: string = 'disableAutoTotpCopy'; static readonly enableAutoFillOnPageLoadKey: string = 'enableAutoFillOnPageLoad'; + static readonly enableAutoTotpCopyOnAutoFillKey: string = 'enableAutoTotpCopyOnAutoFillKey'; static readonly vaultTimeoutKey: string = 'lockOption'; static readonly vaultTimeoutActionKey: string = 'vaultTimeoutAction'; static readonly lastActiveKey: string = 'lastActive'; @@ -39,6 +40,7 @@ export class ConstantsService { readonly disableBadgeCounterKey: string = ConstantsService.disableBadgeCounterKey; readonly disableAutoTotpCopyKey: string = ConstantsService.disableAutoTotpCopyKey; readonly enableAutoFillOnPageLoadKey: string = ConstantsService.enableAutoFillOnPageLoadKey; + readonly enableAutoTotpCopyOnAutoFillKey: string = ConstantsService.enableAutoTotpCopyOnAutoFillKey; readonly vaultTimeoutKey: string = ConstantsService.vaultTimeoutKey; readonly vaultTimeoutActionKey: string = ConstantsService.vaultTimeoutActionKey; readonly lastActiveKey: string = ConstantsService.lastActiveKey; diff --git a/src/services/totp.service.ts b/src/services/totp.service.ts index aa4f8dd143..5f7a332aea 100644 --- a/src/services/totp.service.ts +++ b/src/services/totp.service.ts @@ -109,6 +109,10 @@ export class TotpService implements TotpServiceAbstraction { return !(await this.storageService.get(ConstantsService.disableAutoTotpCopyKey)); } + async isAutoCopyOnAutoFillEnabled(): Promise { + return await this.storageService.get(ConstantsService.enableAutoTotpCopyOnAutoFillKey); + } + // Helpers private leftPad(s: string, l: number, p: string): string {