From 157ab4364e5a503573260f2352269cbb549f04cb Mon Sep 17 00:00:00 2001 From: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com> Date: Thu, 10 Nov 2022 13:11:36 -0500 Subject: [PATCH] Defect/sg 650 desktop pw/passphrase gen not auto updating on min value change (#4032) * SG-650 - Desktop - Pw Generation - Min value ctrls now use (change) instead of (blur) for better responsiveness when using arrows on input or arrow keys. Note: (input) has change detection issues for resetting the value to either max pw length or max value of 9 + passwordGeneration.service logic possibly needs refactoring to either enforce max of 9 or not * SG-650 - Desktop - Passphrase Gen - min words now uses (change) instead of (blur) for better responsiveness --- apps/desktop/src/app/vault/generator.component.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/desktop/src/app/vault/generator.component.html b/apps/desktop/src/app/vault/generator.component.html index 6fdd33f0fa..221e4b211f 100644 --- a/apps/desktop/src/app/vault/generator.component.html +++ b/apps/desktop/src/app/vault/generator.component.html @@ -151,7 +151,7 @@ type="number" min="3" max="20" - (blur)="savePasswordOptions()" + (change)="savePasswordOptions()" [(ngModel)]="passwordOptions.numWords" /> @@ -268,7 +268,7 @@ type="number" min="0" max="9" - (blur)="savePasswordOptions()" + (change)="savePasswordOptions()" [(ngModel)]="passwordOptions.minNumber" /> @@ -279,7 +279,7 @@ type="number" min="0" max="9" - (blur)="savePasswordOptions()" + (change)="savePasswordOptions()" [(ngModel)]="passwordOptions.minSpecial" />