diff --git a/apps/browser/src/autofill/content/abstractions/autofill-init.ts b/apps/browser/src/autofill/content/abstractions/autofill-init.ts index b6cbd3e4b2..8a9c97e67d 100644 --- a/apps/browser/src/autofill/content/abstractions/autofill-init.ts +++ b/apps/browser/src/autofill/content/abstractions/autofill-init.ts @@ -1,5 +1,4 @@ import { AuthenticationStatus } from "@bitwarden/common/auth/enums/authentication-status"; -import { InlineMenuVisibilitySetting } from "@bitwarden/common/autofill/types"; import { CipherType } from "@bitwarden/common/vault/enums"; import { AutofillOverlayElementType } from "../../enums/autofill-overlay.enum"; @@ -25,8 +24,6 @@ export type AutofillExtensionMessage = { data?: { direction?: "previous" | "next" | "current"; forceCloseInlineMenu?: boolean; - settingType?: CipherType; - newSettingValue?: InlineMenuVisibilitySetting | boolean; }; }; diff --git a/apps/browser/src/autofill/services/autofill.service.ts b/apps/browser/src/autofill/services/autofill.service.ts index 0522e5f677..1ff2341d9f 100644 --- a/apps/browser/src/autofill/services/autofill.service.ts +++ b/apps/browser/src/autofill/services/autofill.service.ts @@ -3080,10 +3080,12 @@ export default class AutofillService implements AutofillServiceInterface { return; } + const isInlineMenuVisibilitySubSetting = + typeof oldSettingValue === "boolean" || typeof newSettingValue === "boolean"; const inlineMenuPreviouslyDisabled = oldSettingValue === AutofillOverlayVisibility.Off; const inlineMenuCurrentlyDisabled = newSettingValue === AutofillOverlayVisibility.Off; if ( - typeof newSettingValue !== "boolean" && + !isInlineMenuVisibilitySubSetting && !inlineMenuPreviouslyDisabled && !inlineMenuCurrentlyDisabled ) {