devol/LinkStack
1
0
Fork 0
mirror of https://github.com/LinkStackOrg/LinkStack.git synced 2025-05-06 04:49:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Removed requirement for "simplexml" extension

Browse Source 
Replaced the usage of simplexml_import_dom() with an alternative method to extract favicon URLs from the HTML
https://github.com/LinkStackOrg/linkstack-docker/pull/76
https://github.com/LinkStackOrg/linkstack-docker/issues/75
This commit is contained in:
Julian Prieber 2023-07-14 16:40:27 +02:00
parent b99a975de1
commit faeb78fd7b
1 changed files with 55 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
resources/views/components/favicon.blade.php
View File

@ -33,18 +33,9 @@ function getFaviconURL($url)
$dom->strictErrorChecking = false;
@$dom->loadHTMLFile($url);
if ($dom) {
$domxml = simplexml_import_dom($dom);
// Check for the historical rel="shortcut icon"
if ($domxml->xpath('//link[@rel="shortcut icon"]')) {
$path = $domxml->xpath('//link[@rel="shortcut icon"]');
$faviconURL = getAbsoluteUrl($url, $path[0]['href']);
return $faviconURL;
}
// Check for the HTML5 rel="icon"
elseif ($domxml->xpath('//link[@rel="icon"]')) {
$path = $domxml->xpath('//link[@rel="icon"]');
$faviconURL = getAbsoluteUrl($url, $path[0]['href']);
return $faviconURL;
$faviconURL = extractFaviconUrlFromDOM($dom);
if ($faviconURL) {
return getAbsoluteUrl($url, $faviconURL);
}
}
} catch (Exception $e) {
@ -53,15 +44,13 @@ function getFaviconURL($url)
// Check directly for favicon.ico or favicon.png
$parse = parse_url($url);
$favicon_headers = @get_headers("http://" . $parse['host'] . "/favicon.ico");
if ($favicon_headers && $favicon_headers[0] != 'HTTP/1.1 404 Not Found') {
$faviconURL = "http://" . $parse['host'] . "/favicon.ico";
$faviconURL = getAbsoluteUrl($url, "/favicon.ico");
if (checkURLExists($faviconURL)) {
return $faviconURL;
}
$favicon_headers = @get_headers("http://" . $parse['host'] . "/favicon.png");
if ($favicon_headers && $favicon_headers[0] != 'HTTP/1.1 404 Not Found') {
$faviconURL = "http://" . $parse['host'] . "/favicon.png";
$faviconURL = getAbsoluteUrl($url, "/favicon.png");
if (checkURLExists($faviconURL)) {
return $faviconURL;
}
@ -81,6 +70,33 @@ function getRedirectUrlFromHeaders($headers)
return null;
}
function extractFaviconUrlFromDOM($dom)
{
$xpath = new DOMXPath($dom);
// Check for the historical rel="shortcut icon"
$shortcutIcon = $xpath->query('//link[@rel="shortcut icon"]');
if ($shortcutIcon->length > 0) {
$path = $shortcutIcon->item(0)->getAttribute('href');
return $path;
}
// Check for the HTML5 rel="icon"
$icon = $xpath->query('//link[@rel="icon"]');
if ($icon->length > 0) {
$path = $icon->item(0)->getAttribute('href');
return $path;
}
return null;
}
function checkURLExists($url)
{
$headers = @get_headers($url);
return ($headers && strpos($headers[0], '200') !== false);
}
function extractFaviconUrlWithRegex($html)
{
// Check for the historical rel="shortcut icon"
@ -118,7 +134,6 @@ function getAbsoluteUrl($baseUrl, $relativeUrl)
function getFavIcon($id)
{
try {
$link = Link::find($id);
$page = $link->link;
@ -145,7 +160,6 @@ function getFavIcon($id)
}
return url('assets/favicon/icons/' . $id . '.' . $fileExtension);
} catch (Exception $e) {
// Handle the exception by copying the default SVG favicon
$defaultIcon = base_path('assets/linkstack/icons/website.svg');