From 697ed3ce19988f1903242c8ab5541503b7a296b2 Mon Sep 17 00:00:00 2001 From: snicker Date: Sat, 24 Sep 2022 11:01:09 -0700 Subject: [PATCH] retrieve link url from database rather than request url increases robustness and solve issues with sloppy redirect interpretation across browsers --- app/Http/Controllers/UserController.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php index 8ba6d3f..7da49f4 100755 --- a/app/Http/Controllers/UserController.php +++ b/app/Http/Controllers/UserController.php @@ -183,21 +183,15 @@ class UserController extends Controller public function clickNumber(request $request) { $link = $request->link; - $query = $request->query(); $linkId = $request->id; if(empty($link && $linkId)) { return abort(404); } - - if(!empty($query)) { - $qs = []; - foreach($query as $qk => $qv) { $qs[] = $qk .'='. $qv; } - $link = $link .'?'. implode('&', $qs); - } Link::where('id', $linkId)->increment('click_number', 1); + $link = Link::select('link')->where('id', $linkId)->get()[0]['link']; return redirect()->away($link); }