From c1110d4cedee039789c75f58a587559bcb48c4ea Mon Sep 17 00:00:00 2001 From: JulianPrieber <60265788+JulianPrieber@users.noreply.github.com> Date: Mon, 21 Feb 2022 23:34:07 +0100 Subject: [PATCH] Fixed dark mode for login/register... MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixed the issue of dark mode not displaying on the register, login, forgot password and a few other pages. This one took me a while to fix, and I still don't really know what is going on here. The aforementioned pages already implemented a dark mode, but it didn't seem to work for me. After some testing, I discovered that the dark mode preset doesn't load on chromium based browsers.  I have absolutely no idea why that is, if someone could help me with this that would be amazing. I might make an issue out of this later on. As I still wanted to fix this, I finally achieved my goal by doing the caveman approach: I first added the usual dark mode detection. The same used on the home and little link pages (see previous commits if you're interested). Then I wrote and if statement that loads the newly added app-dark.css (see previous commit) that changes text and background color on the pages in question, if the browser type is chromium and dark mode is selected in the browser settings. "@if(strpos($_SERVER['HTTP_USER_AGENT'], 'Chrome' !== false) and $color_scheme == 'dark')" This doesn't look optimal, and I would rather just have the same dark mode as on Firefox, but this is the best I can currently do with my available time. --- resources/views/layouts/guest.blade.php | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/resources/views/layouts/guest.blade.php b/resources/views/layouts/guest.blade.php index 1d3e854..795bc38 100755 --- a/resources/views/layouts/guest.blade.php +++ b/resources/views/layouts/guest.blade.php @@ -15,6 +15,31 @@ + + + + + + @if(strpos($_SERVER['HTTP_USER_AGENT'], 'Chrome' !== false) and $color_scheme == 'dark') + + @endif +