devol
/
Bitwarden-app-android-iphone-ios
mirror of https://github.com/bitwarden/mobile
1
0
Fork 0
Code Issues 2 Releases Wiki Activity

cryptographically secure RNG for password generator

This commit is contained in:
Kyle Spearrin 2016-10-15 01:18:12 -04:00
parent 8f1a8e3ce9
commit fc1b825f46
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/App/Services/PasswordGenerationService.cs
View File

@ -4,13 +4,13 @@ using System.Linq;
using System.Text;
using Bit.App.Abstractions;
using Plugin.Settings.Abstractions;
using PCLCrypto;
namespace Bit.App.Services
{
public class PasswordGenerationService : IPasswordGenerationService
{
private readonly ISettings _settings;
private Random _random = new Random();
public PasswordGenerationService(ISettings settings)
{
@ -104,7 +104,7 @@ namespace Bit.App.Services
}
// Shuffle
var positions = positionsBuilder.ToString().ToCharArray().OrderBy(a => _random.Next()).ToArray();
var positions = positionsBuilder.ToString().ToCharArray().OrderBy(a => Next(int.MaxValue)).ToArray();
// Build out other character sets
var allCharSet = string.Empty;
@ -168,11 +168,21 @@ namespace Bit.App.Services
break;
}
var randomCharIndex = _random.Next(0, positionChars.Length - 1);
var randomCharIndex = Next(positionChars.Length - 1);
password.Append(positionChars[randomCharIndex]);
}
return password.ToString();
}
private int Next(int maxValue)
{
if(maxValue == 0)
{
return 0;
}
return (int)(WinRTCrypto.CryptographicBuffer.GenerateRandomNumber() % maxValue);
}
}
}