From 9650e4407856ac4d3fb2f5880b24c2b055556b10 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Mon, 29 Apr 2019 13:51:05 -0400
Subject: [PATCH] field logic

---
 src/App/Models/ViewFieldViewModel.cs       | 34 ++++++++++++++++++++-
 src/App/Pages/Vault/ViewPage.xaml          | 35 ++++++++++++++++++++--
 src/App/Pages/Vault/ViewPageViewModel.cs   | 11 +++++++
 src/App/Resources/AppResources.Designer.cs |  9 ++++++
 src/App/Resources/AppResources.resx        |  3 ++
 5 files changed, 88 insertions(+), 4 deletions(-)

diff --git a/src/App/Models/ViewFieldViewModel.cs b/src/App/Models/ViewFieldViewModel.cs
index e3bd62961..8bba95145 100644
--- a/src/App/Models/ViewFieldViewModel.cs
+++ b/src/App/Models/ViewFieldViewModel.cs
@@ -1,15 +1,18 @@
 using Bit.App.Pages;
 using Bit.Core.Models.View;
+using Xamarin.Forms;
 
 namespace Bit.App.Models
 {
     public class ViewFieldViewModel : BaseViewModel
     {
         private FieldView _field;
+        private bool _showHiddenValue;
 
         public ViewFieldViewModel(FieldView field)
         {
             Field = field;
+            ToggleHiddenValueCommand = new Command(ToggleHiddenValue);
         }
 
         public FieldView Field
@@ -18,8 +21,37 @@ namespace Bit.App.Models
             set => SetProperty(ref _field, value,
                 additionalPropertyNames: new string[]
                 {
-
+                    nameof(ValueText),
+                    nameof(IsBooleanType),
+                    nameof(IsHiddenType),
+                    nameof(IsTextType),
+                    nameof(ShowCopyButton),
                 });
         }
+
+        public bool ShowHiddenValue
+        {
+            get => _showHiddenValue;
+            set => SetProperty(ref _showHiddenValue, value,
+                additionalPropertyNames: new string[]
+                {
+                    nameof(ShowHiddenValueIcon)
+                });
+        }
+
+        public Command ToggleHiddenValueCommand { get; set; }
+
+        public string ValueText => IsBooleanType ? (_field.Value == "true" ? "" : "") : _field.Value;
+        public string ShowHiddenValueIcon => _showHiddenValue ? "" : "";
+        public bool IsTextType => _field.Type == Core.Enums.FieldType.Text;
+        public bool IsBooleanType => _field.Type == Core.Enums.FieldType.Boolean;
+        public bool IsHiddenType => _field.Type == Core.Enums.FieldType.Hidden;
+        public bool ShowCopyButton => _field.Type != Core.Enums.FieldType.Boolean && 
+            !string.IsNullOrWhiteSpace(_field.Value);
+
+        public void ToggleHiddenValue()
+        {
+            ShowHiddenValue = !ShowHiddenValue;
+        }
     }
 }
diff --git a/src/App/Pages/Vault/ViewPage.xaml b/src/App/Pages/Vault/ViewPage.xaml
index 21e7818ac..2f955b61b 100644
--- a/src/App/Pages/Vault/ViewPage.xaml
+++ b/src/App/Pages/Vault/ViewPage.xaml
@@ -490,6 +490,7 @@
                                     <Grid.ColumnDefinitions>
                                         <ColumnDefinition Width="*" />
                                         <ColumnDefinition Width="Auto" />
+                                        <ColumnDefinition Width="Auto" />
                                     </Grid.ColumnDefinitions>
                                     <Label
                                         Text="{Binding Field.Name, Mode=OneWay}"
@@ -497,17 +498,45 @@
                                         Grid.Row="0"
                                         Grid.Column="0" />
                                     <Label
-                                        Text="{Binding Field.Value, Mode=OneWay}"
+                                        Text="{Binding ValueText, Mode=OneWay}"
                                         StyleClass="box-value"
                                         Grid.Row="1"
-                                        Grid.Column="0" />
+                                        Grid.Column="0"
+                                        IsVisible="{Binding IsTextType}" />
+                                    <controls:FaLabel
+                                        Text="{Binding ValueText, Mode=OneWay}"
+                                        StyleClass="box-value"
+                                        Grid.Row="1"
+                                        Grid.Column="0"
+                                        IsVisible="{Binding IsBooleanType}" />
+                                    <StackLayout IsVisible="{Binding IsHiddenType}"
+                                                 Grid.Row="1"
+                                                 Grid.Column="0">
+                                        <controls:MonoLabel
+                                            Text="{Binding ValueText, Mode=OneWay}"
+                                            StyleClass="box-value"
+                                            IsVisible="{Binding ShowHiddenValue}" />
+                                        <controls:MonoLabel
+                                            Text="{Binding Field.MaskedValue, Mode=OneWay}"
+                                            StyleClass="box-value"
+                                            IsVisible="{Binding ShowHiddenValue, Converter={StaticResource inverseBool}}" />
+                                    </StackLayout>
+                                    <controls:FaButton 
+                                        StyleClass="box-row-button, box-row-button-platform"
+                                        Text="{Binding ShowHiddenValueIcon}"
+                                        Command="{Binding ToggleHiddenValueCommand}"
+                                        IsVisible="{Binding IsHiddenType}"
+                                        Grid.Row="0"
+                                        Grid.Column="1"
+                                        Grid.RowSpan="2" />
                                     <controls:FaButton
                                         StyleClass="box-row-button, box-row-button-platform"
                                         Text="&#xf0ea;"
                                         Command="{Binding BindingContext.CopyFieldCommand, Source={x:Reference _page}}"
                                         CommandParameter="{Binding Field}"
+                                        IsVisible="{Binding ShowCopyButton}"
                                         Grid.Row="0"
-                                        Grid.Column="1"
+                                        Grid.Column="2"
                                         Grid.RowSpan="2" />
                                 </Grid>
                                 <BoxView StyleClass="box-row-separator" />
diff --git a/src/App/Pages/Vault/ViewPageViewModel.cs b/src/App/Pages/Vault/ViewPageViewModel.cs
index 4ea87688a..fef59dfc7 100644
--- a/src/App/Pages/Vault/ViewPageViewModel.cs
+++ b/src/App/Pages/Vault/ViewPageViewModel.cs
@@ -42,6 +42,7 @@ namespace Bit.App.Pages
             _auditService = ServiceContainer.Resolve<IAuditService>("auditService");
             CopyCommand = new Command<string>((id) => CopyAsync(id, null));
             CopyUriCommand = new Command<LoginUriView>(CopyUri);
+            CopyFieldCommand = new Command<FieldView>(CopyField);
             LaunchUriCommand = new Command<LoginUriView>(LaunchUri);
             TogglePasswordCommand = new Command(TogglePassword);
             ToggleCardCodeCommand = new Command(ToggleCardCode);
@@ -52,6 +53,7 @@ namespace Bit.App.Pages
 
         public Command CopyCommand { get; set; }
         public Command CopyUriCommand { get; set; }
+        public Command CopyFieldCommand { get; set; }
         public Command LaunchUriCommand { get; set; }
         public Command TogglePasswordCommand { get; set; }
         public Command ToggleCardCodeCommand { get; set; }
@@ -265,6 +267,10 @@ namespace Bit.App.Pages
             {
                 name = AppResources.URI;
             }
+            else if(id == "FieldValue")
+            {
+                name = AppResources.Value;
+            }
             else if(id == "CardNumber")
             {
                 text = Cipher.Card.Number;
@@ -291,6 +297,11 @@ namespace Bit.App.Pages
             CopyAsync("LoginUri", uri.Uri);
         }
 
+        private void CopyField(FieldView field)
+        {
+            CopyAsync("FieldValue", field.Value);
+        }
+
         private void LaunchUri(LoginUriView uri)
         {
             if(uri.CanLaunch)
diff --git a/src/App/Resources/AppResources.Designer.cs b/src/App/Resources/AppResources.Designer.cs
index 2d29d9c4a..e8ab87d12 100644
--- a/src/App/Resources/AppResources.Designer.cs
+++ b/src/App/Resources/AppResources.Designer.cs
@@ -3363,6 +3363,15 @@ namespace Bit.App.Resources {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Value.
+        /// </summary>
+        internal static string Value {
+            get {
+                return ResourceManager.GetString("Value", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to {0} has been copied..
         /// </summary>
diff --git a/src/App/Resources/AppResources.resx b/src/App/Resources/AppResources.resx
index bcbefcfcf..2238c900d 100644
--- a/src/App/Resources/AppResources.resx
+++ b/src/App/Resources/AppResources.resx
@@ -1384,4 +1384,7 @@
   <data name="IdentityName" xml:space="preserve">
     <value>Identity Name</value>
   </data>
+  <data name="Value" xml:space="preserve">
+    <value>Value</value>
+  </data>
 </root>
\ No newline at end of file