From 0801dea6e6e92348dfcd175fbd53ab6e8c308739 Mon Sep 17 00:00:00 2001 From: Matt Gibson Date: Mon, 21 Dec 2020 09:58:26 -0600 Subject: [PATCH] Attempt URI healing with https prior to http (#1186) * Attempt URI healing with https prior to http Browsers are moving away from displaying URI scheme in a way accessibility can easily grab. This causes this URI healing to be relied upon more frequently. It should attempt https prior to http due to prevelence of https and security concerns with passwords over http. * Just use https as the URI healing scheme --- src/Android/Accessibility/AccessibilityHelpers.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Android/Accessibility/AccessibilityHelpers.cs b/src/Android/Accessibility/AccessibilityHelpers.cs index 6084d3812..8bdb7bd84 100644 --- a/src/Android/Accessibility/AccessibilityHelpers.cs +++ b/src/Android/Accessibility/AccessibilityHelpers.cs @@ -390,12 +390,12 @@ namespace Bit.Droid.Accessibility var hasHttpProtocol = uri.StartsWith("http://") || uri.StartsWith("https://"); if (!hasHttpProtocol && uri.Contains(".")) { - if (Uri.TryCreate("http://" + uri, UriKind.Absolute, out var uri2)) + if (Uri.TryCreate("https://" + uri, UriKind.Absolute, out var _)) { - return string.Concat("http://", uri); + return string.Concat("https://", uri); } } - if (Uri.TryCreate(uri, UriKind.Absolute, out var uri3)) + if (Uri.TryCreate(uri, UriKind.Absolute, out var _)) { return uri; }