bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
cef/tests/cefclient/browser
History
Marshall Greenblatt d8db6fa9da mac: cefclient: Use RootWindowManager to track key window status (fixes issue #3307) 
This change provides a generic solution for active (key) window tracking that
works with both Views-hosted and native windows on MacOS. With this new approach
we can now successfully route top menu actions to the currently active window.

Prior to this change CEF's Views API was using focus notifications as a proxy
for window activation notifications. That doesn't work on MacOS where NSWindow
activation (key status) is independent of NSView focus (first responder) status,
and changes in activation don't necessarily generate focus notifications (see
NativeWidgetMac::OnWindowKeyStatusChanged). To make this work reliably on all
platforms we now expose a CefWindowDelegate::OnWindowActivationChanged callback.

This change also fixes an uninitialized variable
(RootWindowMacImpl::with_extension_) that was causing flaky behavior in
RootWindowManager::OnRootWindowActivated.

To test:
1. Run `cefclient [--use-views]`
2. Select Popup Window from the Tests menu. Do not explicitly activate the popup
   window (e.g. don't click on it).
3. Verify that further Tests menu actions go to the popup window.
4. Change activation to a first window by clicking on it. Verify that Test
   menu actions go to that window.
5. Close the currently active window. Do not explicitly activate the remaining
   window (e.g. don't click on it).
6. Verify that Test menu actions go to the only remaining window.
 		2022-04-12 16:37:01 -04:00
..
binding_test.cc Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
binding_test.h Add unittests target to the binary distribution (issue #1632) 2016-11-18 03:19:17 -05:00
browser_window.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
browser_window.h Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
browser_window_osr_gtk.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_osr_gtk.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_osr_mac.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_osr_mac.mm chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_osr_win.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_osr_win.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_std_gtk.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_std_gtk.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_std_mac.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_std_mac.mm chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_std_win.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
browser_window_std_win.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
bytes_write_handler.cc cefclient: Convert NULL to nullptr (see issue #2861) 2020-01-15 16:11:53 +01:00
bytes_write_handler.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
client_app_delegates_browser.cc Move cookieable scheme configuration to settings (see issue #2969) 2021-04-09 15:04:24 -04:00
client_browser.cc Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
client_browser.h Improve crashpad integration (issue #1995) 2017-01-10 18:40:31 -05:00
client_handler.cc Add permission callback for user-initated downloads (fixes issue #3183) 2022-03-22 17:46:44 -04:00
client_handler.h Add permission callback for user-initated downloads (fixes issue #3183) 2022-03-22 17:46:44 -04:00
client_handler_osr.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
client_handler_osr.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
client_handler_std.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
client_handler_std.h chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
client_types.h Update to Chromium version 86.0.4240.0 (#800218) 2020-09-03 17:44:25 -04:00
dialog_handler_gtk.cc Update to Chromium version 98.0.4758.0 (#950365) 2021-12-18 15:57:34 -05:00
dialog_handler_gtk.h tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
dialog_test.cc Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
dialog_test.h Add unittests target to the binary distribution (issue #1632) 2016-11-18 03:19:17 -05:00
image_cache.cc Fix compile errors with VS2019 v16.9.3 and GCC v7.5.0 (see issue #3140) 2021-06-23 13:00:34 -04:00
image_cache.h tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
main_context.cc cefclient: Convert NULL to nullptr (see issue #2861) 2020-01-15 16:11:53 +01:00
main_context.h cefclient: Add option to create default popups (see issue #3165, see issue #3294) 2022-04-12 11:49:27 -04:00
main_context_impl.cc cefclient: Add option to create default popups (see issue #3165, see issue #3294) 2022-04-12 11:49:27 -04:00
main_context_impl.h cefclient: Add option to create default popups (see issue #3165, see issue #3294) 2022-04-12 11:49:27 -04:00
main_context_impl_posix.cc cefclient: Convert NULL to nullptr (see issue #2861) 2020-01-15 16:11:53 +01:00
main_context_impl_win.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
main_message_loop_multithreaded_gtk.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
main_message_loop_multithreaded_gtk.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
main_message_loop_multithreaded_win.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
main_message_loop_multithreaded_win.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
media_router_test.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
media_router_test.h Add support for media device discovery and messaging (fixes issue #2900) 2020-03-27 15:54:39 -04:00
osr_accessibility_helper.cc Windows: cefclient: Fix accessibility where TreeId type has changed from int to string 2020-04-02 21:19:25 +00:00
osr_accessibility_helper.h Windows: cefclient: Fix accessibility where TreeId type has changed from int to string 2020-04-02 21:19:25 +00:00
osr_accessibility_node.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
osr_accessibility_node.h Update to Chromium version 86.0.4240.0 (#800218) 2020-09-03 17:44:25 -04:00
osr_accessibility_node_mac.mm macOS: Add support for building clients with ARC enabled (fixes issue #2623). 2019-04-23 17:17:56 +00:00
osr_accessibility_node_win.cc cefclient: Convert NULL to nullptr (see issue #2861) 2020-01-15 16:11:53 +01:00
osr_d3d11_win.cc Windows: cefclient: Fix return value check for AcquireSync (fixes issue #2933) 2020-05-12 15:41:20 -04:00
osr_d3d11_win.h cefclient: Add support for shared texture and external BeginFrame in OSR mode (issue #1006) 2018-09-27 10:32:05 +02:00
osr_dragdrop_events.h Add unittests target to the binary distribution (issue #1632) 2016-11-18 03:19:17 -05:00
osr_dragdrop_win.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
osr_dragdrop_win.h cefclient: Convert NULL to nullptr (see issue #2861) 2020-01-15 16:11:53 +01:00
osr_ime_handler_win.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
osr_ime_handler_win.h Update to Chromium revision 5fdc0fab (#520840) 2017-12-14 15:31:07 -05:00
osr_render_handler_win.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
osr_render_handler_win.h cefclient: Add support for shared texture and external BeginFrame in OSR mode (issue #1006) 2018-09-27 10:32:05 +02:00
osr_render_handler_win_d3d11.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
osr_render_handler_win_d3d11.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
osr_render_handler_win_gl.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
osr_render_handler_win_gl.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
osr_renderer.cc Update to Chromium version 86.0.4240.0 (#800218) 2020-09-03 17:44:25 -04:00
osr_renderer.h Update to Chromium version 74.0.3729.0 (#638880) 2019-03-13 21:27:37 +00:00
osr_renderer_settings.h cefclient: Fix rendering of example background for OSR transparency (see issue #2938) 2020-07-20 15:43:26 -04:00
osr_window_win.cc Delete cef_web_plugin.h and plugin-related APIs (see issue #3047) 2022-02-18 16:23:11 -05:00
osr_window_win.h Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
preferences_test.cc Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
preferences_test.h Add unittests target to the binary distribution (issue #1632) 2016-11-18 03:19:17 -05:00
print_handler_gtk.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
print_handler_gtk.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
resource.h Delete cef_web_plugin.h and plugin-related APIs (see issue #3047) 2022-02-18 16:23:11 -05:00
resource_util_linux.cc Apply clang-format to all C, C++ and ObjC files (issue #2171) 2017-05-18 12:30:05 +02:00
resource_util_win_idmap.cc widevine: Use component updater with the Alloy runtime (fixes issue #3149) 2021-08-09 21:10:45 -04:00
response_filter_test.cc Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
response_filter_test.h Add support for response filtering (issue #515). 2015-12-08 13:47:52 -05:00
root_window.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
root_window.h mac: cefclient: Use RootWindowManager to track key window status (fixes issue #3307) 2022-04-12 16:37:01 -04:00
root_window_create.cc Update to Chromium version 95.0.4638.0 (#920003) 2021-09-22 12:08:24 +03:00
root_window_gtk.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
root_window_gtk.h tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
root_window_mac.h tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
root_window_mac.mm mac: cefclient: Use RootWindowManager to track key window status (fixes issue #3307) 2022-04-12 16:37:01 -04:00
root_window_manager.cc cefclient: Add option to create default popups (see issue #3165, see issue #3294) 2022-04-12 11:49:27 -04:00
root_window_manager.h tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
root_window_views.cc cefclient: Add option to create default popups (see issue #3165, see issue #3294) 2022-04-12 11:49:27 -04:00
root_window_views.h tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
root_window_win.cc chrome: Add ability to handle chrome menu/keyboard commands (fixes issue #3280) 2022-03-22 15:11:47 -04:00
root_window_win.h tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
scheme_test.cc Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
scheme_test.h cefclient: Fix/improve source code documentation (issue #1500). 2015-02-02 23:18:16 +00:00
server_test.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
server_test.h Add CefServer API for handling HTTP/WebSocket requests (issue #2278) 2017-11-15 12:00:36 -05:00
temp_window.h Update to Chromium version 86.0.4240.0 (#800218) 2020-09-03 17:44:25 -04:00
temp_window_mac.h Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
temp_window_mac.mm Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
temp_window_win.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
temp_window_win.h Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
temp_window_x11.cc cefclient: Convert NULL to nullptr (see issue #2861) 2020-01-15 16:11:53 +01:00
temp_window_x11.h Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
test_runner.cc Delete cef_web_plugin.h and plugin-related APIs (see issue #3047) 2022-02-18 16:23:11 -05:00
test_runner.h cefclient: Move StringResourceMap to ClientHandler (see issue #2586) 2019-10-18 15:30:56 +02:00
text_input_client_osr_mac.h Apply clang-format to all C, C++ and ObjC files (issue #2171) 2017-05-18 12:30:05 +02:00
text_input_client_osr_mac.mm Update to Chromium version 93.0.4577.0 (#902210) 2021-07-27 19:03:09 -04:00
urlrequest_test.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
urlrequest_test.h Add unittests target to the binary distribution (issue #1632) 2016-11-18 03:19:17 -05:00
util_gtk.cc Linux: Add multi-threaded message loop support (issue #2512) 2018-09-20 15:17:35 +02:00
util_gtk.h Linux: Add multi-threaded message loop support (issue #2512) 2018-09-20 15:17:35 +02:00
views_menu_bar.cc views: Add support for absolute positioned overlay views. 2021-09-16 18:25:43 +03:00
views_menu_bar.h Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
views_overlay_controls.cc views: cefclient: Add missing <algorithm> include for std::max 2021-09-22 12:08:59 +03:00
views_overlay_controls.h views: Add support for absolute positioned overlay views. 2021-09-16 18:25:43 +03:00
views_style.cc views: Add support for absolute positioned overlay views. 2021-09-16 18:25:43 +03:00
views_style.h views: Add support for absolute positioned overlay views. 2021-09-16 18:25:43 +03:00
views_window.cc mac: cefclient: Use RootWindowManager to track key window status (fixes issue #3307) 2022-04-12 16:37:01 -04:00
views_window.h mac: cefclient: Use RootWindowManager to track key window status (fixes issue #3307) 2022-04-12 16:37:01 -04:00
window_test.cc Various fixes related to the C++11/14 update (see issue #3140) 2021-06-18 13:42:31 -04:00
window_test.h Add unittests target to the binary distribution (issue #1632) 2016-11-18 03:19:17 -05:00
window_test_runner.cc Add unittests target to the binary distribution (issue #1632) 2016-11-18 03:19:17 -05:00
window_test_runner.h Apply clang-format to all C, C++ and ObjC files (issue #2171) 2017-05-18 12:30:05 +02:00
window_test_runner_gtk.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
window_test_runner_gtk.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
window_test_runner_mac.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
window_test_runner_mac.mm macOS: Add support for building clients with ARC enabled (fixes issue #2623). 2019-04-23 17:17:56 +00:00
window_test_runner_views.cc Apply clang-format to all C, C++ and ObjC files (issue #2171) 2017-05-18 12:30:05 +02:00
window_test_runner_views.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00
window_test_runner_win.cc tests: Convert usage of base::Bind to Once or Repeating (see issue #3140) 2021-06-19 17:19:32 -04:00
window_test_runner_win.h Replace OVERRIDE with override (see issue #3140) 2021-06-17 16:16:53 -04:00