cef/tests/cefclient/browser/temp_window_mac.mm
Jesper Papmehl-Dufay 019611c764 macOS: Add support for building clients with ARC enabled (fixes issue #2623).
Under ARC (Automatic Reference Counting), assigning to an Objective-C
pointer has different semantics than assigning to a void* pointer.
This makes it dangerous to treat the same memory address as an
Objective-C pointer in some cases and as a "regular C pointer" in
other cases.

This change removes the conditional type defines and instead uses
void* everywhere. Explicit type casting in combination with ARC
annotations makes it safe to get typed Objective-C pointers from the
void* pointers.

This change enables ARC by default in the CEF binary distribution CMake
configuration for the cefclient and cefsimple sample applications. It can be
disabled by adding `-DOPTION_USE_ARC=Off` to the CMake command line.

ARC is not supported when building Chromium due to the substantial
number of changes that would be required in the Chromium code base.
2019-04-23 17:17:56 +00:00

60 lines
1.4 KiB
Plaintext

// Copyright (c) 2015 The Chromium Embedded Framework Authors. All rights
// reserved. Use of this source code is governed by a BSD-style license that
// can be found in the LICENSE file.
#include "tests/cefclient/browser/temp_window_mac.h"
#include <Cocoa/Cocoa.h>
#include "include/base/cef_logging.h"
#include "include/cef_app.h"
namespace client {
namespace {
TempWindowMac* g_temp_window = NULL;
} // namespace
class TempWindowMacImpl {
public:
TempWindowMacImpl() {
// Create a borderless non-visible 1x1 window.
window_ = [[NSWindow alloc] initWithContentRect:NSMakeRect(0, 0, 1, 1)
styleMask:NSBorderlessWindowMask
backing:NSBackingStoreBuffered
defer:NO];
CHECK(window_);
}
~TempWindowMacImpl() {
DCHECK(window_);
[window_ close];
}
private:
NSWindow* window_;
friend class TempWindowMac;
};
TempWindowMac::TempWindowMac() {
DCHECK(!g_temp_window);
impl_.reset(new TempWindowMacImpl);
g_temp_window = this;
}
TempWindowMac::~TempWindowMac() {
impl_.reset();
g_temp_window = NULL;
}
// static
CefWindowHandle TempWindowMac::GetWindowHandle() {
DCHECK(g_temp_window);
return CAST_NSVIEW_TO_CEF_WINDOW_HANDLE(
g_temp_window->impl_->window_.contentView);
}
} // namespace client