mirror of
https://bitbucket.org/chromiumembedded/cef
synced 2024-12-13 10:06:28 +01:00
381 lines
15 KiB
Diff
381 lines
15 KiB
Diff
diff --git chrome/browser/ui/browser_command_controller.cc chrome/browser/ui/browser_command_controller.cc
|
|
index 8faaa9afc1e6..4dd8937fdc7b 100644
|
|
--- chrome/browser/ui/browser_command_controller.cc
|
|
+++ chrome/browser/ui/browser_command_controller.cc
|
|
@@ -354,8 +354,10 @@ bool BrowserCommandController::ExecuteCommandWithDisposition(
|
|
// CommandUpdaterDelegate and CommandUpdater declare this function so we
|
|
// choose to not implement CommandUpdaterDelegate inside this class and
|
|
// therefore command_updater_ doesn't have the delegate set).
|
|
- if (!SupportsCommand(id) || !IsCommandEnabled(id))
|
|
+ if (!SupportsCommand(id) || !IsCommandEnabled(id)) {
|
|
+ LOG(WARNING) << "Invalid/disabled command " << id;
|
|
return false;
|
|
+ }
|
|
|
|
// No commands are enabled if there is not yet any selected tab.
|
|
// TODO(pkasting): It seems like we should not need this, because either
|
|
@@ -952,11 +954,13 @@ void BrowserCommandController::TabRestoreServiceLoaded(
|
|
// BrowserCommandController, private:
|
|
|
|
bool BrowserCommandController::IsShowingMainUI() {
|
|
- return browser_->SupportsWindowFeature(Browser::FEATURE_TABSTRIP);
|
|
+ return browser_->SupportsWindowFeature(Browser::FEATURE_TABSTRIP) ||
|
|
+ browser_->toolbar_overridden();
|
|
}
|
|
|
|
bool BrowserCommandController::IsShowingLocationBar() {
|
|
- return browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR);
|
|
+ return browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR) ||
|
|
+ browser_->toolbar_overridden();
|
|
}
|
|
|
|
void BrowserCommandController::InitCommandState() {
|
|
diff --git chrome/browser/ui/views/frame/browser_frame.cc chrome/browser/ui/views/frame/browser_frame.cc
|
|
index 7c0229c202ca..67320e907526 100644
|
|
--- chrome/browser/ui/views/frame/browser_frame.cc
|
|
+++ chrome/browser/ui/views/frame/browser_frame.cc
|
|
@@ -64,15 +64,23 @@ bool IsUsingGtkTheme(Profile* profile) {
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// BrowserFrame, public:
|
|
|
|
+BrowserFrame::BrowserFrame() : BrowserFrame(nullptr) {}
|
|
+
|
|
BrowserFrame::BrowserFrame(BrowserView* browser_view)
|
|
: native_browser_frame_(nullptr),
|
|
root_view_(nullptr),
|
|
browser_frame_view_(nullptr),
|
|
- browser_view_(browser_view) {
|
|
- browser_view_->set_frame(this);
|
|
+ browser_view_(nullptr) {
|
|
set_is_secondary_widget(false);
|
|
// Don't focus anything on creation, selecting a tab will set the focus.
|
|
set_focus_on_creation(false);
|
|
+ if (browser_view)
|
|
+ InitBrowserView(browser_view);
|
|
+}
|
|
+
|
|
+void BrowserFrame::InitBrowserView(BrowserView* browser_view) {
|
|
+ browser_view_ = browser_view;
|
|
+ browser_view_->set_frame(this);
|
|
}
|
|
|
|
BrowserFrame::~BrowserFrame() {}
|
|
@@ -131,6 +139,12 @@ gfx::Rect BrowserFrame::GetBoundsForTabStripRegion(
|
|
}
|
|
|
|
int BrowserFrame::GetTopInset() const {
|
|
+ if (!browser_frame_view_) {
|
|
+ // With CEF the browser may already be part of a larger Views layout. Zero
|
|
+ // out the adjustment in BrowserView::GetTopInsetInBrowserView() so that
|
|
+ // the browser isn't shifted to the top of the window.
|
|
+ return browser_view_->y();
|
|
+ }
|
|
return browser_frame_view_->GetTopInset(false);
|
|
}
|
|
|
|
@@ -165,15 +179,21 @@ void BrowserFrame::GetWindowPlacement(gfx::Rect* bounds,
|
|
|
|
content::KeyboardEventProcessingResult BrowserFrame::PreHandleKeyboardEvent(
|
|
const content::NativeWebKeyboardEvent& event) {
|
|
+ if (!native_browser_frame_)
|
|
+ return content::KeyboardEventProcessingResult::NOT_HANDLED;
|
|
return native_browser_frame_->PreHandleKeyboardEvent(event);
|
|
}
|
|
|
|
bool BrowserFrame::HandleKeyboardEvent(
|
|
const content::NativeWebKeyboardEvent& event) {
|
|
+ if (!native_browser_frame_)
|
|
+ return false;
|
|
return native_browser_frame_->HandleKeyboardEvent(event);
|
|
}
|
|
|
|
void BrowserFrame::OnBrowserViewInitViewsComplete() {
|
|
+ if (!browser_frame_view_)
|
|
+ return;
|
|
browser_frame_view_->OnBrowserViewInitViewsComplete();
|
|
}
|
|
|
|
@@ -206,7 +226,8 @@ const ui::ThemeProvider* BrowserFrame::GetThemeProvider() const {
|
|
}
|
|
|
|
const ui::NativeTheme* BrowserFrame::GetNativeTheme() const {
|
|
- if (browser_view_->browser()->profile()->IsIncognitoProfile() &&
|
|
+ if (browser_view_ &&
|
|
+ browser_view_->browser()->profile()->IsIncognitoProfile() &&
|
|
ThemeServiceFactory::GetForProfile(browser_view_->browser()->profile())
|
|
->UsingDefaultTheme()) {
|
|
return ui::NativeTheme::GetInstanceForDarkUI();
|
|
diff --git chrome/browser/ui/views/frame/browser_frame.h chrome/browser/ui/views/frame/browser_frame.h
|
|
index 050c0e05e4e3..0bbcf4af9a92 100644
|
|
--- chrome/browser/ui/views/frame/browser_frame.h
|
|
+++ chrome/browser/ui/views/frame/browser_frame.h
|
|
@@ -53,7 +53,9 @@ enum class TabDragKind {
|
|
// This is a virtual interface that allows system specific browser frames.
|
|
class BrowserFrame : public views::Widget, public views::ContextMenuController {
|
|
public:
|
|
+ BrowserFrame();
|
|
explicit BrowserFrame(BrowserView* browser_view);
|
|
+ void InitBrowserView(BrowserView* browser_view);
|
|
~BrowserFrame() override;
|
|
|
|
// Initialize the frame (creates the underlying native window).
|
|
diff --git chrome/browser/ui/views/frame/browser_view.cc chrome/browser/ui/views/frame/browser_view.cc
|
|
index 7d93faeadd2c..8208964c4a88 100644
|
|
--- chrome/browser/ui/views/frame/browser_view.cc
|
|
+++ chrome/browser/ui/views/frame/browser_view.cc
|
|
@@ -557,11 +557,22 @@ class BrowserView::AccessibilityModeObserver : public ui::AXModeObserver {
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
// BrowserView, public:
|
|
|
|
+BrowserView::BrowserView() : BrowserView(nullptr) {}
|
|
+
|
|
BrowserView::BrowserView(std::unique_ptr<Browser> browser)
|
|
: views::ClientView(nullptr, nullptr),
|
|
- browser_(std::move(browser)),
|
|
accessibility_mode_observer_(
|
|
std::make_unique<AccessibilityModeObserver>(this)) {
|
|
+ if (browser)
|
|
+ InitBrowser(std::move(browser));
|
|
+}
|
|
+
|
|
+void BrowserView::InitBrowser(std::unique_ptr<Browser> browser) {
|
|
+ DCHECK(!browser_);
|
|
+ browser_ = std::move(browser);
|
|
+
|
|
+ immersive_mode_controller_ = chrome::CreateImmersiveModeController();
|
|
+
|
|
SetShowIcon(::ShouldShowWindowIcon(browser_.get()));
|
|
|
|
// In forced app mode, all size controls are always disabled. Otherwise, use
|
|
@@ -575,7 +586,6 @@ BrowserView::BrowserView(std::unique_ptr<Browser> browser)
|
|
}
|
|
|
|
browser_->tab_strip_model()->AddObserver(this);
|
|
- immersive_mode_controller_ = chrome::CreateImmersiveModeController();
|
|
|
|
// Top container holds tab strip region and toolbar and lives at the front of
|
|
// the view hierarchy.
|
|
@@ -619,8 +629,15 @@ BrowserView::BrowserView(std::unique_ptr<Browser> browser)
|
|
contents_container->SetLayoutManager(std::make_unique<ContentsLayoutManager>(
|
|
devtools_web_view_, contents_web_view_));
|
|
|
|
- toolbar_ = top_container_->AddChildView(
|
|
- std::make_unique<ToolbarView>(browser_.get(), this));
|
|
+ toolbar_ = OverrideCreateToolbar(browser_.get(), this);
|
|
+ if (!toolbar_) {
|
|
+ toolbar_ = new ToolbarView(browser_.get(), this, base::nullopt);
|
|
+ } else {
|
|
+ browser_->set_toolbar_overridden(true);
|
|
+ // Update state that depends on the above flag.
|
|
+ browser_->command_controller()->FullscreenStateChanged();
|
|
+ }
|
|
+ top_container_->AddChildView(base::WrapUnique(toolbar_));
|
|
|
|
contents_separator_ =
|
|
top_container_->AddChildView(std::make_unique<ContentsSeparator>());
|
|
@@ -1368,6 +1385,8 @@ bool BrowserView::ShouldHideUIForFullscreen() const {
|
|
if (immersive_mode_controller_->IsEnabled())
|
|
return false;
|
|
|
|
+ if (!frame_->GetFrameView())
|
|
+ return false;
|
|
return frame_->GetFrameView()->ShouldHideTopUIForFullscreen();
|
|
}
|
|
|
|
@@ -2393,7 +2412,8 @@ BrowserView::GetNativeViewHostsForTopControlsSlide() const {
|
|
}
|
|
|
|
void BrowserView::ReparentTopContainerForEndOfImmersive() {
|
|
- overlay_view_->SetVisible(false);
|
|
+ if (overlay_view_)
|
|
+ overlay_view_->SetVisible(false);
|
|
top_container()->DestroyLayer();
|
|
AddChildViewAt(top_container(), 0);
|
|
EnsureFocusOrder();
|
|
@@ -2840,8 +2860,10 @@ void BrowserView::Layout() {
|
|
|
|
// TODO(jamescook): Why was this in the middle of layout code?
|
|
toolbar_->location_bar()->omnibox_view()->SetFocusBehavior(
|
|
- IsToolbarVisible() ? FocusBehavior::ALWAYS : FocusBehavior::NEVER);
|
|
- frame()->GetFrameView()->UpdateMinimumSize();
|
|
+ (IsToolbarVisible() || browser_->toolbar_overridden()) ?
|
|
+ FocusBehavior::ALWAYS : FocusBehavior::NEVER);
|
|
+ if (frame()->GetFrameView())
|
|
+ frame()->GetFrameView()->UpdateMinimumSize();
|
|
|
|
// Some of the situations when the BrowserView is laid out are:
|
|
// - Enter/exit immersive fullscreen mode.
|
|
@@ -2898,6 +2920,11 @@ void BrowserView::AddedToWidget() {
|
|
SetThemeProfileForWindow(GetNativeWindow(), browser_->profile());
|
|
#endif
|
|
|
|
+ // This browser view may already have a custom button provider set (e.g the
|
|
+ // hosted app frame).
|
|
+ if (!toolbar_button_provider_)
|
|
+ SetToolbarButtonProvider(toolbar_);
|
|
+
|
|
toolbar_->Init();
|
|
|
|
#if BUILDFLAG(IS_CHROMEOS_ASH) || BUILDFLAG(IS_CHROMEOS_LACROS)
|
|
@@ -2938,13 +2965,9 @@ void BrowserView::AddedToWidget() {
|
|
|
|
EnsureFocusOrder();
|
|
|
|
- // This browser view may already have a custom button provider set (e.g the
|
|
- // hosted app frame).
|
|
- if (!toolbar_button_provider_)
|
|
- SetToolbarButtonProvider(toolbar_);
|
|
-
|
|
frame_->OnBrowserViewInitViewsComplete();
|
|
- frame_->GetFrameView()->UpdateMinimumSize();
|
|
+ if (frame_->GetFrameView())
|
|
+ frame_->GetFrameView()->UpdateMinimumSize();
|
|
using_native_frame_ = frame_->ShouldUseNativeFrame();
|
|
|
|
MaybeInitializeWebUITabStrip();
|
|
diff --git chrome/browser/ui/views/frame/browser_view.h chrome/browser/ui/views/frame/browser_view.h
|
|
index e4955ccbb929..51a4133ba8d1 100644
|
|
--- chrome/browser/ui/views/frame/browser_view.h
|
|
+++ chrome/browser/ui/views/frame/browser_view.h
|
|
@@ -114,7 +114,9 @@ class BrowserView : public BrowserWindow,
|
|
public webapps::AppBannerManager::Observer {
|
|
public:
|
|
METADATA_HEADER(BrowserView);
|
|
+ BrowserView();
|
|
explicit BrowserView(std::unique_ptr<Browser> browser);
|
|
+ void InitBrowser(std::unique_ptr<Browser> browser);
|
|
BrowserView(const BrowserView&) = delete;
|
|
BrowserView& operator=(const BrowserView&) = delete;
|
|
~BrowserView() override;
|
|
@@ -617,6 +619,12 @@ class BrowserView : public BrowserWindow,
|
|
return accessibility_focus_highlight_.get();
|
|
}
|
|
|
|
+ protected:
|
|
+ virtual ToolbarView* OverrideCreateToolbar(Browser* browser,
|
|
+ BrowserView* browser_view) {
|
|
+ return nullptr;
|
|
+ }
|
|
+
|
|
private:
|
|
// Do not friend BrowserViewLayout. Use the BrowserViewLayoutDelegate
|
|
// interface to keep these two classes decoupled and testable.
|
|
diff --git chrome/browser/ui/views/frame/browser_view_layout.cc chrome/browser/ui/views/frame/browser_view_layout.cc
|
|
index 1f790b4d87da..782d132ccac2 100644
|
|
--- chrome/browser/ui/views/frame/browser_view_layout.cc
|
|
+++ chrome/browser/ui/views/frame/browser_view_layout.cc
|
|
@@ -402,6 +402,12 @@ int BrowserViewLayout::LayoutWebUITabStrip(int top) {
|
|
|
|
int BrowserViewLayout::LayoutToolbar(int top) {
|
|
TRACE_EVENT0("ui", "BrowserViewLayout::LayoutToolbar");
|
|
+ if (toolbar_->parent() && toolbar_->parent()->GetLayoutManager() != this &&
|
|
+ toolbar_->parent()->GetLayoutManager() != nullptr) {
|
|
+ // CEF may take ownership of the toolbar. Early exit to avoid the DCHECK
|
|
+ // in LayoutManager::SetViewVisibility().
|
|
+ return top;
|
|
+ }
|
|
int browser_view_width = vertical_layout_rect_.width();
|
|
bool toolbar_visible = delegate_->IsToolbarVisible();
|
|
int height = toolbar_visible ? toolbar_->GetPreferredSize().height() : 0;
|
|
diff --git chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
|
|
index 975817e079eb..f77c24d294bc 100644
|
|
--- chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
|
|
+++ chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
|
|
@@ -571,37 +571,53 @@ gfx::Range BrowserTabStripController::ListTabsInGroup(
|
|
}
|
|
|
|
bool BrowserTabStripController::IsFrameCondensed() const {
|
|
+ if (!GetFrameView())
|
|
+ return false;
|
|
return GetFrameView()->IsFrameCondensed();
|
|
}
|
|
|
|
bool BrowserTabStripController::HasVisibleBackgroundTabShapes() const {
|
|
+ if (!GetFrameView())
|
|
+ return false;
|
|
return GetFrameView()->HasVisibleBackgroundTabShapes(
|
|
BrowserFrameActiveState::kUseCurrent);
|
|
}
|
|
|
|
bool BrowserTabStripController::EverHasVisibleBackgroundTabShapes() const {
|
|
+ if (!GetFrameView())
|
|
+ return false;
|
|
return GetFrameView()->EverHasVisibleBackgroundTabShapes();
|
|
}
|
|
|
|
bool BrowserTabStripController::ShouldPaintAsActiveFrame() const {
|
|
+ if (!GetFrameView())
|
|
+ return false;
|
|
return GetFrameView()->ShouldPaintAsActive();
|
|
}
|
|
|
|
bool BrowserTabStripController::CanDrawStrokes() const {
|
|
+ if (!GetFrameView())
|
|
+ return false;
|
|
return GetFrameView()->CanDrawStrokes();
|
|
}
|
|
|
|
SkColor BrowserTabStripController::GetFrameColor(
|
|
BrowserFrameActiveState active_state) const {
|
|
+ if (!GetFrameView())
|
|
+ return SK_ColorWHITE;
|
|
return GetFrameView()->GetFrameColor(active_state);
|
|
}
|
|
|
|
SkColor BrowserTabStripController::GetToolbarTopSeparatorColor() const {
|
|
+ if (!GetFrameView())
|
|
+ return SK_ColorWHITE;
|
|
return GetFrameView()->GetToolbarTopSeparatorColor();
|
|
}
|
|
|
|
base::Optional<int> BrowserTabStripController::GetCustomBackgroundId(
|
|
BrowserFrameActiveState active_state) const {
|
|
+ if (!GetFrameView())
|
|
+ return base::nullopt;
|
|
return GetFrameView()->GetCustomBackgroundId(active_state);
|
|
}
|
|
|
|
diff --git chrome/browser/ui/views/toolbar/toolbar_view.cc chrome/browser/ui/views/toolbar/toolbar_view.cc
|
|
index 54ba2047729f..b288d841f7eb 100644
|
|
--- chrome/browser/ui/views/toolbar/toolbar_view.cc
|
|
+++ chrome/browser/ui/views/toolbar/toolbar_view.cc
|
|
@@ -150,12 +150,13 @@ auto& GetViewCommandMap() {
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// ToolbarView, public:
|
|
|
|
-ToolbarView::ToolbarView(Browser* browser, BrowserView* browser_view)
|
|
+ToolbarView::ToolbarView(Browser* browser, BrowserView* browser_view,
|
|
+ base::Optional<DisplayMode> display_mode)
|
|
: AnimationDelegateViews(this),
|
|
browser_(browser),
|
|
browser_view_(browser_view),
|
|
app_menu_icon_controller_(browser->profile(), this),
|
|
- display_mode_(GetDisplayMode(browser)) {
|
|
+ display_mode_(display_mode ? *display_mode : GetDisplayMode(browser)) {
|
|
SetID(VIEW_ID_TOOLBAR);
|
|
|
|
UpgradeDetector::GetInstance()->AddObserver(this);
|
|
@@ -181,7 +182,7 @@ ToolbarView::~ToolbarView() {
|
|
void ToolbarView::Init() {
|
|
auto location_bar = std::make_unique<LocationBarView>(
|
|
browser_, browser_->profile(), browser_->command_controller(), this,
|
|
- display_mode_ != DisplayMode::NORMAL);
|
|
+ display_mode_ != DisplayMode::NORMAL && !browser_->toolbar_overridden());
|
|
// Make sure the toolbar shows by default.
|
|
size_animation_.Reset(1);
|
|
|
|
diff --git chrome/browser/ui/views/toolbar/toolbar_view.h chrome/browser/ui/views/toolbar/toolbar_view.h
|
|
index 0b3492e04542..81e819582cb6 100644
|
|
--- chrome/browser/ui/views/toolbar/toolbar_view.h
|
|
+++ chrome/browser/ui/views/toolbar/toolbar_view.h
|
|
@@ -88,7 +88,8 @@ class ToolbarView : public views::AccessiblePaneView,
|
|
// needs to be displayed.
|
|
};
|
|
|
|
- ToolbarView(Browser* browser, BrowserView* browser_view);
|
|
+ ToolbarView(Browser* browser, BrowserView* browser_view,
|
|
+ base::Optional<DisplayMode> display_mode);
|
|
ToolbarView(const ToolbarView&) = delete;
|
|
ToolbarView& operator=(const ToolbarView&) = delete;
|
|
~ToolbarView() override;
|