bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
cef/patch
History
Marshall Greenblatt 9c82785077 chrome: Fix assertion when clicking the incognito profile button (see issue #2969) 
Profile::IsIncognitoProfile() currently returns false for CEF incognito profiles
because they are not the primary OTR profile. At the same time, we don't
necessarily want IsIncognitoProfile() to return true for CEF profiles because,
among other things, that causes the BrowserView to apply the dark toolbar theme.
Instead, this change updates ProfileMenu expectations to support the CEF
incognito profiles without otherwise modifying the incognito behavior.

Note that the IsIncognitoProfile() implementation has recently changed in
https://crrev.com/7bf6eb2497 and the conclusions in this commit will likely need
to be revisited in an upcoming Chromium update.
 		2021-04-11 16:05:10 -04:00
..
patches chrome: Fix assertion when clicking the incognito profile button (see issue #2969) 2021-04-11 16:05:10 -04:00
README.txt Use git apply for applying patch files (issue #1825) 2017-04-27 13:53:32 -04:00
patch.cfg chrome: Fix assertion when clicking the incognito profile button (see issue #2969) 2021-04-11 16:05:10 -04:00

README.txt 

There may be instances where CEF requires changes to the source code for
Chromium, Blink or third-party projects that are either not desired by those
projects or that have not yet been merged into the source code versions of those
projects used by CEF. To address this situation the CEF project adds a patch
capability as part of cef_create_projects[.bat|sh] build step. This patch
capability works as follows:

1. The CEF developer creates one or more patch files containing all required
   code changes and places those patch files in the "patches" subdirectory.
2. The CEF developer adds an entry for each patch file in the "patch.cfg" file.
3. When building CEF from source code the patch files are applied by the
   patcher.py tool via the cef_create_projects[.bat|sh] build step
4. When updating Chromium the patch_updater.py tool is used to update all patch
   files. See https://bitbucket.org/chromiumembedded/cef/wiki/ChromiumUpdate.md
   for more information about the update process.