mirror of
https://bitbucket.org/chromiumembedded/cef
synced 2024-12-12 09:37:37 +01:00
8f240861e3
Implementation notes: - Chromium change: CookieMonster::SetCookieableSchemes needs to be called immediately after the CookieMonster is created in NetworkContext:: ApplyContextParamsToBuilder. Add a Profile::GetCookieableSchemes method and NetworkContextParams.cookieable_schemes member (set from ProfileNetworkContextService::CreateNetworkContextParams) to support that. - Chromium change: Add a ContentBrowserClient::HandleExternalProtocol variant that exposes additional NetworkService request information. - GetResourceResponseFilter is not yet implemented. API changes: - Resource-related callbacks have been moved from CefRequestHandler to a new CefResourceRequestHandler interface which is returned via the GetResourceRequestHandler method. If the CefRequestHandler declines to handle a resource it can optionally be handled by the CefRequestContextHandler, if any, associated with the loading context. - The OnProtocolExecution callback has been moved from CefRequestHandler to CefResourceRequestHandler and will be called if a custom scheme request is unhandled. - Cookie send/save permission callbacks have been moved from CefRequestHandler and CefResourceHandler to CefResourceRequestHandler. - New methods added to CefResourceHandler that better match NetworkService execution sequence expectations. The old methods are now deprecated. - New methods added to CefRequest and CefResponse. Known behavior changes with the NetworkService implementation: - Modifying the |new_url| parameter in OnResourceRedirect will no longer result in the method being called an additional time (likely a bug in the old implementation). - Modifying the request URL in OnResourceResponse would previously cause a redirect. This behavior is now deprecated because the NetworkService does not support this functionality when using default network loaders. Temporary support has been added in combination with CefResourceHandler usage only. - Other changes to the request object in OnResourceResponse will now cause the request to be restarted. This means that OnBeforeResourceLoad, etc, will be called an additional time with the new request information. - CefResponse::GetMimeType will now be empty for non-200 responses. - Requests using custom schemes can now be handled via CefResourceRequestHandler with the same callback behavior as builtin schemes. - Redirects of custom scheme requests will now be followed as expected. - Default handling of builtin schemes can now be disabled by setting |disable_default_handling| to true in GetResourceRequestHandler. - Unhandled requests (custom scheme or builtin scheme with default handling disabled) will fail with an CefResponse::GetError value of ERR_UNKNOWN_URL_SCHEME. - The CefSchemeHandlerFactory::Create callback will now include cookie headers. To test: - Run `cefclient --enable-network-service`. All resources should load successfully (this tests the transparent proxy capability). - All tests pass with NetworkService disabled. - The following tests pass with NetworkService enabled: - CookieTest.* - FrameTest.* (excluding .*Nav) - NavigationTest.* (excluding .Redirect*) - RequestHandlerTest.* - RequestContextTest.Basic* - RequestContextTest.Popup* - RequestTest.* - ResourceManagerTest.* - ResourceRequestHandlerTest.* (excluding .Filter*) - SchemeHandlerTest.* - StreamResourceHandlerTest.*
185 lines
8.0 KiB
Diff
185 lines
8.0 KiB
Diff
diff --git chrome/browser/extensions/api/streams_private/streams_private_api.cc chrome/browser/extensions/api/streams_private/streams_private_api.cc
|
|
index 9e81f0a33ede..b796e79ae7ef 100644
|
|
--- chrome/browser/extensions/api/streams_private/streams_private_api.cc
|
|
+++ chrome/browser/extensions/api/streams_private/streams_private_api.cc
|
|
@@ -6,6 +6,7 @@
|
|
|
|
#include <utility>
|
|
|
|
+#include "cef/libcef/features/features.h"
|
|
#include "chrome/browser/extensions/extension_tab_util.h"
|
|
#include "chrome/browser/prerender/prerender_contents.h"
|
|
#include "content/public/browser/browser_thread.h"
|
|
@@ -42,6 +43,7 @@ void StreamsPrivateAPI::SendExecuteMimeTypeHandlerEvent(
|
|
if (!web_contents)
|
|
return;
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
// If the request was for a prerender, abort the prerender and do not
|
|
// continue. This is because plugins cancel prerender, see
|
|
// http://crbug.com/343590.
|
|
@@ -51,6 +53,7 @@ void StreamsPrivateAPI::SendExecuteMimeTypeHandlerEvent(
|
|
prerender_contents->Destroy(prerender::FINAL_STATUS_DOWNLOAD);
|
|
return;
|
|
}
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
auto* browser_context = web_contents->GetBrowserContext();
|
|
|
|
diff --git extensions/browser/extension_host.cc extensions/browser/extension_host.cc
|
|
index 8cc9503fc131..b74c385b40a2 100644
|
|
--- extensions/browser/extension_host.cc
|
|
+++ extensions/browser/extension_host.cc
|
|
@@ -67,11 +67,12 @@ ExtensionHost::ExtensionHost(const Extension* extension,
|
|
DCHECK(host_type == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE ||
|
|
host_type == VIEW_TYPE_EXTENSION_DIALOG ||
|
|
host_type == VIEW_TYPE_EXTENSION_POPUP);
|
|
- host_contents_ = WebContents::Create(
|
|
- WebContents::CreateParams(browser_context_, site_instance)),
|
|
- content::WebContentsObserver::Observe(host_contents_.get());
|
|
+ host_contents_owned_ = WebContents::Create(
|
|
+ WebContents::CreateParams(browser_context_, site_instance));
|
|
+ host_contents_ = host_contents_owned_.get();
|
|
+ content::WebContentsObserver::Observe(host_contents_);
|
|
host_contents_->SetDelegate(this);
|
|
- SetViewType(host_contents_.get(), host_type);
|
|
+ SetViewType(host_contents_, host_type);
|
|
|
|
render_view_host_ = host_contents_->GetRenderViewHost();
|
|
|
|
@@ -86,6 +87,48 @@ ExtensionHost::ExtensionHost(const Extension* extension,
|
|
dispatcher()->set_delegate(this);
|
|
}
|
|
|
|
+ExtensionHost::ExtensionHost(ExtensionHostDelegate* delegate,
|
|
+ const Extension* extension,
|
|
+ content::BrowserContext* browser_context,
|
|
+ content::WebContents* host_contents,
|
|
+ const GURL& url,
|
|
+ ViewType host_type)
|
|
+ : delegate_(delegate),
|
|
+ extension_(extension),
|
|
+ extension_id_(extension->id()),
|
|
+ browser_context_(browser_context),
|
|
+ host_contents_(host_contents),
|
|
+ render_view_host_(nullptr),
|
|
+ is_render_view_creation_pending_(false),
|
|
+ has_loaded_once_(false),
|
|
+ document_element_available_(false),
|
|
+ initial_url_(url),
|
|
+ extension_host_type_(host_type) {
|
|
+ DCHECK(delegate);
|
|
+ DCHECK(browser_context);
|
|
+ DCHECK(host_contents);
|
|
+
|
|
+ // Not used for panels, see PanelHost.
|
|
+ DCHECK(host_type == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE ||
|
|
+ host_type == VIEW_TYPE_EXTENSION_DIALOG ||
|
|
+ host_type == VIEW_TYPE_EXTENSION_POPUP);
|
|
+
|
|
+ content::WebContentsObserver::Observe(host_contents_);
|
|
+ SetViewType(host_contents_, host_type);
|
|
+
|
|
+ render_view_host_ = host_contents_->GetRenderViewHost();
|
|
+
|
|
+ // Listen for when an extension is unloaded from the same profile, as it may
|
|
+ // be the same extension that this points to.
|
|
+ ExtensionRegistry::Get(browser_context_)->AddObserver(this);
|
|
+
|
|
+ // Set up web contents observers and pref observers.
|
|
+ delegate_->OnExtensionHostCreated(host_contents_);
|
|
+
|
|
+ ExtensionWebContentsObserver::GetForWebContents(host_contents_)->
|
|
+ dispatcher()->set_delegate(this);
|
|
+}
|
|
+
|
|
ExtensionHost::~ExtensionHost() {
|
|
ExtensionRegistry::Get(browser_context_)->RemoveObserver(this);
|
|
|
|
diff --git extensions/browser/extension_host.h extensions/browser/extension_host.h
|
|
index 4027505469b8..de8258562bb2 100644
|
|
--- extensions/browser/extension_host.h
|
|
+++ extensions/browser/extension_host.h
|
|
@@ -52,13 +52,19 @@ class ExtensionHost : public DeferredStartRenderHost,
|
|
ExtensionHost(const Extension* extension,
|
|
content::SiteInstance* site_instance,
|
|
const GURL& url, ViewType host_type);
|
|
+ ExtensionHost(ExtensionHostDelegate* delegate,
|
|
+ const Extension* extension,
|
|
+ content::BrowserContext* browser_context,
|
|
+ content::WebContents* host_contents,
|
|
+ const GURL& url,
|
|
+ ViewType host_type);
|
|
~ExtensionHost() override;
|
|
|
|
// This may be null if the extension has been or is being unloaded.
|
|
const Extension* extension() const { return extension_; }
|
|
|
|
const std::string& extension_id() const { return extension_id_; }
|
|
- content::WebContents* host_contents() const { return host_contents_.get(); }
|
|
+ content::WebContents* host_contents() const { return host_contents_; }
|
|
content::RenderViewHost* render_view_host() const;
|
|
content::RenderProcessHost* render_process_host() const;
|
|
bool has_loaded_once() const { return has_loaded_once_; }
|
|
@@ -180,7 +186,8 @@ class ExtensionHost : public DeferredStartRenderHost,
|
|
content::BrowserContext* browser_context_;
|
|
|
|
// The host for our HTML content.
|
|
- std::unique_ptr<content::WebContents> host_contents_;
|
|
+ std::unique_ptr<content::WebContents> host_contents_owned_;
|
|
+ content::WebContents* host_contents_;
|
|
|
|
// A weak pointer to the current or pending RenderViewHost. We don't access
|
|
// this through the host_contents because we want to deal with the pending
|
|
diff --git extensions/browser/extensions_browser_client.h extensions/browser/extensions_browser_client.h
|
|
index 93dce1cad08c..1eef00b03063 100644
|
|
--- extensions/browser/extensions_browser_client.h
|
|
+++ extensions/browser/extensions_browser_client.h
|
|
@@ -62,6 +62,7 @@ class ComponentExtensionResourceManager;
|
|
class Extension;
|
|
class ExtensionCache;
|
|
class ExtensionError;
|
|
+class ExtensionHost;
|
|
class ExtensionHostDelegate;
|
|
class ExtensionPrefsObserver;
|
|
class ExtensionApiFrameIdMap;
|
|
@@ -216,6 +217,14 @@ class ExtensionsBrowserClient {
|
|
virtual std::unique_ptr<ExtensionHostDelegate>
|
|
CreateExtensionHostDelegate() = 0;
|
|
|
|
+ // CEF creates a custom ExtensionHost for background pages. If the return
|
|
+ // value is true and |host| is NULL then fail the background host creation.
|
|
+ virtual bool CreateBackgroundExtensionHost(
|
|
+ const Extension* extension,
|
|
+ content::BrowserContext* browser_context,
|
|
+ const GURL& url,
|
|
+ ExtensionHost** host) { return false; }
|
|
+
|
|
// Returns true if the client version has updated since the last run. Called
|
|
// once each time the extensions system is loaded per browser_context. The
|
|
// implementation may wish to use the BrowserContext to record the current
|
|
diff --git extensions/browser/process_manager.cc extensions/browser/process_manager.cc
|
|
index 14fa00f41564..9487425a5627 100644
|
|
--- extensions/browser/process_manager.cc
|
|
+++ extensions/browser/process_manager.cc
|
|
@@ -383,9 +383,16 @@ bool ProcessManager::CreateBackgroundHost(const Extension* extension,
|
|
return true; // TODO(kalman): return false here? It might break things...
|
|
|
|
DVLOG(1) << "CreateBackgroundHost " << extension->id();
|
|
- ExtensionHost* host =
|
|
- new ExtensionHost(extension, GetSiteInstanceForURL(url).get(), url,
|
|
- VIEW_TYPE_EXTENSION_BACKGROUND_PAGE);
|
|
+ ExtensionHost* host = nullptr;
|
|
+ if (ExtensionsBrowserClient::Get()->CreateBackgroundExtensionHost(
|
|
+ extension, browser_context_, url, &host) && !host) {
|
|
+ // Explicitly fail if the client can't create the host.
|
|
+ return false;
|
|
+ }
|
|
+ if (!host) {
|
|
+ host = new ExtensionHost(extension, GetSiteInstanceForURL(url).get(), url,
|
|
+ VIEW_TYPE_EXTENSION_BACKGROUND_PAGE);
|
|
+ }
|
|
host->CreateRenderViewSoon();
|
|
OnBackgroundHostCreated(host);
|
|
return true;
|