77 lines
3.4 KiB
Diff
77 lines
3.4 KiB
Diff
diff --git third_party/WebKit/Source/core/exported/WebViewImpl.cpp third_party/WebKit/Source/core/exported/WebViewImpl.cpp
|
|
index b73e62a0420f..b9b463b87031 100644
|
|
--- third_party/WebKit/Source/core/exported/WebViewImpl.cpp
|
|
+++ third_party/WebKit/Source/core/exported/WebViewImpl.cpp
|
|
@@ -256,8 +256,13 @@ void WebView::SetUseExternalPopupMenus(bool use_external_popup_menus) {
|
|
g_should_use_external_popup_menus = use_external_popup_menus;
|
|
}
|
|
|
|
-bool WebViewImpl::UseExternalPopupMenus() {
|
|
- return g_should_use_external_popup_menus;
|
|
+void WebViewImpl::SetUseExternalPopupMenusThisInstance(
|
|
+ bool use_external_popup_menus) {
|
|
+ should_use_external_popup_menus_ = use_external_popup_menus;
|
|
+}
|
|
+
|
|
+bool WebViewImpl::UseExternalPopupMenus() const {
|
|
+ return should_use_external_popup_menus_;
|
|
}
|
|
|
|
namespace {
|
|
@@ -352,6 +357,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
|
|
enable_fake_page_scale_animation_for_testing_(false),
|
|
fake_page_scale_animation_page_scale_factor_(0),
|
|
fake_page_scale_animation_use_anchor_(false),
|
|
+ should_use_external_popup_menus_(g_should_use_external_popup_menus),
|
|
compositor_device_scale_factor_override_(0),
|
|
suppress_next_keypress_event_(false),
|
|
ime_accept_events_(true),
|
|
diff --git third_party/WebKit/Source/core/exported/WebViewImpl.h third_party/WebKit/Source/core/exported/WebViewImpl.h
|
|
index bfacefa1cf8b..9361917e0a3b 100644
|
|
--- third_party/WebKit/Source/core/exported/WebViewImpl.h
|
|
+++ third_party/WebKit/Source/core/exported/WebViewImpl.h
|
|
@@ -107,7 +107,8 @@ class CORE_EXPORT WebViewImpl final
|
|
static const WebInputEvent* CurrentInputEvent();
|
|
// Returns true if popup menus should be rendered by the browser, false if
|
|
// they should be rendered by WebKit (which is the default).
|
|
- static bool UseExternalPopupMenus();
|
|
+ void SetUseExternalPopupMenusThisInstance(bool);
|
|
+ bool UseExternalPopupMenus() const;
|
|
|
|
// WebWidget methods:
|
|
void Close() override;
|
|
@@ -608,6 +609,8 @@ class CORE_EXPORT WebViewImpl final
|
|
float fake_page_scale_animation_page_scale_factor_;
|
|
bool fake_page_scale_animation_use_anchor_;
|
|
|
|
+ bool should_use_external_popup_menus_;
|
|
+
|
|
float compositor_device_scale_factor_override_;
|
|
TransformationMatrix device_emulation_transform_;
|
|
|
|
diff --git third_party/WebKit/Source/core/page/ChromeClientImpl.cpp third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
|
|
index 129f3f1cb6c7..4dafa0474923 100644
|
|
--- third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
|
|
+++ third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
|
|
@@ -777,7 +777,7 @@ PopupMenu* ChromeClientImpl::OpenPopupMenu(LocalFrame& frame,
|
|
return nullptr;
|
|
|
|
NotifyPopupOpeningObservers();
|
|
- if (WebViewImpl::UseExternalPopupMenus())
|
|
+ if (web_view_->UseExternalPopupMenus())
|
|
return new ExternalPopupMenu(frame, select, *web_view_);
|
|
|
|
DCHECK(RuntimeEnabledFeatures::PagePopupEnabled());
|
|
diff --git third_party/WebKit/public/web/WebView.h third_party/WebKit/public/web/WebView.h
|
|
index ccaade785697..61a406fb4ee1 100644
|
|
--- third_party/WebKit/public/web/WebView.h
|
|
+++ third_party/WebKit/public/web/WebView.h
|
|
@@ -361,6 +361,7 @@ class WebView : protected WebWidget {
|
|
|
|
// Sets whether select popup menus should be rendered by the browser.
|
|
BLINK_EXPORT static void SetUseExternalPopupMenus(bool);
|
|
+ virtual void SetUseExternalPopupMenusThisInstance(bool) = 0;
|
|
|
|
// Hides any popup (suggestions, selects...) that might be showing.
|
|
virtual void HidePopups() = 0;
|