mirror of
				https://bitbucket.org/chromiumembedded/cef
				synced 2025-06-05 21:39:12 +02:00 
			
		
		
		
	
		
			
				
	
	
		
			102 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			102 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| diff --git chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.cc
 | |
| index ecf5f7dd2b2b8..23775b4aa4d90 100644
 | |
| --- chrome/browser/profiles/off_the_record_profile_impl.cc
 | |
| +++ chrome/browser/profiles/off_the_record_profile_impl.cc
 | |
| @@ -653,7 +653,9 @@ std::unique_ptr<Profile> Profile::CreateOffTheRecordProfile(
 | |
|  #endif
 | |
|    if (!profile)
 | |
|      profile = std::make_unique<OffTheRecordProfileImpl>(parent, otr_profile_id);
 | |
| -  profile->Init();
 | |
| +  // With CEF we want to delay initialization.
 | |
| +  if (!otr_profile_id.IsUniqueForCEF())
 | |
| +    profile->Init();
 | |
|    return std::move(profile);
 | |
|  }
 | |
|  
 | |
| diff --git chrome/browser/profiles/profile.cc chrome/browser/profiles/profile.cc
 | |
| index a490fefce8c79..2a066c47ef96d 100644
 | |
| --- chrome/browser/profiles/profile.cc
 | |
| +++ chrome/browser/profiles/profile.cc
 | |
| @@ -84,6 +84,7 @@ base::LazyInstance<std::set<content::BrowserContext*>>::Leaky
 | |
|  
 | |
|  namespace {
 | |
|  
 | |
| +const char kCEFOTRProfileIDPrefix[] = "CEF::BrowserContext";
 | |
|  const char kDevToolsOTRProfileIDPrefix[] = "Devtools::BrowserContext";
 | |
|  const char kMediaRouterOTRProfileIDPrefix[] = "MediaRouter::Presentation";
 | |
|  const char kTestOTRProfileIDPrefix[] = "Test::OTR";
 | |
| @@ -104,6 +105,8 @@ bool Profile::OTRProfileID::AllowsBrowserWindows() const {
 | |
|    // DevTools::BrowserContext, MediaRouter::Presentation, and
 | |
|    // CaptivePortal::Signin are exceptions to this ban.
 | |
|    if (*this == PrimaryID() || IsDevTools() ||
 | |
| +      base::StartsWith(profile_id_, kCEFOTRProfileIDPrefix,
 | |
| +                       base::CompareCase::SENSITIVE) ||
 | |
|        base::StartsWith(profile_id_, kMediaRouterOTRProfileIDPrefix,
 | |
|                         base::CompareCase::SENSITIVE)) {
 | |
|      return true;
 | |
| @@ -144,6 +147,16 @@ Profile::OTRProfileID Profile::OTRProfileID::CreateUnique(
 | |
|        base::Uuid::GenerateRandomV4().AsLowercaseString().c_str()));
 | |
|  }
 | |
|  
 | |
| +// static
 | |
| +Profile::OTRProfileID Profile::OTRProfileID::CreateUniqueForCEF() {
 | |
| +  return CreateUnique(kCEFOTRProfileIDPrefix);
 | |
| +}
 | |
| +
 | |
| +bool Profile::OTRProfileID::IsUniqueForCEF() const {
 | |
| +  return base::StartsWith(profile_id_, kCEFOTRProfileIDPrefix,
 | |
| +                          base::CompareCase::SENSITIVE);
 | |
| +}
 | |
| +
 | |
|  // static
 | |
|  Profile::OTRProfileID Profile::OTRProfileID::CreateUniqueForDevTools() {
 | |
|    return CreateUnique(kDevToolsOTRProfileIDPrefix);
 | |
| diff --git chrome/browser/profiles/profile.h chrome/browser/profiles/profile.h
 | |
| index 2fe342e49d3c1..559b2a676dab5 100644
 | |
| --- chrome/browser/profiles/profile.h
 | |
| +++ chrome/browser/profiles/profile.h
 | |
| @@ -94,6 +94,10 @@ class Profile : public content::BrowserContext {
 | |
|      // be applicable to run. Please see crbug.com/1098697#c3 for more details.
 | |
|      static OTRProfileID CreateUnique(const std::string& profile_id_prefix);
 | |
|  
 | |
| +    // Creates a unique OTR profile id to be used for CEF browser contexts.
 | |
| +    static OTRProfileID CreateUniqueForCEF();
 | |
| +    bool IsUniqueForCEF() const;
 | |
| +
 | |
|      // Creates a unique OTR profile id to be used for DevTools browser contexts.
 | |
|      static OTRProfileID CreateUniqueForDevTools();
 | |
|  
 | |
| @@ -511,6 +515,9 @@ class Profile : public content::BrowserContext {
 | |
|    static Profile* FromJavaObject(const jni_zero::JavaRef<jobject>& obj);
 | |
|    jni_zero::ScopedJavaLocalRef<jobject> GetJavaObject() const;
 | |
|  #endif  // BUILDFLAG(IS_ANDROID)
 | |
| +
 | |
| +  void NotifyOffTheRecordProfileCreated(Profile* off_the_record);
 | |
| +
 | |
|   protected:
 | |
|    // Creates an OffTheRecordProfile which points to this Profile.
 | |
|    static std::unique_ptr<Profile> CreateOffTheRecordProfile(
 | |
| @@ -522,7 +529,6 @@ class Profile : public content::BrowserContext {
 | |
|    static PrefStore* CreateExtensionPrefStore(Profile*,
 | |
|                                               bool incognito_pref_store);
 | |
|  
 | |
| -  void NotifyOffTheRecordProfileCreated(Profile* off_the_record);
 | |
|    void NotifyProfileInitializationComplete();
 | |
|  
 | |
|    // Returns whether the user has signed in this profile to an account.
 | |
| diff --git chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.cc
 | |
| index b91df021f6402..fb37277fa9261 100644
 | |
| --- chrome/browser/profiles/profile_impl.cc
 | |
| +++ chrome/browser/profiles/profile_impl.cc
 | |
| @@ -1022,7 +1022,9 @@ Profile* ProfileImpl::GetOffTheRecordProfile(const OTRProfileID& otr_profile_id,
 | |
|  
 | |
|    otr_profiles_[otr_profile_id] = std::move(otr_profile);
 | |
|  
 | |
| -  NotifyOffTheRecordProfileCreated(raw_otr_profile);
 | |
| +  // With CEF we want to delay initialization.
 | |
| +  if (!otr_profile_id.IsUniqueForCEF())
 | |
| +    NotifyOffTheRecordProfileCreated(raw_otr_profile);
 | |
|  
 | |
|    return raw_otr_profile;
 | |
|  }
 |