diff --git chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc index 3a8e63a3bcbdd..69954e151f04e 100644 --- chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc +++ chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc @@ -23,6 +23,7 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "build/build_config.h" +#include "cef/libcef/features/runtime.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/enterprise/connectors/analysis/analysis_settings.h" #include "chrome/browser/enterprise/connectors/analysis/content_analysis_dialog.h" @@ -357,6 +358,9 @@ bool ContentAnalysisDelegate::IsEnabled(Profile* profile, GURL url, Data* data, AnalysisConnector connector) { + if (cef::IsAlloyRuntimeEnabled()) + return false; + auto* service = ConnectorsServiceFactory::GetForBrowserContext(profile); // If the corresponding Connector policy isn't set, don't perform scans. if (!service || !service->IsConnectorEnabled(connector)) diff --git chrome/browser/first_party_sets/first_party_sets_policy_service.cc chrome/browser/first_party_sets/first_party_sets_policy_service.cc index 0509dabf8f421..35a0046a03c6c 100644 --- chrome/browser/first_party_sets/first_party_sets_policy_service.cc +++ chrome/browser/first_party_sets/first_party_sets_policy_service.cc @@ -275,6 +275,12 @@ void FirstPartySetsPolicyService::OnProfileConfigReady( // Representation of the current profile to be persisted on disk. const std::string browser_context_id = profile->GetBaseName().AsUTF8Unsafe(); + if (browser_context_id.empty()) { + // CEF/Alloy incognito profiles have empty cache path. + OnReadyToNotifyDelegates(std::move(config), + net::FirstPartySetsCacheFilter()); + return; + } base::RepeatingCallback browser_context_getter = base::BindRepeating( diff --git chrome/browser/net/profile_network_context_service.cc chrome/browser/net/profile_network_context_service.cc index e50641649a959..afa518ed24ada 100644 --- chrome/browser/net/profile_network_context_service.cc +++ chrome/browser/net/profile_network_context_service.cc @@ -24,6 +24,7 @@ #include "base/trace_event/trace_event.h" #include "build/build_config.h" #include "build/chromeos_buildflags.h" +#include "cef/libcef/features/runtime.h" #include "chrome/browser/browser_features.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/content_settings/cookie_settings_factory.h" @@ -276,8 +277,10 @@ ProfileNetworkContextService::ProfileNetworkContextService(Profile* profile) base::Unretained(this))); cookie_settings_ = CookieSettingsFactory::GetForProfile(profile); cookie_settings_observation_.Observe(cookie_settings_.get()); - privacy_sandbox_settings_observer_.Observe( - PrivacySandboxSettingsFactory::GetForProfile(profile)); + if (!cef::IsAlloyRuntimeEnabled()) { + privacy_sandbox_settings_observer_.Observe( + PrivacySandboxSettingsFactory::GetForProfile(profile)); + } DisableQuicIfNotAllowed(); @@ -1013,9 +1016,26 @@ void ProfileNetworkContextService::ConfigureNetworkContextParamsInternal( network_context_params->cookie_manager_params = CreateCookieManagerParams(profile_, *cookie_settings_); + if (!in_memory) { + network_context_params->file_paths = + ::network::mojom::NetworkContextFilePaths::New(); + } + // Configure on-disk storage for non-OTR profiles. OTR profiles just use // default behavior (in memory storage, default sizes). - if (!in_memory) { + if (!in_memory && cef::IsAlloyRuntimeEnabled()) { + PrefService* prefs = profile_->GetPrefs(); + // Configure the HTTP cache path and size. + const base::FilePath& base_cache_path = + prefs->GetFilePath(prefs::kDiskCacheDir); + DCHECK(!base_cache_path.empty()); + network_context_params->file_paths->http_cache_directory = + base_cache_path.Append(chrome::kCacheDirname); + network_context_params->http_cache_max_size = + prefs->GetInteger(prefs::kDiskCacheSize); + } + + if (!in_memory && !cef::IsAlloyRuntimeEnabled()) { PrefService* local_state = g_browser_process->local_state(); // Configure the HTTP cache path and size. base::FilePath base_cache_path; @@ -1024,15 +1044,14 @@ void ProfileNetworkContextService::ConfigureNetworkContextParamsInternal( local_state->GetFilePath(prefs::kDiskCacheDir); if (!disk_cache_dir.empty()) base_cache_path = disk_cache_dir.Append(base_cache_path.BaseName()); + network_context_params->file_paths->http_cache_directory = + base_cache_path.Append(chrome::kCacheDirname); const int disk_cache_size = local_state->GetInteger(prefs::kDiskCacheSize); network_context_params->http_cache_max_size = disk_cache_size; network_context_params->shared_dictionary_cache_max_size = disk_cache_size; + } - network_context_params->file_paths = - ::network::mojom::NetworkContextFilePaths::New(); - - network_context_params->file_paths->http_cache_directory = - base_cache_path.Append(chrome::kCacheDirname); + if (!in_memory) { network_context_params->file_paths->data_directory = path.Append(chrome::kNetworkDataDirname); network_context_params->file_paths->unsandboxed_data_path = path; @@ -1207,6 +1226,7 @@ void ProfileNetworkContextService::ConfigureNetworkContextParamsInternal( network_context_params->first_party_sets_access_delegate_params = network::mojom::FirstPartySetsAccessDelegateParams::New(); network_context_params->first_party_sets_access_delegate_params->enabled = + cef::IsAlloyRuntimeEnabled() ? false : PrivacySandboxSettingsFactory::GetForProfile(profile_) ->AreRelatedWebsiteSetsEnabled(); diff --git chrome/browser/net/profile_network_context_service_factory.cc chrome/browser/net/profile_network_context_service_factory.cc index 14ac2ce8b90c5..66431eface762 100644 --- chrome/browser/net/profile_network_context_service_factory.cc +++ chrome/browser/net/profile_network_context_service_factory.cc @@ -6,6 +6,7 @@ #include "build/build_config.h" #include "build/chromeos_buildflags.h" +#include "cef/libcef/features/runtime.h" #include "chrome/browser/first_party_sets/first_party_sets_policy_service_factory.h" #include "chrome/browser/net/profile_network_context_service.h" #include "chrome/browser/privacy_sandbox/privacy_sandbox_settings_factory.h" @@ -53,7 +54,9 @@ ProfileNetworkContextServiceFactory::ProfileNetworkContextServiceFactory() #if BUILDFLAG(IS_CHROMEOS_ASH) DependsOn(chromeos::CertificateProviderServiceFactory::GetInstance()); #endif + if (!cef::IsAlloyRuntimeEnabled()) { DependsOn(PrivacySandboxSettingsFactory::GetInstance()); + } DependsOn( first_party_sets::FirstPartySetsPolicyServiceFactory::GetInstance()); } diff --git chrome/browser/signin/identity_manager_factory.cc chrome/browser/signin/identity_manager_factory.cc index a635c32482ce0..77a3503cea229 100644 --- chrome/browser/signin/identity_manager_factory.cc +++ chrome/browser/signin/identity_manager_factory.cc @@ -11,6 +11,7 @@ #include "base/observer_list.h" #include "build/build_config.h" #include "build/chromeos_buildflags.h" +#include "cef/libcef/features/runtime.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/image_fetcher/image_decoder_impl.h" #include "chrome/browser/profiles/profile.h" @@ -97,6 +98,7 @@ IdentityManagerFactory::~IdentityManagerFactory() { // static signin::IdentityManager* IdentityManagerFactory::GetForProfile( Profile* profile) { + DCHECK(!cef::IsAlloyRuntimeEnabled()); return static_cast( GetInstance()->GetServiceForBrowserContext(profile, true)); } diff --git net/cookies/cookie_monster.cc net/cookies/cookie_monster.cc index df553538286e1..b3fd2845b1147 100644 --- net/cookies/cookie_monster.cc +++ net/cookies/cookie_monster.cc @@ -599,6 +599,25 @@ void CookieMonster::SetCookieableSchemes( MaybeRunCookieCallback(std::move(callback), true); } +void CookieMonster::AddCookieableSchemes( + const std::vector& schemes, + SetCookieableSchemesCallback callback) { + DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); + + // Calls to this method will have no effect if made after a WebView or + // CookieManager instance has been created. + if (initialized_) { + MaybeRunCookieCallback(std::move(callback), false); + return; + } + + if (!schemes.empty()) { + cookieable_schemes_.insert(cookieable_schemes_.begin(), schemes.begin(), + schemes.end()); + } + MaybeRunCookieCallback(std::move(callback), true); +} + // This function must be called before the CookieMonster is used. void CookieMonster::SetPersistSessionCookies(bool persist_session_cookies) { DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); diff --git net/cookies/cookie_monster.h net/cookies/cookie_monster.h index 5e0aaf58d4bfe..f518abde87c8d 100644 --- net/cookies/cookie_monster.h +++ net/cookies/cookie_monster.h @@ -209,6 +209,8 @@ class NET_EXPORT CookieMonster : public CookieStore { CookieChangeDispatcher& GetChangeDispatcher() override; void SetCookieableSchemes(const std::vector& schemes, SetCookieableSchemesCallback callback) override; + void AddCookieableSchemes(const std::vector& schemes, + SetCookieableSchemesCallback callback) override; std::optional SiteHasCookieInOtherPartition( const net::SchemefulSite& site, const std::optional& partition_key) const override; diff --git net/cookies/cookie_store.h net/cookies/cookie_store.h index 3f0be99e0e145..0462ebbe9bedc 100644 --- net/cookies/cookie_store.h +++ net/cookies/cookie_store.h @@ -163,6 +163,11 @@ class NET_EXPORT CookieStore { // Transfer ownership of a CookieAccessDelegate. void SetCookieAccessDelegate(std::unique_ptr delegate); + // Adds to the list of cookieable schemes. Does nothing if called after first + // use of the instance (i.e. after the instance initialization process). + virtual void AddCookieableSchemes(const std::vector& schemes, + SetCookieableSchemesCallback callback) = 0; + // This may be null if no delegate has been set yet, or the delegate has been // reset to null. const CookieAccessDelegate* cookie_access_delegate() const { diff --git services/network/cookie_manager.cc services/network/cookie_manager.cc index d0f230b581c8f..77b3551cc3fb5 100644 --- services/network/cookie_manager.cc +++ services/network/cookie_manager.cc @@ -310,14 +310,9 @@ void CookieManager::AllowFileSchemeCookies( AllowFileSchemeCookiesCallback callback) { OnSettingsWillChange(); - std::vector cookieable_schemes( - net::CookieMonster::kDefaultCookieableSchemes, - net::CookieMonster::kDefaultCookieableSchemes + - net::CookieMonster::kDefaultCookieableSchemesCount); - if (allow) { - cookieable_schemes.push_back(url::kFileScheme); - } - cookie_store_->SetCookieableSchemes(cookieable_schemes, std::move(callback)); + if (!allow) + return; + cookie_store_->AddCookieableSchemes({url::kFileScheme}, std::move(callback)); } void CookieManager::SetForceKeepSessionState() { diff --git services/network/network_context.cc services/network/network_context.cc index 16e8cf435e4b0..8a88f3d841088 100644 --- services/network/network_context.cc +++ services/network/network_context.cc @@ -2406,16 +2406,20 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( network_service_->network_quality_estimator()); } - if (session_cleanup_cookie_store) { - std::unique_ptr cookie_store = - std::make_unique(session_cleanup_cookie_store.get(), - net_log); - if (params_->persist_session_cookies) - cookie_store->SetPersistSessionCookies(true); + std::unique_ptr cookie_store = + std::make_unique(session_cleanup_cookie_store.get(), + net_log); + if (session_cleanup_cookie_store && params_->persist_session_cookies) + cookie_store->SetPersistSessionCookies(true); - builder.SetCookieStore(std::move(cookie_store)); + if (params_->cookieable_schemes.has_value()) { + cookie_store->SetCookieableSchemes( + *params_->cookieable_schemes, + net::CookieStore::SetCookieableSchemesCallback()); } + builder.SetCookieStore(std::move(cookie_store)); + if (base::FeatureList::IsEnabled(features::kPrivateStateTokens) || base::FeatureList::IsEnabled(features::kFledgePst)) { trust_token_store_ = std::make_unique(); diff --git services/network/public/mojom/network_context.mojom services/network/public/mojom/network_context.mojom index c774dfca15ae1..9cb5fe6c5f20c 100644 --- services/network/public/mojom/network_context.mojom +++ services/network/public/mojom/network_context.mojom @@ -359,6 +359,9 @@ struct NetworkContextParams { // cookies. Otherwise it should be false. bool persist_session_cookies = false; + // Schemes that will be passed to CookieMonster::SetCookieableSchemes. + array? cookieable_schemes; + // True if an HTTP cache should be used. bool http_cache_enabled = true; // Maximum size of the HTTP cache. 0 means to use the default size.