diff --git content/app/content_main.cc content/app/content_main.cc index 3062f57603321..d8532c9c2eabb 100644 --- content/app/content_main.cc +++ content/app/content_main.cc @@ -173,11 +173,8 @@ ContentMainParams::~ContentMainParams() = default; ContentMainParams::ContentMainParams(ContentMainParams&&) = default; ContentMainParams& ContentMainParams::operator=(ContentMainParams&&) = default; -// This function must be marked with NO_STACK_PROTECTOR or it may crash on -// return, see the --change-stack-guard-on-fork command line flag. -int NO_STACK_PROTECTOR -RunContentProcess(ContentMainParams params, - ContentMainRunner* content_main_runner) { +int ContentMainInitialize(ContentMainParams params, + ContentMainRunner* content_main_runner) { base::FeatureList::FailOnFeatureAccessWithoutFeatureList(); #if BUILDFLAG(IS_CHROMEOS_LACROS) // Lacros is launched with inherited priority. Revert to normal priority @@ -185,9 +182,6 @@ RunContentProcess(ContentMainParams params, base::PlatformThread::SetCurrentThreadType(base::ThreadType::kDefault); #endif int exit_code = -1; -#if BUILDFLAG(IS_MAC) - std::unique_ptr autorelease_pool; -#endif // A flag to indicate whether Main() has been called before. On Android, we // may re-run Main() without restarting the browser process. This flag @@ -273,12 +267,6 @@ RunContentProcess(ContentMainParams params, #endif #if BUILDFLAG(IS_MAC) - // We need this pool for all the objects created before we get to the event - // loop, but we don't want to leave them hanging around until the app quits. - // Each "main" needs to flush this pool right before it goes into its main - // event loop to get rid of the cruft. - autorelease_pool = std::make_unique(); - params.autorelease_pool = autorelease_pool.get(); InitializeMac(); #endif @@ -323,16 +311,49 @@ RunContentProcess(ContentMainParams params, if (IsSubprocess()) CommonSubprocessInit(); - exit_code = content_main_runner->Run(); -#if BUILDFLAG(IS_MAC) - autorelease_pool.reset(); -#endif + return exit_code; +} +// This function must be marked with NO_STACK_PROTECTOR or it may crash on +// return, see the --change-stack-guard-on-fork command line flag. +int NO_STACK_PROTECTOR +ContentMainRun(ContentMainRunner* content_main_runner) { + return content_main_runner->Run(); +} + +void ContentMainShutdown(ContentMainRunner* content_main_runner) { #if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS) content_main_runner->Shutdown(); #endif +} + +// This function must be marked with NO_STACK_PROTECTOR or it may crash on +// return, see the --change-stack-guard-on-fork command line flag. +int NO_STACK_PROTECTOR +RunContentProcess(ContentMainParams params, + ContentMainRunner* content_main_runner) { +#if BUILDFLAG(IS_MAC) + // We need this pool for all the objects created before we get to the event + // loop, but we don't want to leave them hanging around until the app quits. + // Each "main" needs to flush this pool right before it goes into its main + // event loop to get rid of the cruft. + std::unique_ptr autorelease_pool = + std::make_unique(); + params.autorelease_pool = autorelease_pool.get(); +#endif + + int exit_code = ContentMainInitialize(std::move(params), content_main_runner); + if (exit_code >= 0) + return exit_code; + exit_code = ContentMainRun(content_main_runner); + +#if BUILDFLAG(IS_MAC) + params.autorelease_pool = nullptr; + autorelease_pool.reset(); +#endif + ContentMainShutdown(content_main_runner); return exit_code; } diff --git content/app/content_main_runner_impl.cc content/app/content_main_runner_impl.cc index a6458f11a69e3..16ee357a2ad8e 100644 --- content/app/content_main_runner_impl.cc +++ content/app/content_main_runner_impl.cc @@ -46,6 +46,7 @@ #include "base/task/thread_pool/thread_pool_instance.h" #include "base/threading/hang_watcher.h" #include "base/threading/platform_thread.h" +#include "base/threading/thread_restrictions.h" #include "base/time/time.h" #include "base/trace_event/trace_event.h" #include "build/build_config.h" @@ -1284,6 +1285,12 @@ void ContentMainRunnerImpl::Shutdown() { is_shutdown_ = true; } +void ContentMainRunnerImpl::ShutdownOnUIThread() { + base::ScopedAllowBaseSyncPrimitivesForTesting allow_wait; + unregister_thread_closure_.RunAndReset(); + discardable_shared_memory_manager_.reset(); +} + // static std::unique_ptr ContentMainRunner::Create() { return ContentMainRunnerImpl::Create(); diff --git content/app/content_main_runner_impl.h content/app/content_main_runner_impl.h index 22173f344ae14..fe63790ef128f 100644 --- content/app/content_main_runner_impl.h +++ content/app/content_main_runner_impl.h @@ -27,7 +27,7 @@ class DiscardableSharedMemoryManager; namespace content { class MojoIpcSupport; -class ContentMainRunnerImpl : public ContentMainRunner { +class CONTENT_EXPORT ContentMainRunnerImpl : public ContentMainRunner { public: static std::unique_ptr Create(); @@ -46,6 +46,8 @@ class ContentMainRunnerImpl : public ContentMainRunner { int Run() override; void Shutdown() override; + void ShutdownOnUIThread(); + private: int RunBrowser(MainFunctionParams main_function_params, bool start_minimal_browser); diff --git content/common/set_process_title.cc content/common/set_process_title.cc index 283161145d792..9f3f635abdd1c 100644 --- content/common/set_process_title.cc +++ content/common/set_process_title.cc @@ -54,7 +54,7 @@ void SetProcessTitleFromCommandLine(const char** main_argv) { bool have_argv0 = false; #if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS) - DCHECK_EQ(base::PlatformThread::CurrentId(), getpid()); + // DCHECK_EQ(base::PlatformThread::CurrentId(), getpid()); if (main_argv) setproctitle_init(main_argv); diff --git content/public/app/content_main.h content/public/app/content_main.h index 16e8c657ad61f..62d58b8dcccf5 100644 --- content/public/app/content_main.h +++ content/public/app/content_main.h @@ -93,6 +93,13 @@ struct CONTENT_EXPORT ContentMainParams { } }; +// Split RunContentProcess() into separate stages. +CONTENT_EXPORT int ContentMainInitialize( + ContentMainParams params, + ContentMainRunner* content_main_runner); +CONTENT_EXPORT int ContentMainRun(ContentMainRunner* content_main_runner); +CONTENT_EXPORT void ContentMainShutdown(ContentMainRunner* content_main_runner); + CONTENT_EXPORT int RunContentProcess(ContentMainParams params, ContentMainRunner* content_main_runner);