Compare commits

..

No commits in common. "44f7b57e7945589bfffd68ab848fa303ab78d924" and "69ce47ae4c662288e438dcfd4d6902e28ffd2370" have entirely different histories.

9 changed files with 28 additions and 35 deletions

View File

@ -8,5 +8,5 @@
{ {
'chromium_checkout': 'refs/tags/125.0.6422.26', 'chromium_checkout': 'refs/tags/125.0.6422.26',
'depot_tools_checkout': '19199514e8' 'depot_tools_checkout': '4246ba023a'
} }

View File

@ -69,7 +69,6 @@ class ClientBrowserDelegate : public ClientAppBrowser::Delegate {
const CefString& current_directory) override { const CefString& current_directory) override {
// Add logging for some common switches that the user may attempt to use. // Add logging for some common switches that the user may attempt to use.
static const char* kIgnoredSwitches[] = { static const char* kIgnoredSwitches[] = {
switches::kDisableChromeRuntime,
switches::kEnableChromeRuntime, switches::kEnableChromeRuntime,
switches::kMultiThreadedMessageLoop, switches::kMultiThreadedMessageLoop,
switches::kOffScreenRenderingEnabled, switches::kOffScreenRenderingEnabled,

View File

@ -78,7 +78,7 @@ MainContextImpl::MainContextImpl(CefRefPtr<CefCommandLine> command_line,
// Enable Chrome runtime bootstrap. See issue #2969 for details. // Enable Chrome runtime bootstrap. See issue #2969 for details.
use_chrome_bootstrap_ = use_chrome_bootstrap_ =
!command_line_->HasSwitch(switches::kDisableChromeRuntime); command_line_->HasSwitch(switches::kEnableChromeRuntime);
// Whether the Views framework will be used. // Whether the Views framework will be used.
use_views_ = command_line_->HasSwitch(switches::kUseViews); use_views_ = command_line_->HasSwitch(switches::kUseViews);

View File

@ -58,11 +58,13 @@ int main(int argc, char* argv[]) {
// Specify CEF global settings here. // Specify CEF global settings here.
CefSettings settings; CefSettings settings;
// Use the CEF Chrome bootstrap unless "--disable-chrome-runtime" is specified // Use the CEF Chrome runtime if "--enable-chrome-runtime" is specified via
// via the command-line. Otherwise, use the CEF Alloy bootstrap. The Alloy // the command-line. Otherwise, use the CEF Alloy runtime. For more
// bootstrap is deprecated and will be removed in ~M127. See // information about CEF runtimes see
// https://github.com/chromiumembedded/cef/issues/3685 // https://bitbucket.org/chromiumembedded/cef/wiki/Architecture.md#markdown-header-cef3
settings.chrome_runtime = !command_line->HasSwitch("disable-chrome-runtime"); if (command_line->HasSwitch("enable-chrome-runtime")) {
settings.chrome_runtime = true;
}
// When generating projects with CMake the CEF_USE_SANDBOX value will be defined // When generating projects with CMake the CEF_USE_SANDBOX value will be defined
// automatically. Pass -DUSE_SANDBOX=OFF to the CMake command-line to disable // automatically. Pass -DUSE_SANDBOX=OFF to the CMake command-line to disable

View File

@ -150,12 +150,13 @@ int main(int argc, char* argv[]) {
// Specify CEF global settings here. // Specify CEF global settings here.
CefSettings settings; CefSettings settings;
// Use the CEF Chrome bootstrap unless "--disable-chrome-runtime" is // Use the CEF Chrome runtime if "--enable-chrome-runtime" is specified via
// specified via the command-line. Otherwise, use the CEF Alloy bootstrap. // the command-line. Otherwise, use the CEF Alloy runtime. For more
// The Alloy bootstrap is deprecated and will be removed in ~M127. See // information about CEF runtimes see
// https://github.com/chromiumembedded/cef/issues/3685 // https://bitbucket.org/chromiumembedded/cef/wiki/Architecture.md#markdown-header-cef3
settings.chrome_runtime = if (command_line->HasSwitch("enable-chrome-runtime")) {
!command_line->HasSwitch("disable-chrome-runtime"); settings.chrome_runtime = true;
}
// When generating projects with CMake the CEF_USE_SANDBOX value will be // When generating projects with CMake the CEF_USE_SANDBOX value will be
// defined automatically. Pass -DUSE_SANDBOX=OFF to the CMake command-line // defined automatically. Pass -DUSE_SANDBOX=OFF to the CMake command-line

View File

@ -74,11 +74,13 @@ int APIENTRY wWinMain(HINSTANCE hInstance,
// Specify CEF global settings here. // Specify CEF global settings here.
CefSettings settings; CefSettings settings;
// Use the CEF Chrome bootstrap unless "--disable-chrome-runtime" is specified // Use the CEF Chrome runtime if "--enable-chrome-runtime" is specified via
// via the command-line. Otherwise, use the CEF Alloy bootstrap. The Alloy // the command-line. Otherwise, use the CEF Alloy runtime. For more
// bootstrap is deprecated and will be removed in ~M127. See // information about CEF runtimes see
// https://github.com/chromiumembedded/cef/issues/3685 // https://bitbucket.org/chromiumembedded/cef/wiki/Architecture.md#markdown-header-cef3
settings.chrome_runtime = !command_line->HasSwitch("disable-chrome-runtime"); if (command_line->HasSwitch("enable-chrome-runtime")) {
settings.chrome_runtime = true;
}
#if !defined(CEF_USE_SANDBOX) #if !defined(CEF_USE_SANDBOX)
settings.no_sandbox = true; settings.no_sandbox = true;

View File

@ -113,14 +113,11 @@ void SimpleApp::OnContextInitialized() {
CefRefPtr<CefCommandLine> command_line = CefRefPtr<CefCommandLine> command_line =
CefCommandLine::GetGlobalCommandLine(); CefCommandLine::GetGlobalCommandLine();
const bool enable_chrome_runtime =
!command_line->HasSwitch("disable-chrome-runtime");
// Check if Alloy style will be used. Alloy style is always used with the // Check if Alloy style will be used. Alloy style is always used with the
// Alloy runtime bootstrap and optional with the Chrome runtime bootstrap. // Alloy runtime bootstrap and optional with the Chrome runtime bootstrap.
bool use_alloy_style = true; bool use_alloy_style = true;
cef_runtime_style_t runtime_style = CEF_RUNTIME_STYLE_DEFAULT; cef_runtime_style_t runtime_style = CEF_RUNTIME_STYLE_DEFAULT;
if (enable_chrome_runtime) { if (command_line->HasSwitch("enable-chrome-runtime")) {
use_alloy_style = command_line->HasSwitch("use-alloy-style"); use_alloy_style = command_line->HasSwitch("use-alloy-style");
if (use_alloy_style) { if (use_alloy_style) {
runtime_style = CEF_RUNTIME_STYLE_ALLOY; runtime_style = CEF_RUNTIME_STYLE_ALLOY;
@ -142,16 +139,10 @@ void SimpleApp::OnContextInitialized() {
url = "http://www.google.com"; url = "http://www.google.com";
} }
// Views is enabled by default with the Chrome bootstrap (add `--use-native` // Create the browser using the Views framework if "--use-views" is specified
// to disable). Views is disabled by default with the Alloy bootstrap (add // via the command-line. Otherwise, create the browser using the native
// `--use-views` to enable). // platform framework.
const bool use_views = if (command_line->HasSwitch("use-views")) {
(enable_chrome_runtime && !command_line->HasSwitch("use-native")) ||
(!enable_chrome_runtime && command_line->HasSwitch("use-views"));
// If using Views create the browser using the Views framework, otherwise
// create the browser using the native platform framework.
if (use_views) {
// Create the BrowserView. // Create the BrowserView.
CefRefPtr<CefBrowserView> browser_view = CefBrowserView::CreateBrowserView( CefRefPtr<CefBrowserView> browser_view = CefBrowserView::CreateBrowserView(
handler, url, browser_settings, nullptr, nullptr, handler, url, browser_settings, nullptr, nullptr,

View File

@ -46,7 +46,6 @@ const char kCRLSetsPath[] = "crl-sets-path";
const char kLoadExtension[] = "load-extension"; const char kLoadExtension[] = "load-extension";
const char kNoActivate[] = "no-activate"; const char kNoActivate[] = "no-activate";
const char kEnableChromeRuntime[] = "enable-chrome-runtime"; const char kEnableChromeRuntime[] = "enable-chrome-runtime";
const char kDisableChromeRuntime[] = "disable-chrome-runtime";
const char kShowChromeToolbar[] = "show-chrome-toolbar"; const char kShowChromeToolbar[] = "show-chrome-toolbar";
const char kInitialShowState[] = "initial-show-state"; const char kInitialShowState[] = "initial-show-state";
const char kUseDefaultPopup[] = "use-default-popup"; const char kUseDefaultPopup[] = "use-default-popup";

View File

@ -40,7 +40,6 @@ extern const char kCRLSetsPath[];
extern const char kLoadExtension[]; extern const char kLoadExtension[];
extern const char kNoActivate[]; extern const char kNoActivate[];
extern const char kEnableChromeRuntime[]; extern const char kEnableChromeRuntime[];
extern const char kDisableChromeRuntime[];
extern const char kShowChromeToolbar[]; extern const char kShowChromeToolbar[];
extern const char kInitialShowState[]; extern const char kInitialShowState[];
extern const char kUseDefaultPopup[]; extern const char kUseDefaultPopup[];