Fix issues with request callbacks during browser shutdown (see issue #2622).

The behavior has changed as follows with NetworkService enabled:
- All pending and in-progress requests will now be aborted when the CEF context
  or associated browser is destroyed. The OnResourceLoadComplete callback will
  now also be called in this case for in-progress requests that have a handler.
- The CefResourceHandler::Cancel method will now always be called when resource
  handling is complete, irrespective of whether handling completed successfully.
- Request callbacks that arrive after the OnBeforeClose callback for the
  associated browser (which may happen for in-progress requests that are aborted
  on browser destruction) will now always have a non-nullptr CefBrowser
  parameter.
- Allow empty parameters to CefRequest and CefResponse methods where it makes
  sense (e.g. resetting default response state, or clearing a referrer value).
- Fixed a reference loop that was keeping CefResourceHandler objects from being
  destroyed if they were holding a callback reference (from ProcessRequest,
  ReadResponse, etc.) during CEF context or associated browser destruction.
- Fixed an issue where the main frame was not detached on browser destruction
  which could cause a crash due to RFH use-after-free (see issue #2498).

To test: All unit tests pass as expected.
This commit is contained in:
Marshall Greenblatt
2019-05-31 12:50:12 +03:00
parent fd80e5c653
commit fa5268fa2d
21 changed files with 1458 additions and 369 deletions

View File

@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=fc10026d8f3e77868d19807ea625f9449678da60$
// $hash=65f76c903a9c9f245ffe2b3275472d7d3d464f93$
//
#include "libcef_dll/cpptoc/request_cpptoc.h"
@ -116,10 +116,7 @@ void CEF_CALLBACK request_set_referrer(struct _cef_request_t* self,
DCHECK(self);
if (!self)
return;
// Verify param: referrer_url; type: string_byref_const
DCHECK(referrer_url);
if (!referrer_url)
return;
// Unverified params: referrer_url
// Execute
CefRequestCppToC::Get(self)->SetReferrer(CefString(referrer_url), policy);
@ -265,10 +262,7 @@ void CEF_CALLBACK request_set_header_by_name(struct _cef_request_t* self,
DCHECK(name);
if (!name)
return;
// Verify param: value; type: string_byref_const
DCHECK(value);
if (!value)
return;
// Unverified params: value
// Execute
CefRequestCppToC::Get(self)->SetHeaderByName(
@ -357,10 +351,7 @@ request_set_first_party_for_cookies(struct _cef_request_t* self,
DCHECK(self);
if (!self)
return;
// Verify param: url; type: string_byref_const
DCHECK(url);
if (!url)
return;
// Unverified params: url
// Execute
CefRequestCppToC::Get(self)->SetFirstPartyForCookies(CefString(url));