From f594ca378574b14a40659c9da409f7fff53d774a Mon Sep 17 00:00:00 2001 From: Marshall Greenblatt Date: Wed, 18 Oct 2023 12:30:19 -0400 Subject: [PATCH] ceftests: Fix flaky URLRequestTest due to server response timing In some cases the browser may be closed before the server response is sent. --- tests/ceftests/test_server_runner_normal.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/ceftests/test_server_runner_normal.cc b/tests/ceftests/test_server_runner_normal.cc index a376bcbb6..cfe40c23e 100644 --- a/tests/ceftests/test_server_runner_normal.cc +++ b/tests/ceftests/test_server_runner_normal.cc @@ -124,8 +124,10 @@ class ServerHandler : public CefServerHandler { return; } - // No response should be sent yet. - EXPECT_TRUE(server->IsValidConnection(connection_id)); + if (!server->IsValidConnection(connection_id)) { + // This can occur if the connected browser has already closed. + return; + } const int response_code = response->GetStatus(); if (response_code <= 0) {