bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check the return value of UIT_CreatePopupWindow() in UIT_ShowDevTools() to avoid a crash when canceling the popup window (issue #285). 

git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@274 5089003a-bbd8-11dd-ad1f-f1f9622dbc98
This commit is contained in:
Marshall Greenblatt 2011-08-03 16:59:21 +00:00
parent dadd852cd3
commit f0d1898928
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libcef/browser_impl.cc
View File

@ -1424,9 +1424,11 @@ void CefBrowserImpl::UIT_ShowDevTools()
CefPopupFeatures features; CefPopupFeatures features;
CefRefPtr<CefBrowserImpl> browser = UIT_CreatePopupWindow(url, features); CefRefPtr<CefBrowserImpl> browser = UIT_CreatePopupWindow(url, features);
if (browser.get()) {
browser->UIT_CreateDevToolsClient(dev_tools_agent_.get()); browser->UIT_CreateDevToolsClient(dev_tools_agent_.get());
browser->UIT_LoadURL(browser->GetMainFrame(), url); browser->UIT_LoadURL(browser->GetMainFrame(), url);
browser->UIT_Show(WebKit::WebNavigationPolicyNewWindow); browser->UIT_Show(WebKit::WebNavigationPolicyNewWindow);
}
} else { } else {
// Give focus to the existing inspector window. // Give focus to the existing inspector window.
client->browser()->UIT_Show(WebKit::WebNavigationPolicyNewWindow); client->browser()->UIT_Show(WebKit::WebNavigationPolicyNewWindow);