bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

alloy: Fix OnCertificateError callback for requests redirected to HTTPS (fixes issue #3364)

Browse Source 
This change also adds initial unit test coverage for OnCertificateError (see issue #3148).
This commit is contained in:
Marshall Greenblatt
2022-08-08 18:00:16 -04:00
parent 3b90a084b4
commit ecb29b7fa5
3 changed files with 541 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
libcef/browser/net_service/resource_request_handler_wrapper.cc
View File

@@ -420,12 +420,26 @@ class InterceptedRequestHandlerWrapper : public InterceptedRequestHandler {
if (frame) {
// The request will be associated with this frame/browser if it's valid,
// otherwise the request will be canceled.
content::RenderFrameHost* rfh =
static_cast<CefFrameHostImpl*>(frame.get())->GetRenderFrameHost();
content::RenderFrameHostImpl* rfh =
static_cast<content::RenderFrameHostImpl*>(
static_cast<CefFrameHostImpl*>(frame.get())
->GetRenderFrameHost());
if (rfh) {
url_loader_network_observer =
static_cast<content::RenderFrameHostImpl*>(rfh)
->CreateURLLoaderNetworkObserver();
if (rfh->frame_tree_node() &&
rfh->frame_tree_node()->navigation_request()) {
// Associate the Observer with the current NavigationRequest. This is
// necessary for |is_main_frame_request| to report true (the expected
// value) in AllowCertificateError.
// TODO(cef): This approach for retrieving the NavigationRequest is
// deprecated, see https://crbug.com/1179502#c36.
url_loader_network_observer =
rfh->GetStoragePartition()
->CreateURLLoaderNetworkObserverForNavigationRequest(
*(rfh->frame_tree_node()->navigation_request()));
} else {
// Associate the Observer with the RenderFrameHost.
url_loader_network_observer = rfh->CreateURLLoaderNetworkObserver();
}
}
} else {
auto cef_browser_context = browser_context_getter.Run();