bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Increase URLRequestTest CloseBrowser timeout to reduce flakes (fixes issue #2756) 

Tests for incomplete request behavior use a timeout to trigger CloseBrowser
and terminate the test case. Recent architectural changes in Chromium have
likely increased the minimum delay required to spin up a working browser
instance and initiate the request. Consequently we need to wait longer before
closing the browser.

To test:
Run `ceftests --gtest_filter=URLRequestTest.*Incomplete* --gtest_repeat=5`.
All test runs should succeed.
This commit is contained in:
Marshall Greenblatt 2019-10-04 15:36:06 +03:00
parent 152141d7f4
commit e7b66aa43a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/ceftests/urlrequest_unittest.cc
View File

@ -2836,7 +2836,7 @@ class RequestTestHandler : public TestHandler {
SetSignalCompletionWhenAllBrowsersClose(false); SetSignalCompletionWhenAllBrowsersClose(false);
CefPostDelayedTask( CefPostDelayedTask(
TID_UI, base::Bind(&TestHandler::CloseBrowser, GetBrowser(), false), TID_UI, base::Bind(&TestHandler::CloseBrowser, GetBrowser(), false),
100); 1000);
} }
// Test run is complete. It ran in either the browser or render process. // Test run is complete. It ran in either the browser or render process.