mirror of
https://bitbucket.org/chromiumembedded/cef
synced 2025-06-05 21:39:12 +02:00
chrome: Add support for Alloy style browsers and windows (see #3681)
Split the Alloy runtime into bootstrap and style components. Support creation of Alloy style browsers and windows with the Chrome runtime. Chrome runtime (`--enable-chrome-runtime`) + Alloy style (`--use-alloy-style`) supports Views (`--use-views`), native parent (`--use-native`) and windowless rendering (`--off-screen-rendering-enabled`). Print preview is supported in all cases except with windowless rendering on all platforms and native parent on MacOS. It is disabled by default with Alloy style for legacy compatibility. Where supported it can be enabled or disabled globally using `--[enable|disable]-print-preview` or configured on a per-RequestContext basis using the `printing.print_preview_disabled` preference. It also behaves as expected when triggered via the PDF viewer print button. Chrome runtime + Alloy style behavior differs from Alloy runtime in the following significant ways: - Supports Chrome error pages by default. - DevTools popups are Chrome style only (cannot be windowless). - The Alloy extension API will not supported. Chrome runtime + Alloy style passes all expected Alloy ceftests except the following: - `DisplayTest.AutoResize` (Alloy extension API not supported) - `DownloadTest.*` (Download API not yet supported) - `ExtensionTest.*` (Alloy extension API not supported) This change also adds Chrome runtime support for CefContextMenuHandler::RunContextMenu (see #3293). This change also explicitly blocks (and doesn't retry) FrameAttached requests from PDF viewer and print preview excluded frames (see #3664). Known issues specific to Chrome runtime + Alloy style: - DevTools popup with windowless rendering doesn't load successfully. Use windowed rendering or remote debugging as a workaround. - Chrome style Window with Alloy style BrowserView (`--use-alloy-style --use-chrome-style-window`) does not show Chrome theme changes. To test: - Run `ceftests --enable-chrome-runtime --use-alloy-style [--use-chrome-style-window] [--use-views|--use-native] --gtest_filter=...` - Run `cefclient --enable-chrome-runtime --use-alloy-style [--use-chrome-style-window] [--use-views|--use-native|--off-screen-rendering-enabled]` - Run `cefsimple --enable-chrome-runtime --use-alloy-style [--use-views]`
This commit is contained in:
@@ -15,6 +15,7 @@
|
||||
#include "include/wrapper/cef_closure_task.h"
|
||||
#include "include/wrapper/cef_helpers.h"
|
||||
#include "tests/gtest/include/gtest/gtest.h"
|
||||
#include "tests/shared/common/client_switches.h"
|
||||
#include "tests/shared/common/string_util.h"
|
||||
|
||||
void TestMapEqual(const CefRequest::HeaderMap& map1,
|
||||
@@ -290,17 +291,81 @@ bool TestOldResourceAPI() {
|
||||
return state;
|
||||
}
|
||||
|
||||
bool IsChromeRuntimeEnabled() {
|
||||
bool IsChromeBootstrap() {
|
||||
static bool state = []() {
|
||||
return CefCommandLine::GetGlobalCommandLine()->HasSwitch(
|
||||
"enable-chrome-runtime");
|
||||
client::switches::kEnableChromeRuntime);
|
||||
}();
|
||||
return state;
|
||||
}
|
||||
|
||||
bool UseViewsGlobal() {
|
||||
static bool use_views = []() {
|
||||
return CefCommandLine::GetGlobalCommandLine()->HasSwitch(
|
||||
client::switches::kUseViews);
|
||||
}();
|
||||
return use_views;
|
||||
}
|
||||
|
||||
bool UseAlloyStyleBrowserGlobal() {
|
||||
static bool use_alloy_style = []() {
|
||||
if (!IsChromeBootstrap()) {
|
||||
// Alloy runtime always uses Alloy style.
|
||||
return true;
|
||||
}
|
||||
return CefCommandLine::GetGlobalCommandLine()->HasSwitch(
|
||||
client::switches::kUseAlloyStyle);
|
||||
}();
|
||||
return use_alloy_style;
|
||||
}
|
||||
|
||||
bool UseAlloyStyleWindowGlobal() {
|
||||
static bool use_alloy_style = []() {
|
||||
if (!IsChromeBootstrap()) {
|
||||
// Alloy runtime always uses Alloy style.
|
||||
return true;
|
||||
}
|
||||
auto command_line = CefCommandLine::GetGlobalCommandLine();
|
||||
return command_line->HasSwitch(client::switches::kUseAlloyStyle) &&
|
||||
!command_line->HasSwitch(client::switches::kUseChromeStyleWindow);
|
||||
}();
|
||||
return use_alloy_style;
|
||||
}
|
||||
|
||||
std::string ComputeViewsWindowTitle(CefRefPtr<CefWindow> window,
|
||||
CefRefPtr<CefBrowserView> browser_view) {
|
||||
std::string title = "CefTest - Views - ";
|
||||
if (IsChromeBootstrap()) {
|
||||
std::string window_style =
|
||||
window->GetRuntimeStyle() == CEF_RUNTIME_STYLE_CHROME ? "Chrome"
|
||||
: "Alloy";
|
||||
title += "Chrome - " + window_style + " Window";
|
||||
if (browser_view) {
|
||||
std::string browser_style =
|
||||
browser_view->GetRuntimeStyle() == CEF_RUNTIME_STYLE_CHROME ? "Chrome"
|
||||
: "Alloy";
|
||||
title += " - " + browser_style + " BrowserView";
|
||||
}
|
||||
} else {
|
||||
title += "Alloy";
|
||||
}
|
||||
return title;
|
||||
}
|
||||
|
||||
std::string ComputeNativeWindowTitle(bool use_alloy_style) {
|
||||
std::string title = "CefTest - Native - ";
|
||||
if (IsChromeBootstrap()) {
|
||||
title += "Chrome - ";
|
||||
title += use_alloy_style ? "Alloy Browser" : "Chrome Browser";
|
||||
} else {
|
||||
title += "Alloy";
|
||||
}
|
||||
return title;
|
||||
}
|
||||
|
||||
bool IsBFCacheEnabled() {
|
||||
// Supported by the Chrome runtime only, see issue #3237.
|
||||
if (!IsChromeRuntimeEnabled()) {
|
||||
if (!IsChromeBootstrap()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
@@ -320,8 +385,7 @@ bool IsSameSiteBFCacheEnabled() {
|
||||
}
|
||||
|
||||
bool IgnoreURL(const std::string& url) {
|
||||
return IsChromeRuntimeEnabled() &&
|
||||
url.find("/favicon.ico") != std::string::npos;
|
||||
return IsChromeBootstrap() && url.find("/favicon.ico") != std::string::npos;
|
||||
}
|
||||
|
||||
std::optional<int> GetConfiguredTestTimeout(int timeout_ms) {
|
||||
@@ -337,7 +401,7 @@ std::optional<int> GetConfiguredTestTimeout(int timeout_ms) {
|
||||
return dval;
|
||||
}
|
||||
}
|
||||
return IsChromeRuntimeEnabled() ? 2.0 : 1.0;
|
||||
return IsChromeBootstrap() ? 2.0 : 1.0;
|
||||
}();
|
||||
|
||||
if (!multiplier) {
|
||||
@@ -365,7 +429,7 @@ void SendMouseClickEvent(CefRefPtr<CefBrowser> browser,
|
||||
|
||||
void GrantPopupPermission(CefRefPtr<CefRequestContext> request_context,
|
||||
const std::string& parent_url) {
|
||||
if (IsChromeRuntimeEnabled()) {
|
||||
if (IsChromeBootstrap()) {
|
||||
static bool test_website_setting = []() {
|
||||
return CefCommandLine::GetGlobalCommandLine()->HasSwitch(
|
||||
"test-website-setting");
|
||||
|
Reference in New Issue
Block a user