bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

chrome: Add support for Alloy style browsers and windows (see #3681)

Browse Source 
Split the Alloy runtime into bootstrap and style components. Support
creation of Alloy style browsers and windows with the Chrome runtime.
Chrome runtime (`--enable-chrome-runtime`) + Alloy style
(`--use-alloy-style`) supports Views (`--use-views`), native parent
(`--use-native`) and windowless rendering
(`--off-screen-rendering-enabled`).

Print preview is supported in all cases except with windowless rendering
on all platforms and native parent on MacOS. It is disabled by default
with Alloy style for legacy compatibility. Where supported it can be
enabled or disabled globally using `--[enable|disable]-print-preview` or
configured on a per-RequestContext basis using the
`printing.print_preview_disabled` preference. It also behaves as
expected when triggered via the PDF viewer print button.

Chrome runtime + Alloy style behavior differs from Alloy runtime in the
following significant ways:

- Supports Chrome error pages by default.
- DevTools popups are Chrome style only (cannot be windowless).
- The Alloy extension API will not supported.

Chrome runtime + Alloy style passes all expected Alloy ceftests except
the following:

- `DisplayTest.AutoResize` (Alloy extension API not supported)
- `DownloadTest.*` (Download API not yet supported)
- `ExtensionTest.*` (Alloy extension API not supported)

This change also adds Chrome runtime support for
CefContextMenuHandler::RunContextMenu (see #3293).

This change also explicitly blocks (and doesn't retry) FrameAttached
requests from PDF viewer and print preview excluded frames (see #3664).

Known issues specific to Chrome runtime + Alloy style:
- DevTools popup with windowless rendering doesn't load successfully.
  Use windowed rendering or remote debugging as a workaround.
- Chrome style Window with Alloy style BrowserView (`--use-alloy-style
  --use-chrome-style-window`) does not show Chrome theme changes.

To test:
- Run `ceftests --enable-chrome-runtime --use-alloy-style
       [--use-chrome-style-window] [--use-views|--use-native]
       --gtest_filter=...`
- Run `cefclient --enable-chrome-runtime --use-alloy-style
       [--use-chrome-style-window]
       [--use-views|--use-native|--off-screen-rendering-enabled]`
- Run `cefsimple --enable-chrome-runtime --use-alloy-style [--use-views]`
This commit is contained in:
Marshall Greenblatt
2024-04-17 12:01:26 -04:00
parent 62c93f01f4
commit dca0435d2f
216 changed files with 3388 additions and 1565 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/ceftests/resource_request_handler_unittest.cc
View File

@@ -529,7 +529,7 @@ class BasicResponseTest : public TestHandler {
}
EXPECT_TRUE(frame->IsMain());
if (IsChromeRuntimeEnabled()) {
if (!use_alloy_style_browser()) {
// With the Chrome runtime this is true on initial navigation via
// chrome::AddTabAt() and also true for clicked links.
EXPECT_TRUE(user_gesture);
@@ -615,7 +615,8 @@ class BasicResponseTest : public TestHandler {
CefRefPtr<CefRequest> request,
CefRefPtr<CefCallback> callback) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() && request->GetResourceType() == RT_FAVICON) {
if (!use_alloy_style_browser() &&
request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return RV_CANCEL;
}
@@ -795,7 +796,8 @@ class BasicResponseTest : public TestHandler {
int64_t received_content_length) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() && request->GetResourceType() == RT_FAVICON) {
if (!use_alloy_style_browser() &&
request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return;
}
@@ -1557,7 +1559,7 @@ class SubresourceResponseTest : public RoutingTestHandler {
EXPECT_FALSE(true); // Not reached.
}
if (IsChromeRuntimeEnabled() && IsMainURL(url)) {
if (!use_alloy_style_browser() && IsMainURL(url)) {
// With the Chrome runtime this is true on initial navigation via
// chrome::AddTabAt() and also true for clicked links.
EXPECT_TRUE(user_gesture);
@@ -1680,7 +1682,8 @@ class SubresourceResponseTest : public RoutingTestHandler {
CefRefPtr<CefCallback> callback) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() && request->GetResourceType() == RT_FAVICON) {
if (!use_alloy_style_browser() &&
request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return RV_CANCEL;
}
@@ -1906,7 +1909,8 @@ class SubresourceResponseTest : public RoutingTestHandler {
int64_t received_content_length) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() && request->GetResourceType() == RT_FAVICON) {
if (!use_alloy_style_browser() &&
request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return;
}
@@ -3076,8 +3080,7 @@ class RedirectResponseTest : public TestHandler {
CefRefPtr<CefCallback> callback) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() &&
request->GetResourceType() == RT_FAVICON) {
if (IsChromeBootstrap() && request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return RV_CANCEL;
}
@@ -3185,8 +3188,7 @@ class RedirectResponseTest : public TestHandler {
int64_t received_content_length) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() &&
request->GetResourceType() == RT_FAVICON) {
if (IsChromeBootstrap() && request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return;
}
@@ -3308,7 +3310,8 @@ class BeforeResourceLoadTest : public TestHandler {
CefRefPtr<CefCallback> callback) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() && request->GetResourceType() == RT_FAVICON) {
if (!use_alloy_style_browser() &&
request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return RV_CANCEL;
}
@@ -3879,7 +3882,8 @@ class ResponseFilterTestHandler : public TestHandler {
int64_t received_content_length) override {
EXPECT_IO_THREAD();
if (IsChromeRuntimeEnabled() && request->GetResourceType() == RT_FAVICON) {
if (!use_alloy_style_browser() &&
request->GetResourceType() == RT_FAVICON) {
// Ignore favicon requests.
return;
}