mirror of
https://bitbucket.org/chromiumembedded/cef
synced 2025-06-05 21:39:12 +02:00
chrome: Add support for Alloy style browsers and windows (see #3681)
Split the Alloy runtime into bootstrap and style components. Support creation of Alloy style browsers and windows with the Chrome runtime. Chrome runtime (`--enable-chrome-runtime`) + Alloy style (`--use-alloy-style`) supports Views (`--use-views`), native parent (`--use-native`) and windowless rendering (`--off-screen-rendering-enabled`). Print preview is supported in all cases except with windowless rendering on all platforms and native parent on MacOS. It is disabled by default with Alloy style for legacy compatibility. Where supported it can be enabled or disabled globally using `--[enable|disable]-print-preview` or configured on a per-RequestContext basis using the `printing.print_preview_disabled` preference. It also behaves as expected when triggered via the PDF viewer print button. Chrome runtime + Alloy style behavior differs from Alloy runtime in the following significant ways: - Supports Chrome error pages by default. - DevTools popups are Chrome style only (cannot be windowless). - The Alloy extension API will not supported. Chrome runtime + Alloy style passes all expected Alloy ceftests except the following: - `DisplayTest.AutoResize` (Alloy extension API not supported) - `DownloadTest.*` (Download API not yet supported) - `ExtensionTest.*` (Alloy extension API not supported) This change also adds Chrome runtime support for CefContextMenuHandler::RunContextMenu (see #3293). This change also explicitly blocks (and doesn't retry) FrameAttached requests from PDF viewer and print preview excluded frames (see #3664). Known issues specific to Chrome runtime + Alloy style: - DevTools popup with windowless rendering doesn't load successfully. Use windowed rendering or remote debugging as a workaround. - Chrome style Window with Alloy style BrowserView (`--use-alloy-style --use-chrome-style-window`) does not show Chrome theme changes. To test: - Run `ceftests --enable-chrome-runtime --use-alloy-style [--use-chrome-style-window] [--use-views|--use-native] --gtest_filter=...` - Run `cefclient --enable-chrome-runtime --use-alloy-style [--use-chrome-style-window] [--use-views|--use-native|--off-screen-rendering-enabled]` - Run `cefsimple --enable-chrome-runtime --use-alloy-style [--use-views]`
This commit is contained in:
@@ -46,6 +46,10 @@ class ViewsWindow : public CefBrowserViewDelegate,
|
||||
// Delegate methods will be called on the browser process UI thread.
|
||||
class Delegate {
|
||||
public:
|
||||
// Returns true if the window should use Alloy style, otherwise Chrome
|
||||
// style.
|
||||
virtual bool UseAlloyStyle() const = 0;
|
||||
|
||||
// Return true if the window should show controls.
|
||||
virtual bool WithControls() = 0;
|
||||
|
||||
@@ -147,6 +151,7 @@ class ViewsWindow : public CefBrowserViewDelegate,
|
||||
CefRefPtr<CefBrowserView> browser_view) override;
|
||||
bool UseFramelessWindowForPictureInPicture(
|
||||
CefRefPtr<CefBrowserView> browser_view) override;
|
||||
cef_runtime_style_t GetBrowserRuntimeStyle() override;
|
||||
|
||||
// CefButtonDelegate methods:
|
||||
void OnButtonPressed(CefRefPtr<CefButton> button) override;
|
||||
@@ -196,6 +201,7 @@ class ViewsWindow : public CefBrowserViewDelegate,
|
||||
bool is_completed) override;
|
||||
void OnThemeColorsChanged(CefRefPtr<CefWindow> window,
|
||||
bool chrome_theme) override;
|
||||
cef_runtime_style_t GetWindowRuntimeStyle() override;
|
||||
|
||||
// CefViewDelegate methods:
|
||||
CefSize GetPreferredSize(CefRefPtr<CefView> view) override;
|
||||
@@ -259,6 +265,8 @@ class ViewsWindow : public CefBrowserViewDelegate,
|
||||
|
||||
const WindowType type_;
|
||||
Delegate* delegate_; // Not owned by this object.
|
||||
const bool use_alloy_style_;
|
||||
bool use_alloy_style_window_;
|
||||
CefRefPtr<CefBrowserView> browser_view_;
|
||||
CefRefPtr<CefCommandLine> command_line_;
|
||||
bool frameless_;
|
||||
|
Reference in New Issue
Block a user