chrome: Add support for Alloy style browsers and windows (see #3681)

Split the Alloy runtime into bootstrap and style components. Support
creation of Alloy style browsers and windows with the Chrome runtime.
Chrome runtime (`--enable-chrome-runtime`) + Alloy style
(`--use-alloy-style`) supports Views (`--use-views`), native parent
(`--use-native`) and windowless rendering
(`--off-screen-rendering-enabled`).

Print preview is supported in all cases except with windowless rendering
on all platforms and native parent on MacOS. It is disabled by default
with Alloy style for legacy compatibility. Where supported it can be
enabled or disabled globally using `--[enable|disable]-print-preview` or
configured on a per-RequestContext basis using the
`printing.print_preview_disabled` preference. It also behaves as
expected when triggered via the PDF viewer print button.

Chrome runtime + Alloy style behavior differs from Alloy runtime in the
following significant ways:

- Supports Chrome error pages by default.
- DevTools popups are Chrome style only (cannot be windowless).
- The Alloy extension API will not supported.

Chrome runtime + Alloy style passes all expected Alloy ceftests except
the following:

- `DisplayTest.AutoResize` (Alloy extension API not supported)
- `DownloadTest.*` (Download API not yet supported)
- `ExtensionTest.*` (Alloy extension API not supported)

This change also adds Chrome runtime support for
CefContextMenuHandler::RunContextMenu (see #3293).

This change also explicitly blocks (and doesn't retry) FrameAttached
requests from PDF viewer and print preview excluded frames (see #3664).

Known issues specific to Chrome runtime + Alloy style:
- DevTools popup with windowless rendering doesn't load successfully.
  Use windowed rendering or remote debugging as a workaround.
- Chrome style Window with Alloy style BrowserView (`--use-alloy-style
  --use-chrome-style-window`) does not show Chrome theme changes.

To test:
- Run `ceftests --enable-chrome-runtime --use-alloy-style
       [--use-chrome-style-window] [--use-views|--use-native]
       --gtest_filter=...`
- Run `cefclient --enable-chrome-runtime --use-alloy-style
       [--use-chrome-style-window]
       [--use-views|--use-native|--off-screen-rendering-enabled]`
- Run `cefsimple --enable-chrome-runtime --use-alloy-style [--use-views]`

libcef/browser/chrome/views/browser_platform_delegate_chrome_child_window.cc

@@ -18,6 +18,11 @@ void CefBrowserPlatformDelegateChromeChildWindow::CloseHostWindow() {
   native_delegate_->CloseHostWindow();
 }
 
+CefRefPtr<CefBrowserViewDelegate> CefBrowserPlatformDelegateChromeChildWindow::
+    GetDefaultBrowserViewDelegateForPopupOpener() {
+  return chrome_child_window::GetDefaultBrowserViewDelegateForPopupOpener();
+}
+
 void CefBrowserPlatformDelegateChromeChildWindow::SetFocus(bool focus) {
   native_delegate_->SetFocus(focus);
 }

libcef/browser/chrome/views/browser_platform_delegate_chrome_child_window.h

@@ -17,6 +17,8 @@ class CefBrowserPlatformDelegateChromeChildWindow
 
   // CefBrowserPlatformDelegate overrides.
   void CloseHostWindow() override;
+  CefRefPtr<CefBrowserViewDelegate>
+  GetDefaultBrowserViewDelegateForPopupOpener() override;
   void SetFocus(bool focus) override;
 
 #if BUILDFLAG(IS_WIN) || (BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_MAC))

libcef/browser/chrome/views/browser_platform_delegate_chrome_views.cc

@@ -12,43 +12,6 @@
 #include "components/zoom/zoom_controller.h"
 #include "ui/views/widget/widget.h"
 
-namespace {
-
-// Default popup window delegate implementation.
-class PopupWindowDelegate : public CefWindowDelegate {
- public:
-  explicit PopupWindowDelegate(CefRefPtr<CefBrowserView> browser_view)
-      : browser_view_(browser_view) {}
-
-  PopupWindowDelegate(const PopupWindowDelegate&) = delete;
-  PopupWindowDelegate& operator=(const PopupWindowDelegate&) = delete;
-
-  void OnWindowCreated(CefRefPtr<CefWindow> window) override {
-    window->AddChildView(browser_view_);
-    window->Show();
-    browser_view_->RequestFocus();
-  }
-
-  void OnWindowDestroyed(CefRefPtr<CefWindow> window) override {
-    browser_view_ = nullptr;
-  }
-
-  bool CanClose(CefRefPtr<CefWindow> window) override {
-    CefRefPtr<CefBrowser> browser = browser_view_->GetBrowser();
-    if (browser) {
-      return browser->GetHost()->TryCloseBrowser();
-    }
-    return true;
-  }
-
- private:
-  CefRefPtr<CefBrowserView> browser_view_;
-
-  IMPLEMENT_REFCOUNTING(PopupWindowDelegate);
-};
-
-}  // namespace
-
 CefBrowserPlatformDelegateChromeViews::CefBrowserPlatformDelegateChromeViews(
     std::unique_ptr<CefBrowserPlatformDelegateNative> native_delegate,
     CefRefPtr<CefBrowserViewImpl> browser_view)
@@ -59,10 +22,10 @@ CefBrowserPlatformDelegateChromeViews::CefBrowserPlatformDelegateChromeViews(
 }
 
 void CefBrowserPlatformDelegateChromeViews::SetBrowserView(
-    CefRefPtr<CefBrowserViewImpl> browser_view) {
+    CefRefPtr<CefBrowserView> browser_view) {
   DCHECK(!browser_view_);
   DCHECK(browser_view);
-  browser_view_ = browser_view;
+  browser_view_ = static_cast<CefBrowserViewImpl*>(browser_view.get());
 }
 
 void CefBrowserPlatformDelegateChromeViews::WebContentsCreated(
@@ -148,59 +111,6 @@ CefBrowserPlatformDelegateChromeViews::GetBrowserView() const {
   return browser_view_.get();
 }
 
-void CefBrowserPlatformDelegateChromeViews::PopupWebContentsCreated(
-    const CefBrowserSettings& settings,
-    CefRefPtr<CefClient> client,
-    content::WebContents* new_web_contents,
-    CefBrowserPlatformDelegate* new_platform_delegate,
-    bool is_devtools) {
-  // Default popup handling may not be Views-hosted.
-  if (!new_platform_delegate->IsViewsHosted()) {
-    return;
-  }
-
-  auto* new_platform_delegate_impl =
-      static_cast<CefBrowserPlatformDelegateChromeViews*>(
-          new_platform_delegate);
-
-  CefRefPtr<CefBrowserViewDelegate> new_delegate;
-  if (browser_view_->delegate()) {
-    new_delegate = browser_view_->delegate()->GetDelegateForPopupBrowserView(
-        browser_view_.get(), settings, client, is_devtools);
-  }
-
-  // Create a new BrowserView for the popup.
-  CefRefPtr<CefBrowserViewImpl> new_browser_view =
-      CefBrowserViewImpl::CreateForPopup(settings, new_delegate);
-
-  // Associate the PlatformDelegate with the new BrowserView.
-  new_platform_delegate_impl->SetBrowserView(new_browser_view);
-}
-
-void CefBrowserPlatformDelegateChromeViews::PopupBrowserCreated(
-    CefBrowserHostBase* new_browser,
-    bool is_devtools) {
-  // Default popup handling may not be Views-hosted.
-  if (!new_browser->HasView()) {
-    return;
-  }
-
-  CefRefPtr<CefBrowserView> new_browser_view =
-      CefBrowserView::GetForBrowser(new_browser);
-  DCHECK(new_browser_view);
-
-  bool popup_handled = false;
-  if (browser_view_->delegate()) {
-    popup_handled = browser_view_->delegate()->OnPopupBrowserViewCreated(
-        browser_view_.get(), new_browser_view.get(), is_devtools);
-  }
-
-  if (!popup_handled) {
-    CefWindow::CreateTopLevelWindow(
-        new PopupWindowDelegate(new_browser_view.get()));
-  }
-}
-
 bool CefBrowserPlatformDelegateChromeViews::IsViewsHosted() const {
   return true;
 }

libcef/browser/chrome/views/browser_platform_delegate_chrome_views.h

@@ -30,21 +30,12 @@ class CefBrowserPlatformDelegateChromeViews
   CefWindowHandle GetHostWindowHandle() const override;
   views::Widget* GetWindowWidget() const override;
   CefRefPtr<CefBrowserView> GetBrowserView() const override;
-  void PopupWebContentsCreated(
-      const CefBrowserSettings& settings,
-      CefRefPtr<CefClient> client,
-      content::WebContents* new_web_contents,
-      CefBrowserPlatformDelegate* new_platform_delegate,
-      bool is_devtools) override;
-  void PopupBrowserCreated(CefBrowserHostBase* new_browser,
-                           bool is_devtools) override;
+  void SetBrowserView(CefRefPtr<CefBrowserView> browser_view) override;
   bool IsViewsHosted() const override;
 
   CefRefPtr<CefBrowserViewImpl> browser_view() const { return browser_view_; }
 
  private:
-  void SetBrowserView(CefRefPtr<CefBrowserViewImpl> browser_view);
-
   CefWindowImpl* GetWindowImpl() const;
 
   CefRefPtr<CefBrowserViewImpl> browser_view_;

libcef/browser/chrome/views/chrome_browser_frame.h

@@ -107,6 +107,7 @@ class ChromeBrowserFrame : public BrowserFrame,
   void Init(BrowserView* browser_view, std::unique_ptr<Browser> browser);
 
   // CefWidget methods:
+  bool IsAlloyStyle() const override { return false; }
   views::Widget* GetWidget() override { return this; }
   const views::Widget* GetWidget() const override { return this; }
   void Initialized() override;

libcef/browser/chrome/views/chrome_browser_view.cc

@@ -54,9 +54,6 @@ void ChromeBrowserView::ViewHierarchyChanged(
 void ChromeBrowserView::AddedToWidget() {
   // Create the Browser and ChromeBrowserHostImpl.
   // Results in a call to InitBrowser which calls ParentClass::AddedToWidget.
-  cef_browser_view_->OnBrowserViewAdded();
-
-  // Call after ChromeBrowserHostImpl creation.
   cef_browser_view_->AddedToWidget();
 }
 

libcef/browser/chrome/views/chrome_child_window.cc

@@ -8,6 +8,8 @@
 #include "libcef/browser/views/browser_view_impl.h"
 #include "libcef/browser/views/window_impl.h"
 
+#include "ui/gfx/native_widget_types.h"
+
 #if BUILDFLAG(IS_WIN)
 #include "libcef/browser/native/browser_platform_delegate_native_win.h"
 #include "ui/views/win/hwnd_util.h"
@@ -15,6 +17,23 @@
 
 namespace {
 
+gfx::AcceleratedWidget GetParentWidget(const CefWindowInfo& window_info) {
+#if !BUILDFLAG(IS_MAC)
+  return window_info.parent_window;
+#else
+  // Chrome style is not supported with native parent on MacOS. See issue #3294.
+  return gfx::kNullAcceleratedWidget;
+#endif
+}
+
+CefWindowHandle GetParentHandle(const CefWindowInfo& window_info) {
+#if !BUILDFLAG(IS_MAC)
+  return window_info.parent_window;
+#else
+  return window_info.parent_view;
+#endif
+}
+
 class ChildWindowDelegate : public CefWindowDelegate {
  public:
   ChildWindowDelegate(const ChildWindowDelegate&) = delete;
@@ -61,8 +80,7 @@ class ChildWindowDelegate : public CefWindowDelegate {
     DCHECK(widget_hwnd);
 
     // The native delegate needs state to perform some actions.
-    auto browser =
-        static_cast<CefBrowserHostBase*>(browser_view_->GetBrowser().get());
+    auto browser = CefBrowserHostBase::FromBrowser(browser_view_->GetBrowser());
     auto platform_delegate = browser->platform_delegate();
     DCHECK(platform_delegate->IsViewsHosted());
     auto chrome_delegate =
@@ -115,6 +133,8 @@ class ChildBrowserViewDelegate : public CefBrowserViewDelegate {
   ChildBrowserViewDelegate(const ChildBrowserViewDelegate&) = delete;
   ChildBrowserViewDelegate& operator=(const ChildBrowserViewDelegate&) = delete;
 
+  // |browser_view| will be nullptr when called for popups with non-Views-hosted
+  // opener.
   CefRefPtr<CefBrowserViewDelegate> GetDelegateForPopupBrowserView(
       CefRefPtr<CefBrowserView> browser_view,
       const CefBrowserSettings& settings,
@@ -123,11 +143,13 @@ class ChildBrowserViewDelegate : public CefBrowserViewDelegate {
     return new ChildBrowserViewDelegate();
   }
 
+  // |browser_view| will be nullptr when called for popups with non-Views-hosted
+  // opener.
   bool OnPopupBrowserViewCreated(CefRefPtr<CefBrowserView> browser_view,
                                  CefRefPtr<CefBrowserView> popup_browser_view,
                                  bool is_devtools) override {
-    auto new_browser = static_cast<CefBrowserHostBase*>(
-        popup_browser_view->GetBrowser().get());
+    auto new_browser =
+        CefBrowserHostBase::FromBrowser(popup_browser_view->GetBrowser());
     auto new_platform_delegate = new_browser->platform_delegate();
     DCHECK(new_platform_delegate->IsViewsHosted());
     auto new_platform_delegate_impl =
@@ -136,8 +158,7 @@ class ChildBrowserViewDelegate : public CefBrowserViewDelegate {
 
     const auto& window_info =
         new_platform_delegate_impl->native_delegate()->window_info();
-    const auto parent_handle =
-        chrome_child_window::GetParentHandle(window_info);
+    const auto parent_handle = GetParentWidget(window_info);
     if (parent_handle != gfx::kNullAcceleratedWidget) {
       ChildWindowDelegate::Create(popup_browser_view, window_info,
                                   parent_handle);
@@ -158,15 +179,7 @@ class ChildBrowserViewDelegate : public CefBrowserViewDelegate {
 namespace chrome_child_window {
 
 bool HasParentHandle(const CefWindowInfo& window_info) {
-  return GetParentHandle(window_info) != gfx::kNullAcceleratedWidget;
-}
-
-gfx::AcceleratedWidget GetParentHandle(const CefWindowInfo& window_info) {
-#if !BUILDFLAG(IS_MAC)
-  return window_info.parent_window;
-#else
-  return gfx::kNullAcceleratedWidget;
-#endif
+  return GetParentHandle(window_info) != kNullWindowHandle;
 }
 
 CefRefPtr<CefBrowserHostBase> MaybeCreateChildBrowser(
@@ -181,7 +194,7 @@ CefRefPtr<CefBrowserHostBase> MaybeCreateChildBrowser(
     return nullptr;
   }
 
-  const auto parent_handle = GetParentHandle(*create_params.window_info);
+  const auto parent_handle = GetParentWidget(*create_params.window_info);
   if (parent_handle == gfx::kNullAcceleratedWidget) {
     return nullptr;
   }
@@ -195,7 +208,12 @@ CefRefPtr<CefBrowserHostBase> MaybeCreateChildBrowser(
   ChildWindowDelegate::Create(browser_view, *create_params.window_info,
                               parent_handle);
 
-  return static_cast<CefBrowserHostBase*>(browser_view->GetBrowser().get());
+  return CefBrowserHostBase::FromBrowser(browser_view->GetBrowser());
+}
+
+CefRefPtr<CefBrowserViewDelegate>
+GetDefaultBrowserViewDelegateForPopupOpener() {
+  return new ChildBrowserViewDelegate();
 }
 
 }  // namespace chrome_child_window

libcef/browser/chrome/views/chrome_child_window.h

@@ -6,19 +6,19 @@
 #define CEF_LIBCEF_BROWSER_CHROME_VIEWS_CHROME_CHILD_WINDOW_H_
 #pragma once
 
+#include "include/views/cef_browser_view_delegate.h"
 #include "libcef/browser/browser_host_base.h"
 
-#include "ui/gfx/native_widget_types.h"
-
 namespace chrome_child_window {
 
 bool HasParentHandle(const CefWindowInfo& window_info);
-gfx::AcceleratedWidget GetParentHandle(const CefWindowInfo& window_info);
 
 // Called from CefBrowserHostBase::Create.
 CefRefPtr<CefBrowserHostBase> MaybeCreateChildBrowser(
     const CefBrowserCreateParams& create_params);
 
+CefRefPtr<CefBrowserViewDelegate> GetDefaultBrowserViewDelegateForPopupOpener();
+
 }  // namespace chrome_child_window
 
 #endif  // CEF_LIBCEF_BROWSER_CHROME_VIEWS_CHROME_CHILD_WINDOW_H_