bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-02-27 01:17:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Windows: Fix white flash during browser creation (issue #1984)

Browse Source
This commit is contained in:
Marshall Greenblatt 2017-01-13 16:35:26 -05:00
parent fd774d81ad
commit d685d27313
3 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libcef/browser/content_browser_client.cc
View File

@ -836,8 +836,7 @@ void CefContentBrowserClient::OverrideWebkitPrefs(
content::WebPreferences* prefs) { content::WebPreferences* prefs) {
renderer_prefs::PopulateWebPreferences(rvh, *prefs); renderer_prefs::PopulateWebPreferences(rvh, *prefs);
if (rvh->GetWidget()->GetView() && if (rvh->GetWidget()->GetView()) {
rvh->GetWidget()->GetView()->GetNativeView()) {
rvh->GetWidget()->GetView()->SetBackgroundColor( rvh->GetWidget()->GetView()->SetBackgroundColor(
prefs->base_background_color); prefs->base_background_color);
} }

3
patch/patch.cfg
View File

@ -65,6 +65,9 @@ patches = [
# #
# Support creation of captionless windows with resizable borders. # Support creation of captionless windows with resizable borders.
# https://bitbucket.org/chromiumembedded/cef/issues/1749 # https://bitbucket.org/chromiumembedded/cef/issues/1749
#
# Fix white flash during browser creation.
# https://bitbucket.org/chromiumembedded/cef/issues/1984
'name': 'views_widget_180_1481_1677_1749', 'name': 'views_widget_180_1481_1677_1749',
'path': '../', 'path': '../',
}, },

15
patch/patches/views_widget_180_1481_1677_1749.patch
View File

@ -1,5 +1,5 @@
diff --git content/browser/renderer_host/render_widget_host_view_aura.cc content/browser/renderer_host/render_widget_host_view_aura.cc diff --git content/browser/renderer_host/render_widget_host_view_aura.cc content/browser/renderer_host/render_widget_host_view_aura.cc
index 3992bb0..45d82fc 100644 index 3992bb0..1c27354 100644
--- content/browser/renderer_host/render_widget_host_view_aura.cc --- content/browser/renderer_host/render_widget_host_view_aura.cc
+++ content/browser/renderer_host/render_widget_host_view_aura.cc +++ content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -769,6 +769,13 @@ void RenderWidgetHostViewAura::SetKeyboardFocus() { @@ -769,6 +769,13 @@ void RenderWidgetHostViewAura::SetKeyboardFocus() {
@ -16,6 +16,19 @@ index 3992bb0..45d82fc 100644
// TODO(wjmaclean): can host_ ever be null? // TODO(wjmaclean): can host_ ever be null?
if (host_ && set_focus_on_mouse_down_or_key_event_) { if (host_ && set_focus_on_mouse_down_or_key_event_) {
set_focus_on_mouse_down_or_key_event_ = false; set_focus_on_mouse_down_or_key_event_ = false;
@@ -923,8 +930,10 @@ void RenderWidgetHostViewAura::SetBackgroundColor(SkColor color) {
RenderWidgetHostViewBase::SetBackgroundColor(color);
bool opaque = GetBackgroundOpaque();
host_->SetBackgroundOpaque(opaque);
- window_->layer()->SetFillsBoundsOpaquely(opaque);
- window_->layer()->SetColor(color);
+ if (window_) {
+ window_->layer()->SetFillsBoundsOpaquely(opaque);
+ window_->layer()->SetColor(color);
+ }
}
gfx::Size RenderWidgetHostViewAura::GetVisibleViewportSize() const {
diff --git content/browser/renderer_host/render_widget_host_view_base.cc content/browser/renderer_host/render_widget_host_view_base.cc diff --git content/browser/renderer_host/render_widget_host_view_base.cc content/browser/renderer_host/render_widget_host_view_base.cc
index 28b3698..337f35d 100644 index 28b3698..337f35d 100644
--- content/browser/renderer_host/render_widget_host_view_base.cc --- content/browser/renderer_host/render_widget_host_view_base.cc