bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix background color assignment for popups (fixes issue #2482)"

Browse Source 
This change is causing the OSRTest.OsrPopupJSOtherClient test to fail.

This reverts commit 3adb801ca8.
This commit is contained in:
Marshall Greenblatt
2020-04-24 15:41:07 -04:00
parent fd1f465fa7
commit cbc0625272
4 changed files with 23 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libcef/browser/browser_host_impl.cc
View File

@@ -2534,13 +2534,6 @@ void CefBrowserHostImpl::RenderViewCreated(
RenderFrameCreated(render_view_host->GetMainFrame());
platform_delegate_->RenderViewCreated(render_view_host);
// Make sure the background color is set on the WebView and the Widget.
render_view_host->OnWebkitPreferencesChanged();
if (render_view_host->GetWidget()->GetView()) {
render_view_host->GetWidget()->GetView()->SetBackgroundColor(
GetBackgroundColor());
}
}
void CefBrowserHostImpl::RenderViewDeleted(

5
libcef/browser/content_browser_client.cc
View File

@@ -1051,6 +1051,11 @@ void CefContentBrowserClient::OverrideWebkitPrefs(
// Using RVH instead of RFH here because rvh->GetMainFrame() may be nullptr
// when this method is called.
renderer_prefs::PopulateWebPreferences(rvh, *prefs);
if (rvh->GetWidget()->GetView()) {
rvh->GetWidget()->GetView()->SetBackgroundColor(
prefs->base_background_color);
}
}
void CefContentBrowserClient::BrowserURLHandlerCreated(