bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential iterator validity issue in RootWindowManager::CloseAllWindows (issue #2514)

Browse Source
This commit is contained in:
Marshall Greenblatt
2018-09-24 17:14:04 +02:00
parent 275af5e972
commit c7d2891058
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/cefclient/browser/root_window_manager.cc
View File

@@ -263,8 +263,12 @@ void RootWindowManager::CloseAllWindows(bool force) {
if (root_windows_.empty()) if (root_windows_.empty())
return; return;
RootWindowSet::const_iterator it = root_windows_.begin(); // Use a copy of |root_windows_| because the original set may be modified
for (; it != root_windows_.end(); ++it) // in OnRootWindowDestroyed while iterating.
RootWindowSet root_windows = root_windows_;
RootWindowSet::const_iterator it = root_windows.begin();
for (; it != root_windows.end(); ++it)
(*it)->Close(force); (*it)->Close(force);
} }