bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Migrate ignore_result to std::ignore (see issue #3234)

Browse Source 
See https://crbug.com/1285085 for background.
This commit is contained in:
Marshall Greenblatt
2022-01-25 14:40:24 -05:00
parent ebde595370
commit c32f366dfa
12 changed files with 32 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libcef/common/alloy/alloy_main_delegate.cc
View File

@@ -4,6 +4,8 @@
#include "libcef/common/alloy/alloy_main_delegate.h"
#include <tuple>
#include "libcef/browser/alloy/alloy_browser_context.h"
#include "libcef/browser/alloy/alloy_content_browser_client.h"
#include "libcef/common/cef_switches.h"
@@ -17,7 +19,6 @@
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/ignore_result.h"
#include "base/path_service.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
@@ -280,7 +281,7 @@ bool AlloyMainDelegate::BasicStartupComplete(int* exit_code) {
new CefCommandLineImpl(command_line, false, false));
application_->OnBeforeCommandLineProcessing(CefString(process_type),
commandLinePtr.get());
ignore_result(commandLinePtr->Detach(nullptr));
std::ignore = commandLinePtr->Detach(nullptr);
}
// Initialize logging.

5
libcef/common/chrome/chrome_main_delegate_cef.cc
View File

@@ -5,6 +5,8 @@
#include "libcef/common/chrome/chrome_main_delegate_cef.h"
#include <tuple>
#include "libcef/browser/chrome/chrome_browser_context.h"
#include "libcef/browser/chrome/chrome_content_browser_client_cef.h"
#include "libcef/common/cef_switches.h"
@@ -14,7 +16,6 @@
#include "libcef/renderer/chrome/chrome_content_renderer_client_cef.h"
#include "base/command_line.h"
#include "base/ignore_result.h"
#include "base/lazy_instance.h"
#include "chrome/common/chrome_switches.h"
#include "components/embedder_support/switches.h"
@@ -126,7 +127,7 @@ bool ChromeMainDelegateCef::BasicStartupComplete(int* exit_code) {
new CefCommandLineImpl(command_line, false, false));
application_->OnBeforeCommandLineProcessing(process_type,
commandLinePtr.get());
ignore_result(commandLinePtr->Detach(nullptr));
std::ignore = commandLinePtr->Detach(nullptr);
}
#if BUILDFLAG(IS_MAC)

4
libcef/common/time_impl.cc
View File

@@ -4,7 +4,7 @@
#include "libcef/common/time_util.h"
#include "base/ignore_result.h"
#include <tuple>
#if BUILDFLAG(IS_WIN)
#include <limits>
@@ -33,7 +33,7 @@ void cef_time_to_basetime(const cef_time_t& cef_time, base::Time& time) {
exploded.minute = cef_time.minute;
exploded.second = cef_time.second;
exploded.millisecond = cef_time.millisecond;
ignore_result(base::Time::FromUTCExploded(exploded, &time));
std::ignore = base::Time::FromUTCExploded(exploded, &time);
}
void cef_time_from_basetime(const base::Time& time, cef_time_t& cef_time) {