diff --git a/tests/ceftests/audio_output_unittest.cc b/tests/ceftests/audio_output_unittest.cc index 3bd57970d..4d93b53ab 100644 --- a/tests/ceftests/audio_output_unittest.cc +++ b/tests/ceftests/audio_output_unittest.cc @@ -854,7 +854,7 @@ const char kToggleTestHtml[] = class AudioOutputTest : public ClientAppBrowser::Delegate { public: - AudioOutputTest() {} + AudioOutputTest() = default; void OnBeforeCommandLineProcessing( CefRefPtr app, @@ -870,7 +870,7 @@ class AudioOutputTest : public ClientAppBrowser::Delegate { class AudioTestHandler : public TestHandler, public CefAudioHandler { public: - AudioTestHandler() {} + AudioTestHandler() = default; void SetupAudioTest(const std::string& testUrl) { // Add the resource. @@ -961,7 +961,7 @@ class AudioTestHandler : public TestHandler, public CefAudioHandler { // A common base class for audio output tests. class AudioOutputTestHandler : public AudioTestHandler { public: - AudioOutputTestHandler() {} + AudioOutputTestHandler() = default; void RunTest() override { // Setup the resource. @@ -987,7 +987,7 @@ class AudioOutputTestHandler : public AudioTestHandler { class AudioCloseBrowserTest : public AudioTestHandler { public: - AudioCloseBrowserTest() {} + AudioCloseBrowserTest() = default; void RunTest() override { // Setup the resource. @@ -1028,7 +1028,7 @@ class AudioCloseBrowserTest : public AudioTestHandler { // this nearly 15 seconds test run. class AudioTogglePlaybackTest : public AudioTestHandler { public: - AudioTogglePlaybackTest() {} + AudioTogglePlaybackTest() = default; void RunTest() override { // Add the resource. diff --git a/tests/ceftests/browser_info_map_unittest.cc b/tests/ceftests/browser_info_map_unittest.cc index ef530508e..fca5336e3 100644 --- a/tests/ceftests/browser_info_map_unittest.cc +++ b/tests/ceftests/browser_info_map_unittest.cc @@ -10,7 +10,7 @@ namespace { struct MyObject { - MyObject(int val = 0) : member(val) {} + explicit MyObject(int val = 0) : member(val) {} int member; }; @@ -24,9 +24,9 @@ typedef CefBrowserInfoMap MyObjectMap; class MyVisitor : public MyObjectMap::Visitor { public: - MyVisitor(bool remove = false, - int remove_browser_id = 0, - InfoIdType remove_info_id = 0) + explicit MyVisitor(bool remove = false, + int remove_browser_id = 0, + InfoIdType remove_info_id = 0) : remove_(remove), remove_browser_id_(remove_browser_id), remove_info_id_(remove_info_id) {} @@ -680,7 +680,7 @@ namespace { class MyHeapObject { public: - MyHeapObject(int* destroy_ct) : destroy_ct_(destroy_ct) {} + explicit MyHeapObject(int* destroy_ct) : destroy_ct_(destroy_ct) {} ~MyHeapObject() { (*destroy_ct_)++; } private: diff --git a/tests/ceftests/certificate_error_unittest.cc b/tests/ceftests/certificate_error_unittest.cc index 927c6c101..736f8fe4d 100644 --- a/tests/ceftests/certificate_error_unittest.cc +++ b/tests/ceftests/certificate_error_unittest.cc @@ -323,14 +323,14 @@ namespace { class DirectMismatchedTest : public CertificateErrorTest { public: - DirectMismatchedTest(bool continue_invalid_certificate) + explicit DirectMismatchedTest(bool continue_invalid_certificate) : CertificateErrorTest( /*cert_type=*/CEF_TEST_CERT_OK_DOMAIN, /*expect_load_success=*/continue_invalid_certificate, /*expect_certificate_error=*/true) {} protected: - std::string GetStartURL() const { + std::string GetStartURL() const override { // Load by IP address when the certificate expects a domain. return client::AsciiStrReplace(server_origin(), "localhost", "127.0.0.1") + "/index.html"; diff --git a/tests/ceftests/cookie_unittest.cc b/tests/ceftests/cookie_unittest.cc index 235e01362..b2e958060 100644 --- a/tests/ceftests/cookie_unittest.cc +++ b/tests/ceftests/cookie_unittest.cc @@ -579,7 +579,7 @@ const char* kCookieJSUrl2 = "https://tests/cookie2.html"; class CookieTestJSHandler : public TestHandler { public: - CookieTestJSHandler() {} + CookieTestJSHandler() = default; void RunTest() override { std::string page = @@ -727,7 +727,7 @@ class CookieTestSchemeHandler : public TestHandler { class SchemeHandler : public CefResourceHandler { public: explicit SchemeHandler(CookieTestSchemeHandler* handler) - : handler_(handler), offset_(0) {} + : handler_(handler) {} bool Open(CefRefPtr request, bool& handle_request, @@ -805,7 +805,7 @@ class CookieTestSchemeHandler : public TestHandler { private: CookieTestSchemeHandler* handler_; std::string content_; - size_t offset_; + size_t offset_ = 0; std::string cookie_; IMPLEMENT_REFCOUNTING(SchemeHandler); @@ -1114,11 +1114,11 @@ struct CookieAccessData { class CookieAccessResponseHandler { public: - CookieAccessResponseHandler() {} + CookieAccessResponseHandler() = default; virtual void AddResponse(const std::string& url, CookieAccessData* data) = 0; protected: - virtual ~CookieAccessResponseHandler() {} + virtual ~CookieAccessResponseHandler() = default; }; std::string GetHeaderValue(const CefServer::HeaderMap& header_map, @@ -1134,8 +1134,7 @@ std::string GetHeaderValue(const CefServer::HeaderMap& header_map, // Serves request responses. class CookieAccessSchemeHandler : public CefResourceHandler { public: - explicit CookieAccessSchemeHandler(CookieAccessData* data) - : data_(data), offset_(0) {} + explicit CookieAccessSchemeHandler(CookieAccessData* data) : data_(data) {} bool Open(CefRefPtr request, bool& handle_request, @@ -1213,7 +1212,7 @@ class CookieAccessSchemeHandler : public CefResourceHandler { // |data_| is not owned by this object. CookieAccessData* data_; - size_t offset_; + size_t offset_ = 0; IMPLEMENT_REFCOUNTING(CookieAccessSchemeHandler); DISALLOW_COPY_AND_ASSIGN(CookieAccessSchemeHandler); @@ -1222,7 +1221,7 @@ class CookieAccessSchemeHandler : public CefResourceHandler { class CookieAccessSchemeHandlerFactory : public CefSchemeHandlerFactory, public CookieAccessResponseHandler { public: - CookieAccessSchemeHandlerFactory() {} + CookieAccessSchemeHandlerFactory() = default; CefRefPtr Create(CefRefPtr browser, CefRefPtr frame, @@ -1269,12 +1268,9 @@ class CookieAccessSchemeHandlerFactory : public CefSchemeHandlerFactory, class CookieAccessServerHandler : public test_server::ObserverHelper, public CookieAccessResponseHandler { public: - CookieAccessServerHandler() - : initialized_(false), - expected_http_request_ct_(-1), - actual_http_request_ct_(0) {} + CookieAccessServerHandler() = default; - virtual ~CookieAccessServerHandler() { RunCompleteCallback(); } + ~CookieAccessServerHandler() override { RunCompleteCallback(); } // Must be called before CreateServer(). void AddResponse(const std::string& url, CookieAccessData* data) override { @@ -1381,7 +1377,7 @@ class CookieAccessServerHandler : public test_server::ObserverHelper, typedef std::map ResponseDataMap; ResponseDataMap data_map_; - bool initialized_; + bool initialized_ = false; // Only accessed on the UI thread. base::OnceClosure complete_callback_; @@ -1392,8 +1388,8 @@ class CookieAccessServerHandler : public test_server::ObserverHelper, TrackCallback got_server_created_; TrackCallback got_server_destroyed_; - int expected_http_request_ct_; - int actual_http_request_ct_; + int expected_http_request_ct_ = -1; + int actual_http_request_ct_ = 0; std::string request_log_; diff --git a/tests/ceftests/cors_unittest.cc b/tests/ceftests/cors_unittest.cc index 9cb06b71a..c5d0e3181 100644 --- a/tests/ceftests/cors_unittest.cc +++ b/tests/ceftests/cors_unittest.cc @@ -23,7 +23,7 @@ namespace { // Browser-side app delegate. class CorsBrowserTest : public client::ClientAppBrowser::Delegate { public: - CorsBrowserTest() {} + CorsBrowserTest() = default; void OnContextInitialized(CefRefPtr app) override { if (IsChromeRuntimeEnabled()) { @@ -156,7 +156,7 @@ struct Resource { int success_query_ct = 0; int failure_query_ct = 0; - Resource() {} + Resource() = default; Resource(HandlerType request_handler, const std::string& request_path, const std::string& mime_type = kMimeTypeHtml, @@ -587,7 +587,7 @@ class CorsTestHandler : public RoutingTestHandler { CEF_REQUIRE_UI_THREAD(); DCHECK(setup_->clear_cookies); test_request::GetAllCookies( - CefCookieManager::GetGlobalManager(nullptr), /*delete_cookies=*/true, + CefCookieManager::GetGlobalManager(nullptr), /*deleteCookies=*/true, base::BindOnce(&CorsTestHandler::ClearedCookies, this)); } @@ -713,7 +713,7 @@ TEST(CorsTest, BasicCustomStandardSchemeWithQuery) { namespace { struct CookieTestSetup : TestSetup { - CookieTestSetup() {} + CookieTestSetup() = default; bool expect_cookie = false; @@ -733,13 +733,13 @@ struct CookieTestSetup : TestSetup { }; struct CookieResource : Resource { - CookieResource() {} + CookieResource() = default; bool expect_cookie = false; void InitSetCookie() { response->SetHeaderByName("Set-Cookie", kDefaultCookie, - /*override=*/true); + /*overwrite=*/true); } bool VerifyRequest(CefRefPtr request) const override { @@ -976,7 +976,7 @@ const char kSubUnsafeHeaderName[] = "x-unsafe-header"; const char kSubUnsafeHeaderValue[] = "not-safe"; struct SubResource : CookieResource { - SubResource() {} + SubResource() = default; std::string main_origin; bool supports_cors = false; @@ -1525,7 +1525,7 @@ enum class RedirectMode { }; struct RedirectGetResource : CookieResource { - RedirectGetResource() {} + RedirectGetResource() = default; bool VerifyRequest(CefRefPtr request) const override { if (!CookieResource::VerifyRequest(request)) { @@ -1551,7 +1551,7 @@ void SetupRedirectResponse(RedirectMode mode, } response->SetHeaderByName("Location", redirect_url, - /*override=*/false); + /*overwrite=*/false); } // Test redirect requests. @@ -1663,7 +1663,7 @@ CORS_TEST_REDIRECT_GET_ALL(307, MODE_307) namespace { struct PostResource : CookieResource { - PostResource() {} + PostResource() = default; bool expect_downgrade_to_get = false; bool was_redirected = false; diff --git a/tests/ceftests/devtools_message_unittest.cc b/tests/ceftests/devtools_message_unittest.cc index c695ae1cb..2856342fe 100644 --- a/tests/ceftests/devtools_message_unittest.cc +++ b/tests/ceftests/devtools_message_unittest.cc @@ -22,7 +22,7 @@ const char kTestUrl2[] = "https://tests/DevToolsMessage2"; class DevToolsMessageTestHandler : public TestHandler { public: - DevToolsMessageTestHandler() {} + DevToolsMessageTestHandler() = default; void RunTest() override { // Add HTML resources. @@ -113,7 +113,7 @@ class DevToolsMessageTestHandler : public TestHandler { explicit TestMessageObserver(DevToolsMessageTestHandler* handler) : handler_(handler) {} - virtual ~TestMessageObserver() { handler_->observer_destroyed_.yes(); } + ~TestMessageObserver() override { handler_->observer_destroyed_.yes(); } bool OnDevToolsMessage(CefRefPtr browser, const void* message, diff --git a/tests/ceftests/dialog_unittest.cc b/tests/ceftests/dialog_unittest.cc index 3ee680ce2..947abe4bc 100644 --- a/tests/ceftests/dialog_unittest.cc +++ b/tests/ceftests/dialog_unittest.cc @@ -18,9 +18,7 @@ class DialogTestHandler : public TestHandler { explicit TestConfig(FileDialogMode dialog_mode) : mode(dialog_mode), title("Test Title"), - default_file_name("Test File Name"), - callback_async(false), - callback_cancel(false) { + default_file_name("Test File Name") { accept_types.push_back("text/*"); accept_types.push_back(".js"); accept_types.push_back(".css"); @@ -31,9 +29,12 @@ class DialogTestHandler : public TestHandler { CefString default_file_name; std::vector accept_types; - bool callback_async; // True if the callback should execute asynchronously. - bool callback_cancel; // True if the callback should cancel. - std::vector callback_paths; // Resulting paths if not cancelled. + // True if the callback should execute asynchronously. + bool callback_async = false; + // True if the callback should cancel. + bool callback_cancel = false; + // Resulting paths if not cancelled. + std::vector callback_paths; }; class Callback : public CefRunFileDialogCallback { diff --git a/tests/ceftests/display_unittest.cc b/tests/ceftests/display_unittest.cc index e867d3c59..965c51f87 100644 --- a/tests/ceftests/display_unittest.cc +++ b/tests/ceftests/display_unittest.cc @@ -28,8 +28,7 @@ const char kTitleStr3[] = "Title 3"; // Browser side. class TitleTestHandler : public TestHandler { public: - TitleTestHandler() - : step_(0), got_title_change_(false), got_loading_state_change_(false) {} + TitleTestHandler() = default; void RunTest() override { // Add the resources that we will navigate to/from. @@ -130,10 +129,10 @@ class TitleTestHandler : public TestHandler { TestHandler::DestroyTest(); } - int step_; + int step_ = 0; - bool got_title_change_; - bool got_loading_state_change_; + bool got_title_change_ = false; + bool got_loading_state_change_ = false; TrackCallback got_title_[5]; @@ -155,7 +154,7 @@ const char kAutoResizeUrl[] = "https://tests-display/auto-resize.html"; class AutoResizeTestHandler : public RoutingTestHandler { public: - AutoResizeTestHandler() {} + AutoResizeTestHandler() = default; void RunTest() override { // Add the resources that we will navigate to/from. @@ -260,18 +259,17 @@ class ConsoleTestHandler : public TestHandler { : level(message_level), message("'Test Message'"), expected_message("Test Message"), - source("https://tests-console-message/level.html"), - line(42) {} + source("https://tests-console-message/level.html") {} cef_log_severity_t level; std::string message; std::string expected_message; std::string source; - int line; + int line = 42; std::string function; }; - ConsoleTestHandler(const TestConfig& config) : config_(config) {} + explicit ConsoleTestHandler(const TestConfig& config) : config_(config) {} void RunTest() override { // Add the resources that will be used to print to console. @@ -469,7 +467,7 @@ const char kLoadinProgressUrl[] = "https://tests-display/loading-progress.html"; // Browser side. class LoadingProgressTestHandler : public TestHandler { public: - LoadingProgressTestHandler() {} + LoadingProgressTestHandler() = default; void RunTest() override { // Add the resources that we will navigate to/from. diff --git a/tests/ceftests/dom_unittest.cc b/tests/ceftests/dom_unittest.cc index a831b4b94..0c40453ce 100644 --- a/tests/ceftests/dom_unittest.cc +++ b/tests/ceftests/dom_unittest.cc @@ -264,7 +264,7 @@ class TestDOMVisitor : public CefDOMVisitor { // Used in the render process. class DOMRendererTest : public ClientAppRenderer::Delegate { public: - DOMRendererTest() {} + DOMRendererTest() = default; bool OnProcessMessageReceived(CefRefPtr app, CefRefPtr browser, diff --git a/tests/ceftests/download_unittest.cc b/tests/ceftests/download_unittest.cc index 768906e46..cba27a1df 100644 --- a/tests/ceftests/download_unittest.cc +++ b/tests/ceftests/download_unittest.cc @@ -34,9 +34,7 @@ class DownloadSchemeHandler : public CefResourceHandler { DownloadSchemeHandler(DelayCallback delay_callback, TrackCallback* got_download_request) : delay_callback_(std::move(delay_callback)), - got_download_request_(got_download_request), - should_delay_(false), - offset_(0) {} + got_download_request_(got_download_request) {} bool Open(CefRefPtr request, bool& handle_request, @@ -128,11 +126,11 @@ class DownloadSchemeHandler : public CefResourceHandler { DelayCallback delay_callback_; TrackCallback* got_download_request_; - bool should_delay_; + bool should_delay_ = false; std::string content_; std::string mime_type_; std::string content_disposition_; - size_t offset_; + size_t offset_ = 0; CefRefPtr read_callback_; IMPLEMENT_REFCOUNTING(DownloadSchemeHandler); @@ -182,9 +180,7 @@ class DownloadTestHandler : public TestHandler { const std::string& rc_cache_path) : test_mode_(test_mode), rc_mode_(rc_mode), - rc_cache_path_(rc_cache_path), - download_id_(0), - verified_results_(false) {} + rc_cache_path_(rc_cache_path) {} bool is_clicked() const { return test_mode_ == CLICKED || test_mode_ == CLICKED_INVALID || @@ -569,8 +565,8 @@ class DownloadTestHandler : public TestHandler { std::string download_url_; CefScopedTempDir temp_dir_; std::string test_path_; - uint32_t download_id_; - bool verified_results_; + uint32_t download_id_ = 0; + bool verified_results_ = false; bool destroyed_ = false; TrackCallback got_download_request_; diff --git a/tests/ceftests/extensions/chrome_tabs_unittest.cc b/tests/ceftests/extensions/chrome_tabs_unittest.cc index c40043e42..d2d5f0f7c 100644 --- a/tests/ceftests/extensions/chrome_tabs_unittest.cc +++ b/tests/ceftests/extensions/chrome_tabs_unittest.cc @@ -27,13 +27,7 @@ const char kSuccessMessage[] = "success"; class TabsTestHandler : public ExtensionTestHandler { public: explicit TabsTestHandler(RequestContextType request_context_type) - : ExtensionTestHandler(request_context_type), - create_main_browser_first_(false), - expect_get_active_browser_(true), - expect_success_in_main_browser_(true), - expected_api_call_count_(1), - got_get_active_browser_count_(0), - got_can_access_browser_count_(0) {} + : ExtensionTestHandler(request_context_type) {} // CefExtensionHandler methods: void OnExtensionLoaded(CefRefPtr extension) override { @@ -335,20 +329,20 @@ class TabsTestHandler : public ExtensionTestHandler { // If true the main browser will be created before the extension browser. // Otherwise the creation order is undefined. - bool create_main_browser_first_; + bool create_main_browser_first_ = false; // If true we expect GetActiveBrowser() but not CanAccessBrowser() to be // called. Else visa-versa. - bool expect_get_active_browser_; + bool expect_get_active_browser_ = true; // If true we expect the success message to be delivered in the main browser. // Else expect it in the extension browser. - bool expect_success_in_main_browser_; + bool expect_success_in_main_browser_ = true; // Number of expected calls to GetActiveBrowser or CanAccessBrowser. This // should match the number of calls to chrome.tabs.* API functions in the // test. - int expected_api_call_count_; + int expected_api_call_count_ = 1; CefRefPtr extension_; std::string extension_url_; @@ -364,8 +358,8 @@ class TabsTestHandler : public ExtensionTestHandler { TrackCallback got_success_message_; TrackCallback got_extension_unloaded_; - int got_get_active_browser_count_; - int got_can_access_browser_count_; + int got_get_active_browser_count_ = 0; + int got_can_access_browser_count_ = 0; }; // diff --git a/tests/ceftests/extensions/extension_test_handler.cc b/tests/ceftests/extensions/extension_test_handler.cc index 0aaef516d..6c5372bf7 100644 --- a/tests/ceftests/extensions/extension_test_handler.cc +++ b/tests/ceftests/extensions/extension_test_handler.cc @@ -10,7 +10,7 @@ ExtensionTestHandler::ExtensionTestHandler( RequestContextType request_context_type) - : request_context_type_(request_context_type), create_main_browser_(true) { + : request_context_type_(request_context_type) { // Verify supported flag combinations. if (request_context_on_disk()) { EXPECT_TRUE(request_context_is_custom()); @@ -79,7 +79,7 @@ void ExtensionTestHandler::RunTest() { if (request_context_load_with_handler()) { class Handler : public CefRequestContextHandler { public: - Handler() {} + Handler() = default; private: IMPLEMENT_REFCOUNTING(Handler); @@ -207,8 +207,8 @@ void ExtensionTestHandler::VerifyExtensionInContext( // has finished loading (our extension may load first if the call to // LoadExtension initializes the request context). bool has_extension = false; - for (size_t i = 0; i < extension_ids.size(); ++i) { - if (extension_ids[i] == extension_id) { + for (const auto& i : extension_ids) { + if (i == extension_id) { has_extension = true; break; } diff --git a/tests/ceftests/extensions/extension_test_handler.h b/tests/ceftests/extensions/extension_test_handler.h index 3e3eeb39f..d8faa1727 100644 --- a/tests/ceftests/extensions/extension_test_handler.h +++ b/tests/ceftests/extensions/extension_test_handler.h @@ -43,7 +43,7 @@ class ExtensionTestHandler : public RoutingTestHandler, }; explicit ExtensionTestHandler(RequestContextType request_context_type); - virtual ~ExtensionTestHandler(); + ~ExtensionTestHandler() override; // TestHandler methods: void RunTest() override; @@ -146,7 +146,7 @@ class ExtensionTestHandler : public RoutingTestHandler, CefRefPtr loader_request_context_; // If true expect creation of a main browser. Default is true. - bool create_main_browser_; + bool create_main_browser_ = true; DISALLOW_COPY_AND_ASSIGN(ExtensionTestHandler); }; diff --git a/tests/ceftests/frame_handler_unittest.cc b/tests/ceftests/frame_handler_unittest.cc index 42ee79d7f..41270d1d5 100644 --- a/tests/ceftests/frame_handler_unittest.cc +++ b/tests/ceftests/frame_handler_unittest.cc @@ -95,7 +95,7 @@ struct FrameStatus { return ss.str(); } - FrameStatus(CefRefPtr frame) + explicit FrameStatus(CefRefPtr frame) : frame_id_(frame->GetIdentifier()), is_main_(frame->IsMain()), ident_str_(GetFrameDebugString(frame)) {} @@ -510,7 +510,7 @@ const char kOrderMainUrl[] = "https://tests-frame-handler/main-order.html"; class OrderMainTestHandler : public RoutingTestHandler, public CefFrameHandler { public: - OrderMainTestHandler(CompletionState* completion_state = nullptr) + explicit OrderMainTestHandler(CompletionState* completion_state = nullptr) : RoutingTestHandler(completion_state) {} CefRefPtr GetFrameHandler() override { @@ -801,7 +801,8 @@ const char kOrderMainUrlPrefix[] = "https://tests-frame-handler"; class NavigateOrderMainTestHandler : public OrderMainTestHandler { public: - NavigateOrderMainTestHandler(bool cross_origin, int additional_nav_ct = 2) + explicit NavigateOrderMainTestHandler(bool cross_origin, + int additional_nav_ct = 2) : cross_origin_(cross_origin), additional_nav_ct_(additional_nav_ct) {} void RunTest() override { diff --git a/tests/ceftests/frame_unittest.cc b/tests/ceftests/frame_unittest.cc index cd6d0c0a8..a5833c955 100644 --- a/tests/ceftests/frame_unittest.cc +++ b/tests/ceftests/frame_unittest.cc @@ -108,7 +108,7 @@ class FrameNavExpectations { FrameNavExpectations(int nav, bool renderer) : nav_(nav), renderer_(renderer) {} - virtual ~FrameNavExpectations() {} + virtual ~FrameNavExpectations() = default; // Browser and renderer notifications. virtual bool OnLoadingStateChange(CefRefPtr browser, @@ -207,8 +207,8 @@ class FrameNavExpectationsRenderer : public FrameNavExpectations { // Abstract base class for the factory that creates expectations objects. class FrameNavExpectationsFactory { public: - FrameNavExpectationsFactory() {} - virtual ~FrameNavExpectationsFactory() {} + FrameNavExpectationsFactory() = default; + virtual ~FrameNavExpectationsFactory() = default; // Returns the unique ID for this factory type. virtual FrameNavFactoryId GetID() const = 0; @@ -217,7 +217,7 @@ class FrameNavExpectationsFactory { // Browser process expectations factory abstact base class. class FrameNavExpectationsFactoryBrowser : public FrameNavExpectationsFactory { public: - FrameNavExpectationsFactoryBrowser() {} + FrameNavExpectationsFactoryBrowser() = default; // Create a new factory instance of the specified type. static std::unique_ptr FromID( @@ -246,7 +246,7 @@ class FrameNavExpectationsFactoryBrowser : public FrameNavExpectationsFactory { // Renderer process expectations factory abstact base class. class FrameNavExpectationsFactoryRenderer : public FrameNavExpectationsFactory { public: - FrameNavExpectationsFactoryRenderer() {} + FrameNavExpectationsFactoryRenderer() = default; // Create a new factory instance of the specified type. static std::unique_ptr FromID( @@ -269,7 +269,7 @@ class FrameNavExpectationsFactoryRenderer : public FrameNavExpectationsFactory { class FrameNavRendererTest : public ClientAppRenderer::Delegate, public CefLoadHandler { public: - FrameNavRendererTest() : run_test_(false), nav_(0) {} + FrameNavRendererTest() = default; void OnBrowserCreated(CefRefPtr app, CefRefPtr browser, @@ -359,8 +359,8 @@ class FrameNavRendererTest : public ClientAppRenderer::Delegate, nav_++; } - bool run_test_; - int nav_; + bool run_test_ = false; + int nav_ = 0; std::unique_ptr factory_; std::unique_ptr expectations_; @@ -371,8 +371,7 @@ class FrameNavRendererTest : public ClientAppRenderer::Delegate, class FrameNavTestHandler : public TestHandler { public: explicit FrameNavTestHandler(FrameNavFactoryId factory_id) - : nav_(0), - factory_(FrameNavExpectationsFactoryBrowser::FromID(factory_id)) {} + : factory_(FrameNavExpectationsFactoryBrowser::FromID(factory_id)) {} ~FrameNavTestHandler() override { EXPECT_TRUE(got_destroyed_); } @@ -514,7 +513,7 @@ class FrameNavTestHandler : public TestHandler { TestHandler::DestroyTest(); } - int nav_; + int nav_ = 0; TrackCallback got_destroyed_; std::unique_ptr factory_; std::unique_ptr expectations_; @@ -774,7 +773,7 @@ class FrameNavExpectationsRendererTestSingleNavHarness class FrameNavExpectationsFactoryBrowserTestSingleNavHarness : public FrameNavExpectationsFactoryBrowser { public: - FrameNavExpectationsFactoryBrowserTestSingleNavHarness() {} + FrameNavExpectationsFactoryBrowserTestSingleNavHarness() = default; ~FrameNavExpectationsFactoryBrowserTestSingleNavHarness() override { EXPECT_TRUE(got_finalize_); @@ -815,7 +814,7 @@ class FrameNavExpectationsFactoryBrowserTestSingleNavHarness class FrameNavExpectationsFactoryRendererTestSingleNavHarness : public FrameNavExpectationsFactoryRenderer { public: - FrameNavExpectationsFactoryRendererTestSingleNavHarness() {} + FrameNavExpectationsFactoryRendererTestSingleNavHarness() = default; FrameNavFactoryId GetID() const override { return FNF_ID_SINGLE_NAV_HARNESS; } @@ -1009,7 +1008,7 @@ class FrameNavExpectationsRendererTestSingleNav class FrameNavExpectationsFactoryBrowserTestSingleNav : public FrameNavExpectationsFactoryBrowser { public: - FrameNavExpectationsFactoryBrowserTestSingleNav() {} + FrameNavExpectationsFactoryBrowserTestSingleNav() = default; FrameNavFactoryId GetID() const override { return FNF_ID_SINGLE_NAV; } @@ -1026,7 +1025,7 @@ class FrameNavExpectationsFactoryBrowserTestSingleNav class FrameNavExpectationsFactoryRendererTestSingleNav : public FrameNavExpectationsFactoryRenderer { public: - FrameNavExpectationsFactoryRendererTestSingleNav() {} + FrameNavExpectationsFactoryRendererTestSingleNav() = default; FrameNavFactoryId GetID() const override { return FNF_ID_SINGLE_NAV; } @@ -1177,7 +1176,7 @@ class FrameNavExpectationsBrowserTestMultiNavHarness typedef FrameNavExpectationsBrowserMultiNav parent; explicit FrameNavExpectationsBrowserTestMultiNavHarness(int nav) - : parent(nav), navigation_done_count_(0) {} + : parent(nav) {} ~FrameNavExpectationsBrowserTestMultiNavHarness() override { EXPECT_TRUE(got_finalize_); @@ -1262,7 +1261,7 @@ class FrameNavExpectationsBrowserTestMultiNavHarness TrackCallback got_load_end_; TrackCallback got_on_after_created_; TrackCallback got_renderer_complete_; - mutable int navigation_done_count_; + mutable int navigation_done_count_ = 0; TrackCallback got_finalize_; }; @@ -1272,7 +1271,7 @@ class FrameNavExpectationsRendererTestMultiNavHarness typedef FrameNavExpectationsRendererMultiNav parent; explicit FrameNavExpectationsRendererTestMultiNavHarness(int nav) - : parent(nav), navigation_done_count_(0) {} + : parent(nav) {} ~FrameNavExpectationsRendererTestMultiNavHarness() override { EXPECT_TRUE(got_finalize_); @@ -1314,15 +1313,14 @@ class FrameNavExpectationsRendererTestMultiNavHarness private: TrackCallback got_load_state_change_done_; TrackCallback got_load_end_; - mutable int navigation_done_count_; + mutable int navigation_done_count_ = 0; TrackCallback got_finalize_; }; class FrameNavExpectationsFactoryBrowserTestMultiNavHarness : public FrameNavExpectationsFactoryBrowser { public: - FrameNavExpectationsFactoryBrowserTestMultiNavHarness() - : get_browser_navigation_count_(0), create_count_(0) {} + FrameNavExpectationsFactoryBrowserTestMultiNavHarness() = default; ~FrameNavExpectationsFactoryBrowserTestMultiNavHarness() override { EXPECT_TRUE(got_finalize_); @@ -1353,15 +1351,15 @@ class FrameNavExpectationsFactoryBrowserTestMultiNavHarness } private: - mutable int get_browser_navigation_count_; - int create_count_; + mutable int get_browser_navigation_count_ = 0; + int create_count_ = 0; TrackCallback got_finalize_; }; class FrameNavExpectationsFactoryRendererTestMultiNavHarness : public FrameNavExpectationsFactoryRenderer { public: - FrameNavExpectationsFactoryRendererTestMultiNavHarness() {} + FrameNavExpectationsFactoryRendererTestMultiNavHarness() = default; FrameNavFactoryId GetID() const override { return FNF_ID_MULTI_NAV_HARNESS; } @@ -1565,7 +1563,7 @@ class FrameNavExpectationsRendererTestMultiNav class FrameNavExpectationsFactoryBrowserTestMultiNav : public FrameNavExpectationsFactoryBrowser { public: - FrameNavExpectationsFactoryBrowserTestMultiNav() : nav_count_(0) {} + FrameNavExpectationsFactoryBrowserTestMultiNav() = default; FrameNavFactoryId GetID() const override { return FNF_ID_MULTI_NAV; } @@ -1586,13 +1584,13 @@ class FrameNavExpectationsFactoryBrowserTestMultiNav } private: - int nav_count_; + int nav_count_ = 0; }; class FrameNavExpectationsFactoryRendererTestMultiNav : public FrameNavExpectationsFactoryRenderer { public: - FrameNavExpectationsFactoryRendererTestMultiNav() {} + FrameNavExpectationsFactoryRendererTestMultiNav() = default; FrameNavFactoryId GetID() const override { return FNF_ID_MULTI_NAV; } @@ -1834,6 +1832,7 @@ class FrameNavExpectationsBrowserTestNestedIframes case 2: { // Frame 2. Contains an named iframe created via javascript. std::stringstream ss; + // clang-format off ss << "Nav3"; + // clang-format on return ss.str(); } case 3: @@ -2139,8 +2139,7 @@ class FrameNavExpectationsRendererTestNestedIframes class FrameNavExpectationsFactoryBrowserTestNestedIframesSameOrigin : public FrameNavExpectationsFactoryBrowser { public: - FrameNavExpectationsFactoryBrowserTestNestedIframesSameOrigin() - : create_count_(0) {} + FrameNavExpectationsFactoryBrowserTestNestedIframesSameOrigin() = default; FrameNavFactoryId GetID() const override { return FNF_ID_NESTED_IFRAMES_SAME_ORIGIN; @@ -2164,13 +2163,13 @@ class FrameNavExpectationsFactoryBrowserTestNestedIframesSameOrigin } private: - int create_count_; + int create_count_ = 0; }; class FrameNavExpectationsFactoryRendererTestNestedIframesSameOrigin : public FrameNavExpectationsFactoryRenderer { public: - FrameNavExpectationsFactoryRendererTestNestedIframesSameOrigin() {} + FrameNavExpectationsFactoryRendererTestNestedIframesSameOrigin() = default; FrameNavFactoryId GetID() const override { return FNF_ID_NESTED_IFRAMES_SAME_ORIGIN; @@ -2193,8 +2192,7 @@ namespace { class FrameNavExpectationsFactoryBrowserTestNestedIframesDiffOrigin : public FrameNavExpectationsFactoryBrowser { public: - FrameNavExpectationsFactoryBrowserTestNestedIframesDiffOrigin() - : create_count_(0) {} + FrameNavExpectationsFactoryBrowserTestNestedIframesDiffOrigin() = default; FrameNavFactoryId GetID() const override { return FNF_ID_NESTED_IFRAMES_DIFF_ORIGIN; @@ -2218,13 +2216,13 @@ class FrameNavExpectationsFactoryBrowserTestNestedIframesDiffOrigin } private: - int create_count_; + int create_count_ = 0; }; class FrameNavExpectationsFactoryRendererTestNestedIframesDiffOrigin : public FrameNavExpectationsFactoryRenderer { public: - FrameNavExpectationsFactoryRendererTestNestedIframesDiffOrigin() {} + FrameNavExpectationsFactoryRendererTestNestedIframesDiffOrigin() = default; FrameNavFactoryId GetID() const override { return FNF_ID_NESTED_IFRAMES_DIFF_ORIGIN; @@ -2253,24 +2251,28 @@ FrameNavExpectationsFactoryBrowser::FromID(FrameNavFactoryId id) { std::unique_ptr factory; switch (id) { case FNF_ID_SINGLE_NAV_HARNESS: - factory.reset(new FrameNavExpectationsFactoryBrowserTestSingleNavHarness); + factory = std::make_unique< + FrameNavExpectationsFactoryBrowserTestSingleNavHarness>(); break; case FNF_ID_SINGLE_NAV: - factory.reset(new FrameNavExpectationsFactoryBrowserTestSingleNav); + factory = + std::make_unique(); break; case FNF_ID_MULTI_NAV_HARNESS: - factory.reset(new FrameNavExpectationsFactoryBrowserTestMultiNavHarness); + factory = std::make_unique< + FrameNavExpectationsFactoryBrowserTestMultiNavHarness>(); break; case FNF_ID_MULTI_NAV: - factory.reset(new FrameNavExpectationsFactoryBrowserTestMultiNav); + factory = + std::make_unique(); break; case FNF_ID_NESTED_IFRAMES_SAME_ORIGIN: - factory.reset( - new FrameNavExpectationsFactoryBrowserTestNestedIframesSameOrigin); + factory = std::make_unique< + FrameNavExpectationsFactoryBrowserTestNestedIframesSameOrigin>(); break; case FNF_ID_NESTED_IFRAMES_DIFF_ORIGIN: - factory.reset( - new FrameNavExpectationsFactoryBrowserTestNestedIframesDiffOrigin); + factory = std::make_unique< + FrameNavExpectationsFactoryBrowserTestNestedIframesDiffOrigin>(); break; default: break; @@ -2286,25 +2288,28 @@ FrameNavExpectationsFactoryRenderer::FromID(FrameNavFactoryId id) { std::unique_ptr factory; switch (id) { case FNF_ID_SINGLE_NAV_HARNESS: - factory.reset( - new FrameNavExpectationsFactoryRendererTestSingleNavHarness); + factory = std::make_unique< + FrameNavExpectationsFactoryRendererTestSingleNavHarness>(); break; case FNF_ID_SINGLE_NAV: - factory.reset(new FrameNavExpectationsFactoryRendererTestSingleNav); + factory = + std::make_unique(); break; case FNF_ID_MULTI_NAV_HARNESS: - factory.reset(new FrameNavExpectationsFactoryRendererTestMultiNavHarness); + factory = std::make_unique< + FrameNavExpectationsFactoryRendererTestMultiNavHarness>(); break; case FNF_ID_MULTI_NAV: - factory.reset(new FrameNavExpectationsFactoryRendererTestMultiNav); + factory = + std::make_unique(); break; case FNF_ID_NESTED_IFRAMES_SAME_ORIGIN: - factory.reset( - new FrameNavExpectationsFactoryRendererTestNestedIframesSameOrigin); + factory = std::make_unique< + FrameNavExpectationsFactoryRendererTestNestedIframesSameOrigin>(); break; case FNF_ID_NESTED_IFRAMES_DIFF_ORIGIN: - factory.reset( - new FrameNavExpectationsFactoryRendererTestNestedIframesDiffOrigin); + factory = std::make_unique< + FrameNavExpectationsFactoryRendererTestNestedIframesDiffOrigin>(); break; default: break; diff --git a/tests/ceftests/life_span_unittest.cc b/tests/ceftests/life_span_unittest.cc index 772b3f73d..81e18dcad 100644 --- a/tests/ceftests/life_span_unittest.cc +++ b/tests/ceftests/life_span_unittest.cc @@ -18,20 +18,15 @@ const char kUnloadMsg[] = "LifeSpanTestHandler.Unload"; class LifeSpanTestHandler : public RoutingTestHandler { public: struct Settings { - Settings() - : force_close(false), - add_onunload_handler(false), - allow_do_close(true), - accept_before_unload_dialog(true) {} + Settings() = default; - bool force_close; - bool add_onunload_handler; - bool allow_do_close; - bool accept_before_unload_dialog; + bool force_close = false; + bool add_onunload_handler = false; + bool allow_do_close = true; + bool accept_before_unload_dialog = true; }; - explicit LifeSpanTestHandler(const Settings& settings) - : settings_(settings), executing_delay_close_(false) { + explicit LifeSpanTestHandler(const Settings& settings) : settings_(settings) { // By default no LifeSpan tests call DestroyTest(). SetDestroyTestExpected(false); } @@ -176,7 +171,7 @@ class LifeSpanTestHandler : public RoutingTestHandler { Settings settings_; // Forces the window to close (bypasses test conditions). - bool executing_delay_close_; + bool executing_delay_close_ = false; IMPLEMENT_REFCOUNTING(LifeSpanTestHandler); }; diff --git a/tests/ceftests/media_access_unittest.cc b/tests/ceftests/media_access_unittest.cc index 1dd6a86bb..40a7a7646 100644 --- a/tests/ceftests/media_access_unittest.cc +++ b/tests/ceftests/media_access_unittest.cc @@ -30,7 +30,7 @@ constexpr char kMediaNavUrl[] = "https://media-access-test/nav.html"; class MediaAccessBrowserTest : public client::ClientAppBrowser::Delegate, public CefPermissionHandler { public: - MediaAccessBrowserTest() {} + MediaAccessBrowserTest() = default; void OnBeforeCommandLineProcessing( CefRefPtr app, @@ -46,7 +46,7 @@ class MediaAccessBrowserTest : public client::ClientAppBrowser::Delegate, class TestSetup { public: - TestSetup() {} + TestSetup() = default; // CONFIGURATION diff --git a/tests/ceftests/message_router_harness_unittest.cc b/tests/ceftests/message_router_harness_unittest.cc index 42ac03319..1c64ac49d 100644 --- a/tests/ceftests/message_router_harness_unittest.cc +++ b/tests/ceftests/message_router_harness_unittest.cc @@ -9,7 +9,8 @@ namespace { // Used to verify that the test harness (bound functions) behave correctly. class HarnessTestHandler : public SingleLoadTestHandler { public: - HarnessTestHandler(bool test_success) : test_success_(test_success) {} + explicit HarnessTestHandler(bool test_success) + : test_success_(test_success) {} std::string GetMainHTML() override { std::string html; diff --git a/tests/ceftests/message_router_multi_query_unittest.cc b/tests/ceftests/message_router_multi_query_unittest.cc index 01579cc1c..60e4f957b 100644 --- a/tests/ceftests/message_router_multi_query_unittest.cc +++ b/tests/ceftests/message_router_multi_query_unittest.cc @@ -75,7 +75,7 @@ class MultiQueryManager { virtual void OnAllQueriesCompleted(MultiQueryManager* manager) {} protected: - virtual ~Observer() {} + virtual ~Observer() = default; }; MultiQueryManager(const std::string& label, @@ -86,13 +86,7 @@ class MultiQueryManager { synchronous_(synchronous), id_offset_(id_offset), transfer_type_(transfer_type), - finalized_(false), - running_(false), - manual_total_(0), - received_count_(0), - manual_complete_count_(0), - auto_complete_count_(0), - will_cancel_by_removing_handler_(false), + weak_ptr_factory_(this) {} std::string label() const { return label_; } @@ -111,7 +105,7 @@ class MultiQueryManager { // thread. void AddTestQuery(TestType type) { EXPECT_FALSE(finalized_); - test_query_vector_.push_back(TestQuery(type)); + test_query_vector_.emplace_back(type); if (!IsAuto(type)) { manual_total_++; } @@ -503,22 +497,17 @@ class MultiQueryManager { private: struct TestQuery { - explicit TestQuery(TestType test_type) - : type(test_type), - browser_id(0), - frame_id(0), - is_main_frame(false), - query_id(0) {} + explicit TestQuery(TestType test_type) : type(test_type) {} TestType type; // Set in OnQuery and verified in OnNotify or OnQueryCanceled. - int browser_id; - int64_t frame_id; - bool is_main_frame; + int browser_id = 0; + int64_t frame_id = 0; + bool is_main_frame = false; // Used when a query is canceled. - int64_t query_id; + int64_t query_id = 0; CefRefPtr callback; TrackCallback got_query; @@ -858,23 +847,23 @@ class MultiQueryManager { ObserverSet observer_set_; // Set to true after all queries have been added. - bool finalized_; + bool finalized_ = false; // Set to true while queries are pending. - bool running_; + bool running_ = false; // Total number of queries that will manually complete. - int manual_total_; + int manual_total_ = 0; // Number of queries that have been received. - int received_count_; + int received_count_ = 0; // Number of queries that have completed successfully. - int manual_complete_count_; - int auto_complete_count_; + int manual_complete_count_ = 0; + int auto_complete_count_ = 0; // If true any pending queries will receive an onFailure callback in addition // to be canceled. - bool will_cancel_by_removing_handler_; + bool will_cancel_by_removing_handler_ = false; // Should always be the last member. base::WeakPtrFactory weak_ptr_factory_; @@ -902,8 +891,8 @@ void MakeTestQueries(MultiQueryManager* manager, MultiQueryManager::PERSISTENT_SUCCESS, MultiQueryManager::FAILURE, }; - for (size_t i = 0; i < sizeof(types) / sizeof(types[0]); ++i) { - manager->AddTestQuery(types[i]); + for (auto& type : types) { + manager->AddTestQuery(type); } } else { // Test every type of query. @@ -1163,7 +1152,7 @@ class MultiQueryMultiHandlerTestHandler : public SingleLoadTestHandler, class Handler : public CefMessageRouterBrowserSide::Handler { public: Handler(MultiQueryMultiHandlerTestHandler* test_handler, int index) - : test_handler_(test_handler), index_(index), query_id_(0) {} + : test_handler_(test_handler), index_(index) {} bool OnQuery(CefRefPtr browser, CefRefPtr frame, @@ -1228,7 +1217,7 @@ class MultiQueryMultiHandlerTestHandler : public SingleLoadTestHandler, private: MultiQueryMultiHandlerTestHandler* test_handler_; const int index_; - int64_t query_id_; + int64_t query_id_ = 0; }; MultiQueryMultiHandlerTestHandler(bool synchronous, @@ -1414,16 +1403,12 @@ class MultiQueryManagerMap : public MultiQueryManager::Observer { virtual void OnMapAllQueriesCompleted(MultiQueryManagerMap* map) {} protected: - virtual ~Observer() {} + virtual ~Observer() = default; }; - MultiQueryManagerMap() - : finalized_(false), - running_(false), - manual_complete_count_(0), - total_complete_count_(0) {} + MultiQueryManagerMap() = default; - virtual ~MultiQueryManagerMap() { RemoveAllManagers(); } + ~MultiQueryManagerMap() override { RemoveAllManagers(); } void AddObserver(Observer* observer) { EXPECT_FALSE(running_); @@ -1461,8 +1446,8 @@ class MultiQueryManagerMap : public MultiQueryManager::Observer { std::string html = "\n"; - for (size_t i = 0; i < all_managers_.size(); ++i) { - const std::string& url = all_managers_[i]->label(); + for (auto all_manager : all_managers_) { + const std::string& url = all_manager->label(); const std::string& name = GetNameForURL(url); html += "\n"; } @@ -1555,8 +1540,8 @@ class MultiQueryManagerMap : public MultiQueryManager::Observer { bool AllComplete() const { EXPECT_TRUE(finalized_); - for (size_t i = 0; i < all_managers_.size(); ++i) { - if (!all_managers_[i]->IsAllComplete()) { + for (auto all_manager : all_managers_) { + if (!all_manager->IsAllComplete()) { return false; } } @@ -1568,14 +1553,14 @@ class MultiQueryManagerMap : public MultiQueryManager::Observer { EXPECT_TRUE(pending_managers_.empty()); EXPECT_FALSE(running_); - for (size_t i = 0; i < all_managers_.size(); ++i) { - all_managers_[i]->AssertAllComplete(); + for (auto all_manager : all_managers_) { + all_manager->AssertAllComplete(); } } bool HasAutoQueries() const { - for (size_t i = 0; i < all_managers_.size(); ++i) { - if (all_managers_[i]->HasAutoQueries()) { + for (auto all_manager : all_managers_) { + if (all_manager->HasAutoQueries()) { return true; } } @@ -1639,8 +1624,8 @@ class MultiQueryManagerMap : public MultiQueryManager::Observer { return; } - for (size_t i = 0; i < all_managers_.size(); ++i) { - delete all_managers_[i]; + for (auto& all_manager : all_managers_) { + delete all_manager; } all_managers_.clear(); manager_map_.clear(); @@ -1670,13 +1655,13 @@ class MultiQueryManagerMap : public MultiQueryManager::Observer { ObserverSet observer_set_; // Set to true after all query managers have been added. - bool finalized_; + bool finalized_ = false; // Set to true while queries are pending. - bool running_; + bool running_ = false; // Number of managers that have completed. - int manual_complete_count_; - int total_complete_count_; + int manual_complete_count_ = 0; + int total_complete_count_ = 0; }; // Test multiple queries in a single page load with multiple frames. diff --git a/tests/ceftests/message_router_single_query_unittest.cc b/tests/ceftests/message_router_single_query_unittest.cc index 3612a8371..ce066cb59 100644 --- a/tests/ceftests/message_router_single_query_unittest.cc +++ b/tests/ceftests/message_router_single_query_unittest.cc @@ -21,7 +21,7 @@ class SingleQueryTestHandler : public SingleLoadTestHandler { }; SingleQueryTestHandler(TestType type, bool sync_callback) - : test_type_(type), sync_callback_(sync_callback), query_id_(0) {} + : test_type_(type), sync_callback_(sync_callback) {} std::string GetMainHTML() override { std::string html; @@ -210,7 +210,7 @@ class SingleQueryTestHandler : public SingleLoadTestHandler { const TestType test_type_; const bool sync_callback_; - int64_t query_id_; + int64_t query_id_ = 0; CefRefPtr callback_; TrackCallback got_on_query_; @@ -273,7 +273,7 @@ class SinglePersistentQueryTestHandler : public SingleLoadTestHandler { }; SinglePersistentQueryTestHandler(TestType test_type, bool sync_callback) - : test_type_(test_type), sync_callback_(sync_callback), query_id_(0) {} + : test_type_(test_type), sync_callback_(sync_callback) {} std::string GetMainHTML() override { std::string html; @@ -468,7 +468,7 @@ class SinglePersistentQueryTestHandler : public SingleLoadTestHandler { const TestType test_type_; const bool sync_callback_; - int64_t query_id_; + int64_t query_id_ = 0; CefRefPtr callback_; TrackCallback got_on_query_; @@ -519,7 +519,7 @@ namespace { // Test a single unhandled query in a single page load. class SingleUnhandledQueryTestHandler : public SingleLoadTestHandler { public: - SingleUnhandledQueryTestHandler() {} + SingleUnhandledQueryTestHandler() = default; std::string GetMainHTML() override { std::string html; diff --git a/tests/ceftests/navigation_unittest.cc b/tests/ceftests/navigation_unittest.cc index 3662f8542..4df375ca2 100644 --- a/tests/ceftests/navigation_unittest.cc +++ b/tests/ceftests/navigation_unittest.cc @@ -87,7 +87,7 @@ static NavListItem kHNavList[] = { class HistoryNavRendererTest : public ClientAppRenderer::Delegate, public CefLoadHandler { public: - HistoryNavRendererTest() : run_test_(false), nav_(0) {} + HistoryNavRendererTest() = default; void OnBrowserCreated(CefRefPtr app, CefRefPtr browser, @@ -221,8 +221,8 @@ class HistoryNavRendererTest : public ClientAppRenderer::Delegate, nav_++; } - bool run_test_; - int nav_; + bool run_test_ = false; + int nav_ = 0; TrackCallback got_loading_state_start_; TrackCallback got_loading_state_end_; @@ -235,12 +235,7 @@ class HistoryNavRendererTest : public ClientAppRenderer::Delegate, class NavigationEntryVisitor : public CefNavigationEntryVisitor { public: NavigationEntryVisitor(int nav, TrackCallback* callback) - : nav_(nav), - callback_(callback), - expected_total_(0), - expected_current_index_(-1), - expected_forwardback_(), - callback_count_(0) { + : nav_(nav), callback_(callback) { // Determine the expected values. for (int i = 0; i <= nav_; ++i) { if (kHNavList[i].action == NA_LOAD) { @@ -312,10 +307,10 @@ class NavigationEntryVisitor : public CefNavigationEntryVisitor { private: const int nav_; TrackCallback* callback_; - int expected_total_; - int expected_current_index_; - bool expected_forwardback_[3]; // Only 3 loads total. - int callback_count_; + int expected_total_ = 0; + int expected_current_index_ = -1; + bool expected_forwardback_[3] = {}; // Only 3 loads total. + int callback_count_ = 0; IMPLEMENT_REFCOUNTING(NavigationEntryVisitor); }; @@ -653,7 +648,7 @@ const char kDynIfrNav2[] = "https://tests-dynframe/nav2.html"; // Browser side. class HistoryDynamicIFramesNavTestHandler : public TestHandler { public: - HistoryDynamicIFramesNavTestHandler() : nav_(-1) {} + HistoryDynamicIFramesNavTestHandler() = default; void RunTest() override { // Add the resources that we will navigate to/from. @@ -756,7 +751,7 @@ class HistoryDynamicIFramesNavTestHandler : public TestHandler { RunNav(browser); } - int nav_; + int nav_ = -1; TrackCallback got_load_start_[4]; TrackCallback got_load_end_[4]; @@ -794,7 +789,7 @@ bool g_got_invalid_request = false; class RedirectSchemeHandler : public CefResourceHandler { public: - RedirectSchemeHandler() : offset_(0), status_(0) {} + RedirectSchemeHandler() = default; bool Open(CefRefPtr request, bool& handle_request, @@ -885,8 +880,8 @@ class RedirectSchemeHandler : public CefResourceHandler { protected: std::string content_; - size_t offset_; - int status_; + size_t offset_ = 0; + int status_ = 0; std::string location_; IMPLEMENT_REFCOUNTING(RedirectSchemeHandler); @@ -916,7 +911,7 @@ class RedirectSchemeHandlerFactory : public CefSchemeHandlerFactory { class RedirectTestHandler : public TestHandler { public: - RedirectTestHandler() {} + RedirectTestHandler() = default; void RunTest() override { // Create the browser. @@ -1046,7 +1041,7 @@ class RedirectTestHandler : public TestHandler { // Like above but destroy the WebContents while the redirect is in-progress. class RedirectDestroyTestHandler : public TestHandler { public: - RedirectDestroyTestHandler() {} + RedirectDestroyTestHandler() = default; void RunTest() override { // Create the browser. @@ -1221,11 +1216,7 @@ class OrderNavRendererTest : public ClientAppRenderer::Delegate, public CefLoadHandler { public: OrderNavRendererTest() - : run_test_(false), - browser_id_main_(0), - browser_id_popup_(0), - state_main_(false, false), - state_popup_(true, false) {} + : state_main_(false, false), state_popup_(true, false) {} void OnWebKitInitialized(CefRefPtr app) override { EXPECT_FALSE(got_webkit_initialized_); @@ -1414,10 +1405,10 @@ class OrderNavRendererTest : public ClientAppRenderer::Delegate, frame->SendProcessMessage(PID_BROWSER, return_msg); } - bool run_test_; + bool run_test_ = false; - int browser_id_main_; - int browser_id_popup_; + int browser_id_main_ = 0; + int browser_id_popup_ = 0; CefRefPtr browser_main_; TrackCallback got_webkit_initialized_; TrackCallback got_browser_created_main_; @@ -1434,12 +1425,7 @@ class OrderNavRendererTest : public ClientAppRenderer::Delegate, // Browser side. class OrderNavTestHandler : public TestHandler { public: - OrderNavTestHandler() - : browser_id_main_(0), - browser_id_popup_(0), - state_main_(false, true), - state_popup_(true, true), - got_message_(false) {} + OrderNavTestHandler() : state_main_(false, true), state_popup_(true, true) {} // Returns state that will be checked in the renderer process via // OrderNavRendererTest::OnBrowserCreated. @@ -1681,8 +1667,8 @@ class OrderNavTestHandler : public TestHandler { TestHandler::DestroyTest(); } - int browser_id_main_; - int browser_id_popup_; + int browser_id_main_ = 0; + int browser_id_popup_ = 0; CefRefPtr browser_popup_; TrackCallback got_before_browse_main_; @@ -1691,7 +1677,7 @@ class OrderNavTestHandler : public TestHandler { OrderNavLoadState state_main_; OrderNavLoadState state_popup_; - bool got_message_; + bool got_message_ = false; IMPLEMENT_REFCOUNTING(OrderNavTestHandler); }; @@ -2255,11 +2241,7 @@ const size_t kSimultPopupCount = 5U; // Test multiple popups simultaniously. class PopupSimultaneousTestHandler : public TestHandler { public: - explicit PopupSimultaneousTestHandler(bool same_url) - : same_url_(same_url), - before_popup_ct_(0U), - after_created_ct_(0U), - before_close_ct_(0U) {} + explicit PopupSimultaneousTestHandler(bool same_url) : same_url_(same_url) {} void RunTest() override { std::string main_html = "