bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change CefV8ValueImpl::Handle lifespan so that persistent V8 handles can be reset after execution of the weak persistent destructor. The previous implementation reset persistent V8 handles immediately after calling SetWeak which caused a memory leak due to the weak persistent destructor never being executed (issue #1278).

Browse Source 
git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@1712 5089003a-bbd8-11dd-ad1f-f1f9622dbc98
This commit is contained in:
Marshall Greenblatt
2014-05-29 21:25:19 +00:00
parent 74b35c30eb
commit beb198fca9
2 changed files with 99 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
libcef/renderer/v8_impl.h
View File

@ -281,26 +281,19 @@ class CefV8ValueImpl : public CefV8Value {
Handle(v8::Isolate* isolate,
v8::Handle<v8::Context> context,
handleType v,
CefTrackNode* tracker)
: CefV8HandleBase(isolate, context),
handle_(isolate, v),
tracker_(tracker),
should_persist_(false) {
}
CefTrackNode* tracker);
virtual ~Handle();
handleType GetNewV8Handle(bool should_persist) {
DCHECK(IsValid());
if (should_persist && !should_persist_)
should_persist_ = true;
return handleType::New(isolate(), handle_);
}
handleType GetNewV8Handle(bool should_persist);
persistentType& GetPersistentV8Handle() {
return handle_;
}
persistentType& GetPersistentV8Handle();
void SetWeakIfNecessary();
private:
// Callback for weak persistent reference destruction.
static void Destructor(const v8::WeakCallbackData<v8::Value, Handle>& data);
persistentType handle_;
// For Object and Function types, we need to hold on to a reference to their
@ -310,6 +303,9 @@ class CefV8ValueImpl : public CefV8Value {
// True if the handle needs to persist due to it being passed into V8.
bool should_persist_;
// True if the handle has been set as weak.
bool is_set_weak_;
DISALLOW_COPY_AND_ASSIGN(Handle);
};