bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Move CookieManager callbacks to the UI thread (see issue #2622).

Browse Source 
The Chromium content layer (which also exposes the NetworkService interface)
generally runs on the UI thread. Previous use of the IO thread for CookieManager
callbacks is an implementation detail of the old network stack that shouldn't be
exposed to clients.

To test: Run ceftests. They should pass as expected.
This commit is contained in:
Marshall Greenblatt
2019-03-25 14:35:51 -04:00
parent 85c34c4dcf
commit b949d86c40
5 changed files with 64 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
include/cef_cookie.h
View File

@@ -56,7 +56,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
///
// Returns the global cookie manager. By default data will be stored at
// CefSettings.cache_path if specified or in memory otherwise. If |callback|
// is non-NULL it will be executed asnychronously on the IO thread after the
// is non-NULL it will be executed asnychronously on the UI thread after the
// manager's storage has been initialized. Using this method is equivalent to
// calling CefRequestContext::GetGlobalContext()->GetDefaultCookieManager().
///
@@ -67,7 +67,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
///
// Set the schemes supported by this manager. The default schemes ("http",
// "https", "ws" and "wss") will always be supported. If |callback| is non-
// NULL it will be executed asnychronously on the IO thread after the change
// NULL it will be executed asnychronously on the UI thread after the change
// has been applied. Must be called before any cookies are accessed.
///
/*--cef(optional_param=callback)--*/
@@ -76,7 +76,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
CefRefPtr<CefCompletionCallback> callback) = 0;
///
// Visit all cookies on the IO thread. The returned cookies are ordered by
// Visit all cookies on the UI thread. The returned cookies are ordered by
// longest path, then by earliest creation date. Returns false if cookies
// cannot be accessed.
///
@@ -84,7 +84,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
virtual bool VisitAllCookies(CefRefPtr<CefCookieVisitor> visitor) = 0;
///
// Visit a subset of cookies on the IO thread. The results are filtered by the
// Visit a subset of cookies on the UI thread. The results are filtered by the
// given url scheme, host, domain and path. If |includeHttpOnly| is true
// HTTP-only cookies will also be included in the results. The returned
// cookies are ordered by longest path, then by earliest creation date.
@@ -101,7 +101,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
// check for disallowed characters (e.g. the ';' character is disallowed
// within the cookie value attribute) and fail without setting the cookie if
// such characters are found. If |callback| is non-NULL it will be executed
// asnychronously on the IO thread after the cookie has been set. Returns
// asnychronously on the UI thread after the cookie has been set. Returns
// false if an invalid URL is specified or if cookies cannot be accessed.
///
/*--cef(optional_param=callback)--*/
@@ -115,7 +115,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
// both will be deleted. If only |url| is specified all host cookies (but not
// domain cookies) irrespective of path will be deleted. If |url| is empty all
// cookies for all hosts and domains will be deleted. If |callback| is
// non-NULL it will be executed asnychronously on the IO thread after the
// non-NULL it will be executed asnychronously on the UI thread after the
// cookies have been deleted. Returns false if a non-empty invalid URL is
// specified or if cookies cannot be accessed. Cookies can alternately be
// deleted using the Visit*Cookies() methods.
@@ -128,7 +128,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
///
// Flush the backing store (if any) to disk. If |callback| is non-NULL it will
// be executed asnychronously on the IO thread after the flush is complete.
// be executed asnychronously on the UI thread after the flush is complete.
// Returns false if cookies cannot be accessed.
///
/*--cef(optional_param=callback)--*/
@@ -137,7 +137,7 @@ class CefCookieManager : public virtual CefBaseRefCounted {
///
// Interface to implement for visiting cookie values. The methods of this class
// will always be called on the IO thread.
// will always be called on the UI thread.
///
/*--cef(source=client)--*/
class CefCookieVisitor : public virtual CefBaseRefCounted {