bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

cefclient: Fix infinite loop in FilterMenuModel (fixes issue #3392)

Browse Source
This commit is contained in:
Marshall Greenblatt
2022-09-08 12:41:25 -04:00
parent 7898ddafeb
commit b945c64d32
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/cefclient/browser/client_handler.cc
View File

@@ -1422,7 +1422,8 @@ void ClientHandler::SetOfflineState(CefRefPtr<CefBrowser> browser,
void ClientHandler::FilterMenuModel(CefRefPtr<CefMenuModel> model) { void ClientHandler::FilterMenuModel(CefRefPtr<CefMenuModel> model) {
// Evaluate from the bottom to the top because we'll be removing menu items. // Evaluate from the bottom to the top because we'll be removing menu items.
for (size_t i = model->GetCount() - 1; i >= 0; --i) { for (size_t x = model->GetCount(); x > 0; --x) {
const auto i = x - 1;
const auto type = model->GetTypeAt(i); const auto type = model->GetTypeAt(i);
if (type == MENUITEMTYPE_SUBMENU) { if (type == MENUITEMTYPE_SUBMENU) {
// Filter sub-menu and remove if empty. // Filter sub-menu and remove if empty.