bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use the same PDF plugin name as official Chrome

This commit is contained in:
Marshall Greenblatt 2016-08-24 16:25:11 +03:00
parent 3b5fb0d526
commit b89329b0fa
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libcef/browser/extensions/pdf_extension_util.cc
View File

@ -26,7 +26,10 @@ const char kPdfResourceIdentifier[] = "google-chrome-pdf";
const char kPdfResourceIdentifier[] = "chromium-pdf";
#endif
const char kPdfPluginName[] = "Chromium PDF Viewer";
// Match the GOOGLE_CHROME_BUILD value from ChromeContentClient::kPDFPluginName
// to avoid breaking Websites that specifically look for this string in the
// plugin list.
const char kPdfPluginName[] = "Chrome PDF Viewer";
std::string GetManifest() {
std::string manifest_contents =

2
tests/unittests/plugin_unittest.cc
View File

@ -233,7 +233,7 @@ class PluginTestHandler : public RoutingTestHandler,
void WaitForNavigatorPlugins(CefRefPtr<CefFrame> frame) const {
// Test if the `navigator.plugins` list includes the PDF extension.
const std::string& code =
" if (navigator.plugins['Chromium PDF Viewer'].filename == "
" if (navigator.plugins['Chrome PDF Viewer'].filename == "
" 'mhjfbmdgcfjbbpaeojofohoefgiehjai') {"
" window.testQuery({request:'pdf_plugin_found'});"
"} else {"